[INFO] updating cached repository Arekkusuva/try-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Arekkusuva/try-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Arekkusuva/try-rust" "work/ex/clippy-test-run/sources/stable/gh/Arekkusuva/try-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Arekkusuva/try-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Arekkusuva/try-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Arekkusuva/try-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Arekkusuva/try-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 453065a21eca81b37b0511d5558c30272c961d5c [INFO] sha for GitHub repo Arekkusuva/try-rust: 453065a21eca81b37b0511d5558c30272c961d5c [INFO] validating manifest of Arekkusuva/try-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Arekkusuva/try-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Arekkusuva/try-rust [INFO] finished frobbing Arekkusuva/try-rust [INFO] frobbed toml for Arekkusuva/try-rust written to work/ex/clippy-test-run/sources/stable/gh/Arekkusuva/try-rust/Cargo.toml [INFO] started frobbing Arekkusuva/try-rust [INFO] finished frobbing Arekkusuva/try-rust [INFO] frobbed toml for Arekkusuva/try-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Arekkusuva/try-rust/Cargo.toml [INFO] crate Arekkusuva/try-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Arekkusuva/try-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Arekkusuva/try-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe28b5fa6251047105747025c448ddacd87ac1a119d0f395b8659aad6783fcc8 [INFO] running `"docker" "start" "-a" "fe28b5fa6251047105747025c448ddacd87ac1a119d0f395b8659aad6783fcc8"` [INFO] [stderr] Checking serde v1.0.39 [INFO] [stderr] Compiling serde_derive v1.0.39 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking serde-value v0.5.2 [INFO] [stderr] Checking serde_yaml v0.7.3 [INFO] [stderr] Checking serde_json v1.0.15 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking log4rs v0.8.0 [INFO] [stderr] Checking zoma v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/watcher.rs:28:30 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn update(&mut self, c: conf::Config) { [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `task_name` [INFO] [stderr] --> src/watcher.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn start(&mut self, task_name: String) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_task_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `task_name` [INFO] [stderr] --> src/watcher.rs:38:28 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn stop(&mut self, task_name: String) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_task_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `task_name` [INFO] [stderr] --> src/watcher.rs:45:26 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn status(&self, task_name: String) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_task_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `c` [INFO] [stderr] --> src/watcher.rs:28:30 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn update(&mut self, c: conf::Config) { [INFO] [stderr] | ^ help: consider using `_c` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `task_name` [INFO] [stderr] --> src/watcher.rs:33:29 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn start(&mut self, task_name: String) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_task_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `task_name` [INFO] [stderr] --> src/watcher.rs:38:28 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn stop(&mut self, task_name: String) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_task_name` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `task_name` [INFO] [stderr] --> src/watcher.rs:45:26 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn status(&self, task_name: String) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_task_name` instead [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/watcher.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / match c.once { [INFO] [stderr] 63 | | Some(list) => { [INFO] [stderr] 64 | | list.into_iter().for_each(|(task_name, task)| { [INFO] [stderr] 65 | | match task.actions { [INFO] [stderr] ... | [INFO] [stderr] 74 | | _ => () [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if let Some(list) = c.once { [INFO] [stderr] 63 | list.into_iter().for_each(|(task_name, task)| { [INFO] [stderr] 64 | match task.actions { [INFO] [stderr] 65 | Some(actions) => { [INFO] [stderr] 66 | println!("add task: {}", task_name); [INFO] [stderr] 67 | once_result.insert(task_name, actions); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/watcher.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | / match task.actions { [INFO] [stderr] 66 | | Some(actions) => { [INFO] [stderr] 67 | | println!("add task: {}", task_name); [INFO] [stderr] 68 | | once_result.insert(task_name, actions); [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | _ => () [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let Some(actions) = task.actions { [INFO] [stderr] 66 | println!("add task: {}", task_name); [INFO] [stderr] 67 | once_result.insert(task_name, actions); [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/watcher.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / match c.watch { [INFO] [stderr] 79 | | Some(list) => { [INFO] [stderr] 80 | | list.into_iter().for_each(|watch_conf| { [INFO] [stderr] 81 | | let watch = Watch { [INFO] [stderr] ... | [INFO] [stderr] 102 | | _ => (), [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | if let Some(list) = c.watch { [INFO] [stderr] 79 | list.into_iter().for_each(|watch_conf| { [INFO] [stderr] 80 | let watch = Watch { [INFO] [stderr] 81 | name: match watch_conf.name { [INFO] [stderr] 82 | Some(v) => v, [INFO] [stderr] 83 | _ => String::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/watcher.rs:108:27 [INFO] [stderr] | [INFO] [stderr] 108 | fn handle_once(task_name: &String, actions: &Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/watcher.rs:108:45 [INFO] [stderr] | [INFO] [stderr] 108 | fn handle_once(task_name: &String, actions: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/watcher.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / match c.once { [INFO] [stderr] 63 | | Some(list) => { [INFO] [stderr] 64 | | list.into_iter().for_each(|(task_name, task)| { [INFO] [stderr] 65 | | match task.actions { [INFO] [stderr] ... | [INFO] [stderr] 74 | | _ => () [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if let Some(list) = c.once { [INFO] [stderr] 63 | list.into_iter().for_each(|(task_name, task)| { [INFO] [stderr] 64 | match task.actions { [INFO] [stderr] 65 | Some(actions) => { [INFO] [stderr] 66 | println!("add task: {}", task_name); [INFO] [stderr] 67 | once_result.insert(task_name, actions); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/watcher.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | / match task.actions { [INFO] [stderr] 66 | | Some(actions) => { [INFO] [stderr] 67 | | println!("add task: {}", task_name); [INFO] [stderr] 68 | | once_result.insert(task_name, actions); [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | _ => () [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let Some(actions) = task.actions { [INFO] [stderr] 66 | println!("add task: {}", task_name); [INFO] [stderr] 67 | once_result.insert(task_name, actions); [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/watcher.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / match c.watch { [INFO] [stderr] 79 | | Some(list) => { [INFO] [stderr] 80 | | list.into_iter().for_each(|watch_conf| { [INFO] [stderr] 81 | | let watch = Watch { [INFO] [stderr] ... | [INFO] [stderr] 102 | | _ => (), [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | if let Some(list) = c.watch { [INFO] [stderr] 79 | list.into_iter().for_each(|watch_conf| { [INFO] [stderr] 80 | let watch = Watch { [INFO] [stderr] 81 | name: match watch_conf.name { [INFO] [stderr] 82 | Some(v) => v, [INFO] [stderr] 83 | _ => String::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/watcher.rs:108:27 [INFO] [stderr] | [INFO] [stderr] 108 | fn handle_once(task_name: &String, actions: &Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/watcher.rs:108:45 [INFO] [stderr] | [INFO] [stderr] 108 | fn handle_once(task_name: &String, actions: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 32.21s [INFO] running `"docker" "inspect" "fe28b5fa6251047105747025c448ddacd87ac1a119d0f395b8659aad6783fcc8"` [INFO] running `"docker" "rm" "-f" "fe28b5fa6251047105747025c448ddacd87ac1a119d0f395b8659aad6783fcc8"` [INFO] [stdout] fe28b5fa6251047105747025c448ddacd87ac1a119d0f395b8659aad6783fcc8