[INFO] updating cached repository AregevDev/rust_game [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AregevDev/rust_game [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AregevDev/rust_game" "work/ex/clippy-test-run/sources/stable/gh/AregevDev/rust_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AregevDev/rust_game'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AregevDev/rust_game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AregevDev/rust_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AregevDev/rust_game'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5652ea98b6ed8cf19d928c725a5e303210a8f8e3 [INFO] sha for GitHub repo AregevDev/rust_game: 5652ea98b6ed8cf19d928c725a5e303210a8f8e3 [INFO] validating manifest of AregevDev/rust_game on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AregevDev/rust_game on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AregevDev/rust_game [INFO] finished frobbing AregevDev/rust_game [INFO] frobbed toml for AregevDev/rust_game written to work/ex/clippy-test-run/sources/stable/gh/AregevDev/rust_game/Cargo.toml [INFO] started frobbing AregevDev/rust_game [INFO] finished frobbing AregevDev/rust_game [INFO] frobbed toml for AregevDev/rust_game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AregevDev/rust_game/Cargo.toml [INFO] crate AregevDev/rust_game has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AregevDev/rust_game against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AregevDev/rust_game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f4f151c3b2b0ed8d2e466014f073be627fb2880a7b086c6dff46da84a8f1619f [INFO] running `"docker" "start" "-a" "f4f151c3b2b0ed8d2e466014f073be627fb2880a7b086c6dff46da84a8f1619f"` [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking pistoncore-input v0.22.0 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-window v0.33.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.48.0 [INFO] [stderr] Checking pistoncore-event_loop v0.38.0 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking piston v0.38.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.54.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.34.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.52.0 [INFO] [stderr] Checking piston_window v0.82.0 [INFO] [stderr] Checking rust_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/game_window.rs:12:40 [INFO] [stderr] | [INFO] [stderr] 12 | self.gl.draw(args.viewport(), |ctx, gl| { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/game_window.rs:17:30 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/player.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_window.rs:17:36 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/player.rs:32:36 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/player.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | self.dir = match btn { [INFO] [stderr] | ____________________^ [INFO] [stderr] 55 | | &Button::Keyboard(Key::Up) => Some(Direction::Up), [INFO] [stderr] 56 | | &Button::Keyboard(Key::Down) => Some(Direction::Down), [INFO] [stderr] 57 | | &Button::Keyboard(Key::Left) => Some(Direction::Left), [INFO] [stderr] 58 | | &Button::Keyboard(Key::Right) => Some(Direction::Right), [INFO] [stderr] 59 | | _ => None, [INFO] [stderr] 60 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | self.dir = match *btn { [INFO] [stderr] 55 | Button::Keyboard(Key::Up) => Some(Direction::Up), [INFO] [stderr] 56 | Button::Keyboard(Key::Down) => Some(Direction::Down), [INFO] [stderr] 57 | Button::Keyboard(Key::Left) => Some(Direction::Left), [INFO] [stderr] 58 | Button::Keyboard(Key::Right) => Some(Direction::Right), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/player.rs:64:20 [INFO] [stderr] | [INFO] [stderr] 64 | self.dir = match btn { [INFO] [stderr] | ____________________^ [INFO] [stderr] 65 | | &Button::Keyboard(Key::Up) => None, [INFO] [stderr] 66 | | &Button::Keyboard(Key::Down) => None, [INFO] [stderr] 67 | | &Button::Keyboard(Key::Left) => None, [INFO] [stderr] 68 | | &Button::Keyboard(Key::Right) => None, [INFO] [stderr] 69 | | _ => None, [INFO] [stderr] 70 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 64 | self.dir = match *btn { [INFO] [stderr] 65 | Button::Keyboard(Key::Up) => None, [INFO] [stderr] 66 | Button::Keyboard(Key::Down) => None, [INFO] [stderr] 67 | Button::Keyboard(Key::Left) => None, [INFO] [stderr] 68 | Button::Keyboard(Key::Right) => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ctx` [INFO] [stderr] --> src/game_window.rs:12:40 [INFO] [stderr] | [INFO] [stderr] 12 | self.gl.draw(args.viewport(), |ctx, gl| { [INFO] [stderr] | ^^^ help: consider using `_ctx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/game_window.rs:17:30 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/player.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game_window.rs:17:36 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/player.rs:32:36 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/player.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | self.dir = match btn { [INFO] [stderr] | ____________________^ [INFO] [stderr] 55 | | &Button::Keyboard(Key::Up) => Some(Direction::Up), [INFO] [stderr] 56 | | &Button::Keyboard(Key::Down) => Some(Direction::Down), [INFO] [stderr] 57 | | &Button::Keyboard(Key::Left) => Some(Direction::Left), [INFO] [stderr] 58 | | &Button::Keyboard(Key::Right) => Some(Direction::Right), [INFO] [stderr] 59 | | _ => None, [INFO] [stderr] 60 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | self.dir = match *btn { [INFO] [stderr] 55 | Button::Keyboard(Key::Up) => Some(Direction::Up), [INFO] [stderr] 56 | Button::Keyboard(Key::Down) => Some(Direction::Down), [INFO] [stderr] 57 | Button::Keyboard(Key::Left) => Some(Direction::Left), [INFO] [stderr] 58 | Button::Keyboard(Key::Right) => Some(Direction::Right), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/player.rs:64:20 [INFO] [stderr] | [INFO] [stderr] 64 | self.dir = match btn { [INFO] [stderr] | ____________________^ [INFO] [stderr] 65 | | &Button::Keyboard(Key::Up) => None, [INFO] [stderr] 66 | | &Button::Keyboard(Key::Down) => None, [INFO] [stderr] 67 | | &Button::Keyboard(Key::Left) => None, [INFO] [stderr] 68 | | &Button::Keyboard(Key::Right) => None, [INFO] [stderr] 69 | | _ => None, [INFO] [stderr] 70 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 64 | self.dir = match *btn { [INFO] [stderr] 65 | Button::Keyboard(Key::Up) => None, [INFO] [stderr] 66 | Button::Keyboard(Key::Down) => None, [INFO] [stderr] 67 | Button::Keyboard(Key::Left) => None, [INFO] [stderr] 68 | Button::Keyboard(Key::Right) => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 07s [INFO] running `"docker" "inspect" "f4f151c3b2b0ed8d2e466014f073be627fb2880a7b086c6dff46da84a8f1619f"` [INFO] running `"docker" "rm" "-f" "f4f151c3b2b0ed8d2e466014f073be627fb2880a7b086c6dff46da84a8f1619f"` [INFO] [stdout] f4f151c3b2b0ed8d2e466014f073be627fb2880a7b086c6dff46da84a8f1619f