[INFO] updating cached repository ArcDM/class-project-Rust-bag [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ArcDM/class-project-Rust-bag [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ArcDM/class-project-Rust-bag" "work/ex/clippy-test-run/sources/stable/gh/ArcDM/class-project-Rust-bag"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ArcDM/class-project-Rust-bag'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ArcDM/class-project-Rust-bag" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ArcDM/class-project-Rust-bag"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ArcDM/class-project-Rust-bag'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 565bf99fa7cc98d6e59c011fdeff67b76b1522f8 [INFO] sha for GitHub repo ArcDM/class-project-Rust-bag: 565bf99fa7cc98d6e59c011fdeff67b76b1522f8 [INFO] validating manifest of ArcDM/class-project-Rust-bag on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ArcDM/class-project-Rust-bag on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ArcDM/class-project-Rust-bag [INFO] finished frobbing ArcDM/class-project-Rust-bag [INFO] frobbed toml for ArcDM/class-project-Rust-bag written to work/ex/clippy-test-run/sources/stable/gh/ArcDM/class-project-Rust-bag/Cargo.toml [INFO] started frobbing ArcDM/class-project-Rust-bag [INFO] finished frobbing ArcDM/class-project-Rust-bag [INFO] frobbed toml for ArcDM/class-project-Rust-bag written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ArcDM/class-project-Rust-bag/Cargo.toml [INFO] crate ArcDM/class-project-Rust-bag has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ArcDM/class-project-Rust-bag against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ArcDM/class-project-Rust-bag:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 775619b61c9deb5b0d104677e84a08011647931c2d4c138af39c3c35dfc800a7 [INFO] running `"docker" "start" "-a" "775619b61c9deb5b0d104677e84a08011647931c2d4c138af39c3c35dfc800a7"` [INFO] [stderr] Checking len-trait v0.6.1 [INFO] [stderr] Checking bag2 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bag.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / { [INFO] [stderr] 162 | | if self.data.len() < new_capacity [INFO] [stderr] 163 | | { [INFO] [stderr] 164 | | new_capacity -= self.data.len(); [INFO] [stderr] 165 | | self.data.extend( vec![ Type::default(); new_capacity ] ); [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 161 | if self.data.len() < new_capacity [INFO] [stderr] 162 | { [INFO] [stderr] 163 | new_capacity -= self.data.len(); [INFO] [stderr] 164 | self.data.extend( vec![ Type::default(); new_capacity ] ); [INFO] [stderr] 165 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bag.rs:596:9 [INFO] [stderr] | [INFO] [stderr] 596 | / { [INFO] [stderr] 597 | | if self.data.len() < new_capacity [INFO] [stderr] 598 | | { [INFO] [stderr] 599 | | new_capacity -= self.data.len(); [INFO] [stderr] 600 | | self.data.extend( vec![ Type::default(); new_capacity ] ); [INFO] [stderr] 601 | | } [INFO] [stderr] 602 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 596 | if self.data.len() < new_capacity [INFO] [stderr] 597 | { [INFO] [stderr] 598 | new_capacity -= self.data.len(); [INFO] [stderr] 599 | self.data.extend( vec![ Type::default(); new_capacity ] ); [INFO] [stderr] 600 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bagf64.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / { [INFO] [stderr] 162 | | if self.data.len() < new_capacity [INFO] [stderr] 163 | | { [INFO] [stderr] 164 | | new_capacity -= self.data.len(); [INFO] [stderr] 165 | | self.data.extend( vec![ value_type::default(); new_capacity ] ); [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 161 | if self.data.len() < new_capacity [INFO] [stderr] 162 | { [INFO] [stderr] 163 | new_capacity -= self.data.len(); [INFO] [stderr] 164 | self.data.extend( vec![ value_type::default(); new_capacity ] ); [INFO] [stderr] 165 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bagf64.rs:596:9 [INFO] [stderr] | [INFO] [stderr] 596 | / { [INFO] [stderr] 597 | | if self.data.len() < new_capacity [INFO] [stderr] 598 | | { [INFO] [stderr] 599 | | new_capacity -= self.data.len(); [INFO] [stderr] 600 | | self.data.extend( vec![ value_type::default(); new_capacity ] ); [INFO] [stderr] 601 | | } [INFO] [stderr] 602 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 596 | if self.data.len() < new_capacity [INFO] [stderr] 597 | { [INFO] [stderr] 598 | new_capacity -= self.data.len(); [INFO] [stderr] 599 | self.data.extend( vec![ value_type::default(); new_capacity ] ); [INFO] [stderr] 600 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bagVec.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / { [INFO] [stderr] 170 | | if self.data.capacity() < new_capacity [INFO] [stderr] 171 | | { [INFO] [stderr] 172 | | new_capacity -= self.data.capacity(); [INFO] [stderr] 173 | | self.data.reserve_exact( new_capacity ); [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 169 | if self.data.capacity() < new_capacity [INFO] [stderr] 170 | { [INFO] [stderr] 171 | new_capacity -= self.data.capacity(); [INFO] [stderr] 172 | self.data.reserve_exact( new_capacity ); [INFO] [stderr] 173 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bagVec.rs:609:9 [INFO] [stderr] | [INFO] [stderr] 609 | / { [INFO] [stderr] 610 | | if self.data.capacity() < new_capacity [INFO] [stderr] 611 | | { [INFO] [stderr] 612 | | new_capacity -= self.data.capacity(); [INFO] [stderr] 613 | | self.data.reserve_exact( new_capacity ); [INFO] [stderr] 614 | | } [INFO] [stderr] 615 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 609 | if self.data.capacity() < new_capacity [INFO] [stderr] 610 | { [INFO] [stderr] 611 | new_capacity -= self.data.capacity(); [INFO] [stderr] 612 | self.data.reserve_exact( new_capacity ); [INFO] [stderr] 613 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/bagtest.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bag.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / { [INFO] [stderr] 162 | | if self.data.len() < new_capacity [INFO] [stderr] 163 | | { [INFO] [stderr] 164 | | new_capacity -= self.data.len(); [INFO] [stderr] 165 | | self.data.extend( vec![ Type::default(); new_capacity ] ); [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 161 | if self.data.len() < new_capacity [INFO] [stderr] 162 | { [INFO] [stderr] 163 | new_capacity -= self.data.len(); [INFO] [stderr] 164 | self.data.extend( vec![ Type::default(); new_capacity ] ); [INFO] [stderr] 165 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bag.rs:596:9 [INFO] [stderr] | [INFO] [stderr] 596 | / { [INFO] [stderr] 597 | | if self.data.len() < new_capacity [INFO] [stderr] 598 | | { [INFO] [stderr] 599 | | new_capacity -= self.data.len(); [INFO] [stderr] 600 | | self.data.extend( vec![ Type::default(); new_capacity ] ); [INFO] [stderr] 601 | | } [INFO] [stderr] 602 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 596 | if self.data.len() < new_capacity [INFO] [stderr] 597 | { [INFO] [stderr] 598 | new_capacity -= self.data.len(); [INFO] [stderr] 599 | self.data.extend( vec![ Type::default(); new_capacity ] ); [INFO] [stderr] 600 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/bagexam.rs:74:26 [INFO] [stderr] | [INFO] [stderr] 74 | test_bag.insert( ( rand::random::() % 50 ) ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/bagexam.rs:74:26 [INFO] [stderr] | [INFO] [stderr] 74 | test_bag.insert( ( rand::random::() % 50 ) ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bagf64.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / { [INFO] [stderr] 162 | | if self.data.len() < new_capacity [INFO] [stderr] 163 | | { [INFO] [stderr] 164 | | new_capacity -= self.data.len(); [INFO] [stderr] 165 | | self.data.extend( vec![ value_type::default(); new_capacity ] ); [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 161 | if self.data.len() < new_capacity [INFO] [stderr] 162 | { [INFO] [stderr] 163 | new_capacity -= self.data.len(); [INFO] [stderr] 164 | self.data.extend( vec![ value_type::default(); new_capacity ] ); [INFO] [stderr] 165 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bagf64.rs:596:9 [INFO] [stderr] | [INFO] [stderr] 596 | / { [INFO] [stderr] 597 | | if self.data.len() < new_capacity [INFO] [stderr] 598 | | { [INFO] [stderr] 599 | | new_capacity -= self.data.len(); [INFO] [stderr] 600 | | self.data.extend( vec![ value_type::default(); new_capacity ] ); [INFO] [stderr] 601 | | } [INFO] [stderr] 602 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 596 | if self.data.len() < new_capacity [INFO] [stderr] 597 | { [INFO] [stderr] 598 | new_capacity -= self.data.len(); [INFO] [stderr] 599 | self.data.extend( vec![ value_type::default(); new_capacity ] ); [INFO] [stderr] 600 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/bagexamf64.rs:73:26 [INFO] [stderr] | [INFO] [stderr] 73 | test_bag.insert( ( rand::random::() % 50.0 ) ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/bagexamf64.rs:73:26 [INFO] [stderr] | [INFO] [stderr] 73 | test_bag.insert( ( rand::random::() % 50.0 ) ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bagVec.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | / { [INFO] [stderr] 170 | | if self.data.capacity() < new_capacity [INFO] [stderr] 171 | | { [INFO] [stderr] 172 | | new_capacity -= self.data.capacity(); [INFO] [stderr] 173 | | self.data.reserve_exact( new_capacity ); [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 169 | if self.data.capacity() < new_capacity [INFO] [stderr] 170 | { [INFO] [stderr] 171 | new_capacity -= self.data.capacity(); [INFO] [stderr] 172 | self.data.reserve_exact( new_capacity ); [INFO] [stderr] 173 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bagVec.rs:609:9 [INFO] [stderr] | [INFO] [stderr] 609 | / { [INFO] [stderr] 610 | | if self.data.capacity() < new_capacity [INFO] [stderr] 611 | | { [INFO] [stderr] 612 | | new_capacity -= self.data.capacity(); [INFO] [stderr] 613 | | self.data.reserve_exact( new_capacity ); [INFO] [stderr] 614 | | } [INFO] [stderr] 615 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 609 | if self.data.capacity() < new_capacity [INFO] [stderr] 610 | { [INFO] [stderr] 611 | new_capacity -= self.data.capacity(); [INFO] [stderr] 612 | self.data.reserve_exact( new_capacity ); [INFO] [stderr] 613 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bag.rs:96:12 [INFO] [stderr] | [INFO] [stderr] 96 | if initial_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using initial_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bag.rs:156:12 [INFO] [stderr] | [INFO] [stderr] 156 | if new_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using new_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bag.rs:542:12 [INFO] [stderr] | [INFO] [stderr] 542 | if initial_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using initial_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bag.rs:591:12 [INFO] [stderr] | [INFO] [stderr] 591 | if new_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using new_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/bag.rs:748:5 [INFO] [stderr] | [INFO] [stderr] 748 | / fn ne( &self, other: &Bag ) -> bool [INFO] [stderr] 749 | | { [INFO] [stderr] 750 | | !( self == other ) [INFO] [stderr] 751 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bagf64.rs:96:12 [INFO] [stderr] | [INFO] [stderr] 96 | if initial_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using initial_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/bagtest.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bagf64.rs:156:12 [INFO] [stderr] | [INFO] [stderr] 156 | if new_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using new_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/bagf64.rs:225:16 [INFO] [stderr] | [INFO] [stderr] 225 | if self.data[ index ] == target [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.data[ index ] - target).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/bagf64.rs:225:16 [INFO] [stderr] | [INFO] [stderr] 225 | if self.data[ index ] == target [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bagf64.rs:228:37 [INFO] [stderr] | [INFO] [stderr] 228 | self.data[ index ] = self.data[ self.used ].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.data[ self.used ]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/bagf64.rs:269:67 [INFO] [stderr] | [INFO] [stderr] 269 | match self.data[ ..self.used ].iter().position( | value | *value == target ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*value - target).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/bagf64.rs:269:67 [INFO] [stderr] | [INFO] [stderr] 269 | match self.data[ ..self.used ].iter().position( | value | *value == target ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bagf64.rs:275:42 [INFO] [stderr] | [INFO] [stderr] 275 | self.data[ index ] = self.data[ self.used ].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.data[ self.used ]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/bagf64.rs:370:53 [INFO] [stderr] | [INFO] [stderr] 370 | .filter( | &value | *value == target ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*value - target).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/bagf64.rs:370:53 [INFO] [stderr] | [INFO] [stderr] 370 | .filter( | &value | *value == target ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bagf64.rs:542:12 [INFO] [stderr] | [INFO] [stderr] 542 | if initial_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using initial_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bagf64.rs:591:12 [INFO] [stderr] | [INFO] [stderr] 591 | if new_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using new_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/bagf64.rs:748:5 [INFO] [stderr] | [INFO] [stderr] 748 | / fn ne( &self, other: &Bag ) -> bool [INFO] [stderr] 749 | | { [INFO] [stderr] 750 | | !( self == other ) [INFO] [stderr] 751 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bagVec.rs:100:12 [INFO] [stderr] | [INFO] [stderr] 100 | if initial_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using initial_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bagVec.rs:164:12 [INFO] [stderr] | [INFO] [stderr] 164 | if new_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using new_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bagVec.rs:551:12 [INFO] [stderr] | [INFO] [stderr] 551 | if initial_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using initial_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bagVec.rs:604:12 [INFO] [stderr] | [INFO] [stderr] 604 | if new_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using new_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/bagVec.rs:760:5 [INFO] [stderr] | [INFO] [stderr] 760 | / fn ne( &self, other: &Bag ) -> bool [INFO] [stderr] 761 | | { [INFO] [stderr] 762 | | !( self == other ) [INFO] [stderr] 763 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bagVec.rs:855:12 [INFO] [stderr] | [INFO] [stderr] 855 | if self.data.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 15 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bag2`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bag.rs:96:12 [INFO] [stderr] | [INFO] [stderr] 96 | if initial_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using initial_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bag.rs:156:12 [INFO] [stderr] | [INFO] [stderr] 156 | if new_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using new_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bag.rs:542:12 [INFO] [stderr] | [INFO] [stderr] 542 | if initial_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using initial_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bag.rs:591:12 [INFO] [stderr] | [INFO] [stderr] 591 | if new_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using new_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/bag.rs:748:5 [INFO] [stderr] | [INFO] [stderr] 748 | / fn ne( &self, other: &Bag ) -> bool [INFO] [stderr] 749 | | { [INFO] [stderr] 750 | | !( self == other ) [INFO] [stderr] 751 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let oldbytes =` [INFO] [stderr] --> src/bagexam.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | let oldbytes; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let newbytes =` [INFO] [stderr] --> src/bagexam.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | let newbytes; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 42 [INFO] [stderr] --> src/bagexam.rs:154:1 [INFO] [stderr] | [INFO] [stderr] 154 | / fn test4() [INFO] [stderr] 155 | | { [INFO] [stderr] 156 | | let mut test_bag = Bag::new(); [INFO] [stderr] 157 | | [INFO] [stderr] ... | [INFO] [stderr] 265 | | assert_eq!( test_bag.len(), 1 ); [INFO] [stderr] 266 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bagf64.rs:96:12 [INFO] [stderr] | [INFO] [stderr] 96 | if initial_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using initial_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bagf64.rs:156:12 [INFO] [stderr] | [INFO] [stderr] 156 | if new_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using new_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/bagf64.rs:225:16 [INFO] [stderr] | [INFO] [stderr] 225 | if self.data[ index ] == target [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self.data[ index ] - target).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/bagf64.rs:225:16 [INFO] [stderr] | [INFO] [stderr] 225 | if self.data[ index ] == target [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bagf64.rs:228:37 [INFO] [stderr] | [INFO] [stderr] 228 | self.data[ index ] = self.data[ self.used ].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.data[ self.used ]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/bagf64.rs:269:67 [INFO] [stderr] | [INFO] [stderr] 269 | match self.data[ ..self.used ].iter().position( | value | *value == target ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*value - target).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/bagf64.rs:269:67 [INFO] [stderr] | [INFO] [stderr] 269 | match self.data[ ..self.used ].iter().position( | value | *value == target ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bagf64.rs:275:42 [INFO] [stderr] | [INFO] [stderr] 275 | self.data[ index ] = self.data[ self.used ].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.data[ self.used ]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/bagf64.rs:370:53 [INFO] [stderr] | [INFO] [stderr] 370 | .filter( | &value | *value == target ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*value - target).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/bagf64.rs:370:53 [INFO] [stderr] | [INFO] [stderr] 370 | .filter( | &value | *value == target ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bagf64.rs:542:12 [INFO] [stderr] | [INFO] [stderr] 542 | if initial_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using initial_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bagf64.rs:591:12 [INFO] [stderr] | [INFO] [stderr] 591 | if new_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using new_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/bagf64.rs:748:5 [INFO] [stderr] | [INFO] [stderr] 748 | / fn ne( &self, other: &Bag ) -> bool [INFO] [stderr] 749 | | { [INFO] [stderr] 750 | | !( self == other ) [INFO] [stderr] 751 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 42 [INFO] [stderr] --> src/bagexamf64.rs:143:1 [INFO] [stderr] | [INFO] [stderr] 143 | / fn test4() [INFO] [stderr] 144 | | { [INFO] [stderr] 145 | | let mut test_bag = Bag::new(); [INFO] [stderr] 146 | | [INFO] [stderr] ... | [INFO] [stderr] 254 | | assert_eq!( test_bag.len(), 1 ); [INFO] [stderr] 255 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bagVec.rs:100:12 [INFO] [stderr] | [INFO] [stderr] 100 | if initial_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using initial_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bagVec.rs:164:12 [INFO] [stderr] | [INFO] [stderr] 164 | if new_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using new_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bagVec.rs:551:12 [INFO] [stderr] | [INFO] [stderr] 551 | if initial_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using initial_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/bagVec.rs:604:12 [INFO] [stderr] | [INFO] [stderr] 604 | if new_capacity <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using new_capacity == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/bagVec.rs:760:5 [INFO] [stderr] | [INFO] [stderr] 760 | / fn ne( &self, other: &Bag ) -> bool [INFO] [stderr] 761 | | { [INFO] [stderr] 762 | | !( self == other ) [INFO] [stderr] 763 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bagVec.rs:855:12 [INFO] [stderr] | [INFO] [stderr] 855 | if self.data.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 15 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bag2`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "775619b61c9deb5b0d104677e84a08011647931c2d4c138af39c3c35dfc800a7"` [INFO] running `"docker" "rm" "-f" "775619b61c9deb5b0d104677e84a08011647931c2d4c138af39c3c35dfc800a7"` [INFO] [stdout] 775619b61c9deb5b0d104677e84a08011647931c2d4c138af39c3c35dfc800a7