[INFO] updating cached repository Aofusa/gemspt-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Aofusa/gemspt-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Aofusa/gemspt-rs" "work/ex/clippy-test-run/sources/stable/gh/Aofusa/gemspt-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Aofusa/gemspt-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Aofusa/gemspt-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aofusa/gemspt-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aofusa/gemspt-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 58862f20eb29dbeb732a86edd347e8e5b26326eb [INFO] sha for GitHub repo Aofusa/gemspt-rs: 58862f20eb29dbeb732a86edd347e8e5b26326eb [INFO] validating manifest of Aofusa/gemspt-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Aofusa/gemspt-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Aofusa/gemspt-rs [INFO] finished frobbing Aofusa/gemspt-rs [INFO] frobbed toml for Aofusa/gemspt-rs written to work/ex/clippy-test-run/sources/stable/gh/Aofusa/gemspt-rs/Cargo.toml [INFO] started frobbing Aofusa/gemspt-rs [INFO] finished frobbing Aofusa/gemspt-rs [INFO] frobbed toml for Aofusa/gemspt-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aofusa/gemspt-rs/Cargo.toml [INFO] crate Aofusa/gemspt-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Aofusa/gemspt-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Aofusa/gemspt-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c62cf6c94bbb8efd429a10631facf09b053e785d05a5d0321be38d924c691f65 [INFO] running `"docker" "start" "-a" "c62cf6c94bbb8efd429a10631facf09b053e785d05a5d0321be38d924c691f65"` [INFO] [stderr] Checking gemspt-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:13:15 [INFO] [stderr] | [INFO] [stderr] 13 | Ray { org: org, dir: dir } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `org` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | Ray { org: org, dir: dir } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | reflectance: reflectance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflectance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | reflectance: reflectance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflectance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | reflectance: reflectance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflectance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | n: n, [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | reflectance: reflectance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflectance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | ior: ior, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ior` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:343:13 [INFO] [stderr] | [INFO] [stderr] 343 | emission: emission, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `emission` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:25:23 [INFO] [stderr] | [INFO] [stderr] 25 | SceneSphere { sphere: sphere, material: material } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sphere` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | SceneSphere { sphere: sphere, material: material } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:13:15 [INFO] [stderr] | [INFO] [stderr] 13 | Ray { org: org, dir: dir } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `org` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | Ray { org: org, dir: dir } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | reflectance: reflectance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflectance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | reflectance: reflectance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflectance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | reflectance: reflectance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflectance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | n: n, [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | reflectance: reflectance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflectance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | ior: ior, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ior` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:343:13 [INFO] [stderr] | [INFO] [stderr] 343 | emission: emission, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `emission` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:25:23 [INFO] [stderr] | [INFO] [stderr] 25 | SceneSphere { sphere: sphere, material: material } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sphere` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | SceneSphere { sphere: sphere, material: material } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/random.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | self.x.wrapping_mul(2685821657736338717_u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `2_685_821_657_736_338_717_u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/random.rs:34:27 [INFO] [stderr] | [INFO] [stderr] 34 | XorShift { x: 0xDEADBEEFDEADBEEF } // xorshift64*のseedは非ゼロでないといけない。 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xDEAD_BEEF_DEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | return reflection_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `reflection_dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | Vec { x: 0.0, y: -100000.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:53:43 [INFO] [stderr] | [INFO] [stderr] 53 | Vec { x: 0.0, y: 100004.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_004.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:61:25 [INFO] [stderr] | [INFO] [stderr] 61 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:62:35 [INFO] [stderr] | [INFO] [stderr] 62 | Vec { x: -100003.0, y: 0.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_003.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:70:25 [INFO] [stderr] | [INFO] [stderr] 70 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:79:25 [INFO] [stderr] | [INFO] [stderr] 79 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:80:51 [INFO] [stderr] | [INFO] [stderr] 80 | Vec { x: 0.0, y: 0.0, z: -100003.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_003.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:119:43 [INFO] [stderr] | [INFO] [stderr] 119 | Vec { x: 0.0, y: -100000.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:130:25 [INFO] [stderr] | [INFO] [stderr] 130 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:131:43 [INFO] [stderr] | [INFO] [stderr] 131 | Vec { x: 0.0, y: 100004.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_004.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:139:25 [INFO] [stderr] | [INFO] [stderr] 139 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:140:35 [INFO] [stderr] | [INFO] [stderr] 140 | Vec { x: -100003.0, y: 0.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_003.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:148:25 [INFO] [stderr] | [INFO] [stderr] 148 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:157:25 [INFO] [stderr] | [INFO] [stderr] 157 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:158:51 [INFO] [stderr] | [INFO] [stderr] 158 | Vec { x: 0.0, y: 0.0, z: -100003.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_003.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:196:25 [INFO] [stderr] | [INFO] [stderr] 196 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:197:43 [INFO] [stderr] | [INFO] [stderr] 197 | Vec { x: 0.0, y: -100000.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:205:25 [INFO] [stderr] | [INFO] [stderr] 205 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:206:43 [INFO] [stderr] | [INFO] [stderr] 206 | Vec { x: 0.0, y: 100004.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_004.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 214 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:215:35 [INFO] [stderr] | [INFO] [stderr] 215 | Vec { x: -100003.0, y: 0.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_003.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:223:25 [INFO] [stderr] | [INFO] [stderr] 223 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:232:25 [INFO] [stderr] | [INFO] [stderr] 232 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:233:51 [INFO] [stderr] | [INFO] [stderr] 233 | Vec { x: 0.0, y: 0.0, z: -100003.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_003.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:264:40 [INFO] [stderr] | [INFO] [stderr] 264 | Color { x: 0.999999, y: 0.999999, z: 0.999999 }, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:264:53 [INFO] [stderr] | [INFO] [stderr] 264 | Color { x: 0.999999, y: 0.999999, z: 0.999999 }, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:264:66 [INFO] [stderr] | [INFO] [stderr] 264 | Color { x: 0.999999, y: 0.999999, z: 0.999999 }, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/random.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | self.x.wrapping_mul(2685821657736338717_u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `2_685_821_657_736_338_717_u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/random.rs:34:27 [INFO] [stderr] | [INFO] [stderr] 34 | XorShift { x: 0xDEADBEEFDEADBEEF } // xorshift64*のseedは非ゼロでないといけない。 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xDEAD_BEEF_DEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | return reflection_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `reflection_dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | Vec { x: 0.0, y: -100000.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:53:43 [INFO] [stderr] | [INFO] [stderr] 53 | Vec { x: 0.0, y: 100004.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_004.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:61:25 [INFO] [stderr] | [INFO] [stderr] 61 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:62:35 [INFO] [stderr] | [INFO] [stderr] 62 | Vec { x: -100003.0, y: 0.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_003.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:70:25 [INFO] [stderr] | [INFO] [stderr] 70 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:79:25 [INFO] [stderr] | [INFO] [stderr] 79 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:80:51 [INFO] [stderr] | [INFO] [stderr] 80 | Vec { x: 0.0, y: 0.0, z: -100003.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_003.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:119:43 [INFO] [stderr] | [INFO] [stderr] 119 | Vec { x: 0.0, y: -100000.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:130:25 [INFO] [stderr] | [INFO] [stderr] 130 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:131:43 [INFO] [stderr] | [INFO] [stderr] 131 | Vec { x: 0.0, y: 100004.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_004.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:139:25 [INFO] [stderr] | [INFO] [stderr] 139 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:140:35 [INFO] [stderr] | [INFO] [stderr] 140 | Vec { x: -100003.0, y: 0.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_003.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:148:25 [INFO] [stderr] | [INFO] [stderr] 148 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:157:25 [INFO] [stderr] | [INFO] [stderr] 157 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:158:51 [INFO] [stderr] | [INFO] [stderr] 158 | Vec { x: 0.0, y: 0.0, z: -100003.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_003.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:196:25 [INFO] [stderr] | [INFO] [stderr] 196 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:197:43 [INFO] [stderr] | [INFO] [stderr] 197 | Vec { x: 0.0, y: -100000.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:205:25 [INFO] [stderr] | [INFO] [stderr] 205 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:206:43 [INFO] [stderr] | [INFO] [stderr] 206 | Vec { x: 0.0, y: 100004.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_004.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:214:25 [INFO] [stderr] | [INFO] [stderr] 214 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:215:35 [INFO] [stderr] | [INFO] [stderr] 215 | Vec { x: -100003.0, y: 0.0, z: 0.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_003.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:223:25 [INFO] [stderr] | [INFO] [stderr] 223 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:232:25 [INFO] [stderr] | [INFO] [stderr] 232 | 100000.0, [INFO] [stderr] | ^^^^^^^^ help: consider: `100_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:233:51 [INFO] [stderr] | [INFO] [stderr] 233 | Vec { x: 0.0, y: 0.0, z: -100003.0 } [INFO] [stderr] | ^^^^^^^^ help: consider: `100_003.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:264:40 [INFO] [stderr] | [INFO] [stderr] 264 | Color { x: 0.999999, y: 0.999999, z: 0.999999 }, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:264:53 [INFO] [stderr] | [INFO] [stderr] 264 | Color { x: 0.999999, y: 0.999999, z: 0.999999 }, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/scene.rs:264:66 [INFO] [stderr] | [INFO] [stderr] 264 | Color { x: 0.999999, y: 0.999999, z: 0.999999 }, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/sphere.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | let c: f64 = &b * &b - Vec::dot(&o_to_p, &o_to_p) + &self.radius_ * &self.radius_; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 27 | let c: f64 = b * b - Vec::dot(&o_to_p, &o_to_p) + &self.radius_ * &self.radius_; [INFO] [stderr] | ^ ^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/sphere.rs:27:61 [INFO] [stderr] | [INFO] [stderr] 27 | let c: f64 = &b * &b - Vec::dot(&o_to_p, &o_to_p) + &self.radius_ * &self.radius_; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 27 | let c: f64 = &b * &b - Vec::dot(&o_to_p, &o_to_p) + self.radius_ * self.radius_; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/sphere.rs:34:23 [INFO] [stderr] | [INFO] [stderr] 34 | let t1: f64 = &b - &sqrt_c; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 34 | let t1: f64 = b - sqrt_c; [INFO] [stderr] | ^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/sphere.rs:35:23 [INFO] [stderr] | [INFO] [stderr] 35 | let t2: f64 = &b + &sqrt_c; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 35 | let t2: f64 = b + sqrt_c; [INFO] [stderr] | ^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/sphere.rs:52:39 [INFO] [stderr] | [INFO] [stderr] 52 | hitpoint.position = ray.org + &hitpoint.distance * ray.dir; [INFO] [stderr] | ------------------^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `hitpoint.distance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/material.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / match self { [INFO] [stderr] 53 | | &Material::LambertianMaterialSimple ( ref material ) => { &material.emission() }, [INFO] [stderr] 54 | | &Material::LambertianMaterial ( ref material ) => { &material.emission() }, [INFO] [stderr] 55 | | &Material::PhongMaterial ( ref material ) => { &material.emission() }, [INFO] [stderr] 56 | | &Material::GlassMaterial ( ref material ) => { &material.emission() }, [INFO] [stderr] 57 | | &Material::Lightsource ( ref material ) => { &material.emission() }, [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | match *self { [INFO] [stderr] 53 | Material::LambertianMaterialSimple ( ref material ) => { &material.emission() }, [INFO] [stderr] 54 | Material::LambertianMaterial ( ref material ) => { &material.emission() }, [INFO] [stderr] 55 | Material::PhongMaterial ( ref material ) => { &material.emission() }, [INFO] [stderr] 56 | Material::GlassMaterial ( ref material ) => { &material.emission() }, [INFO] [stderr] 57 | Material::Lightsource ( ref material ) => { &material.emission() }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/material.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / match self { [INFO] [stderr] 63 | | &Material::LambertianMaterialSimple ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 64 | | &Material::LambertianMaterial ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 65 | | &Material::PhongMaterial ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 66 | | &Material::GlassMaterial ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 67 | | &Material::Lightsource ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | match *self { [INFO] [stderr] 63 | Material::LambertianMaterialSimple ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 64 | Material::LambertianMaterial ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 65 | Material::PhongMaterial ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 66 | Material::GlassMaterial ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 67 | Material::Lightsource ( ref material ) => { &material.reflectance() }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/material.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match self { [INFO] [stderr] 73 | | &Material::LambertianMaterialSimple ( ref material ) => { material.eval(input, normal, output) }, [INFO] [stderr] 74 | | &Material::LambertianMaterial ( ref material ) => { material.eval(input, normal, output) }, [INFO] [stderr] 75 | | &Material::PhongMaterial ( ref material ) => { material.eval(input, normal, output) }, [INFO] [stderr] 76 | | &Material::GlassMaterial ( ref material ) => { material.eval(input, normal, output)}, [INFO] [stderr] 77 | | &Material::Lightsource ( ref material ) => { material.eval(input, normal, output) }, [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 72 | match *self { [INFO] [stderr] 73 | Material::LambertianMaterialSimple ( ref material ) => { material.eval(input, normal, output) }, [INFO] [stderr] 74 | Material::LambertianMaterial ( ref material ) => { material.eval(input, normal, output) }, [INFO] [stderr] 75 | Material::PhongMaterial ( ref material ) => { material.eval(input, normal, output) }, [INFO] [stderr] 76 | Material::GlassMaterial ( ref material ) => { material.eval(input, normal, output)}, [INFO] [stderr] 77 | Material::Lightsource ( ref material ) => { material.eval(input, normal, output) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/material.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / match self { [INFO] [stderr] 84 | | &Material::LambertianMaterialSimple ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 85 | | &Material::LambertianMaterial ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 86 | | &Material::PhongMaterial ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 87 | | &Material::GlassMaterial ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 88 | | &Material::Lightsource ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 83 | match *self { [INFO] [stderr] 84 | Material::LambertianMaterialSimple ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 85 | Material::LambertianMaterial ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 86 | Material::PhongMaterial ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 87 | Material::GlassMaterial ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 88 | Material::Lightsource ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `::uniform_hemisphere_surface` doesn't need a mutable reference [INFO] [stderr] --> src/material.rs:126:81 [INFO] [stderr] | [INFO] [stderr] 126 | let dir: Vec = Sampling::uniform_hemisphere_surface(random, now_normal, &mut tangent, &mut binormal); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::uniform_hemisphere_surface` doesn't need a mutable reference [INFO] [stderr] --> src/material.rs:126:95 [INFO] [stderr] | [INFO] [stderr] 126 | let dir: Vec = Sampling::uniform_hemisphere_surface(random, now_normal, &mut tangent, &mut binormal); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::cosine_weighted_hemisphere_surface` doesn't need a mutable reference [INFO] [stderr] --> src/material.rs:168:89 [INFO] [stderr] | [INFO] [stderr] 168 | let dir: Vec = Sampling::cosine_weighted_hemisphere_surface(random, now_normal, &mut tangent, &mut binormal); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::cosine_weighted_hemisphere_surface` doesn't need a mutable reference [INFO] [stderr] --> src/material.rs:168:103 [INFO] [stderr] | [INFO] [stderr] 168 | let dir: Vec = Sampling::cosine_weighted_hemisphere_surface(random, now_normal, &mut tangent, &mut binormal); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/material.rs:226:24 [INFO] [stderr] | [INFO] [stderr] 226 | let phi: f64 = &u1 * 2.0 * &K_PI; [INFO] [stderr] | ^^^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `K_PI` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/material.rs:235:16 [INFO] [stderr] | [INFO] [stderr] 235 | *pdf = (&self.n + 1.0) / (2.0 * K_PI) * &cosa.powf(self.n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `cosa.powf(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of right operand [INFO] [stderr] --> src/material.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | &self.reflectance * &DELTA / Vec::dot(normal, output) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `DELTA` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:291:34 [INFO] [stderr] | [INFO] [stderr] 291 | let cos2t_2: f64 = 1.0 - &n * &n * (1.0 - &dir_dot_normal * &dir_dot_normal); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 291 | let cos2t_2: f64 = 1.0 - n * n * (1.0 - &dir_dot_normal * &dir_dot_normal); [INFO] [stderr] | ^ ^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:291:51 [INFO] [stderr] | [INFO] [stderr] 291 | let cos2t_2: f64 = 1.0 - &n * &n * (1.0 - &dir_dot_normal * &dir_dot_normal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 291 | let cos2t_2: f64 = 1.0 - &n * &n * (1.0 - dir_dot_normal * dir_dot_normal); [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/material.rs:305:35 [INFO] [stderr] | [INFO] [stderr] 305 | let refraction_dir: Vec = input * &n - &now_normal * (&dir_dot_normal * &n + cos2t_2.sqrt()); [INFO] [stderr] | ^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:305:63 [INFO] [stderr] | [INFO] [stderr] 305 | let refraction_dir: Vec = input * &n - &now_normal * (&dir_dot_normal * &n + cos2t_2.sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 305 | let refraction_dir: Vec = input * &n - &now_normal * (dir_dot_normal * n + cos2t_2.sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/material.rs:310:31 [INFO] [stderr] | [INFO] [stderr] 310 | let r_parallel: f64 = (&n * &cost_1 - &cost_2) / (&n * &cost_1 + &cost_2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^-------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `cost_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:310:32 [INFO] [stderr] | [INFO] [stderr] 310 | let r_parallel: f64 = (&n * &cost_1 - &cost_2) / (&n * &cost_1 + &cost_2); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 310 | let r_parallel: f64 = (n * cost_1 - &cost_2) / (&n * &cost_1 + &cost_2); [INFO] [stderr] | ^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/material.rs:310:58 [INFO] [stderr] | [INFO] [stderr] 310 | let r_parallel: f64 = (&n * &cost_1 - &cost_2) / (&n * &cost_1 + &cost_2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^-------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `cost_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:310:59 [INFO] [stderr] | [INFO] [stderr] 310 | let r_parallel: f64 = (&n * &cost_1 - &cost_2) / (&n * &cost_1 + &cost_2); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 310 | let r_parallel: f64 = (&n * &cost_1 - &cost_2) / (n * cost_1 + &cost_2); [INFO] [stderr] | ^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/material.rs:311:36 [INFO] [stderr] | [INFO] [stderr] 311 | let r_perpendicular: f64 = (&cost_1 - &n * &cost_2) / (&cost_1 + &n * &cost_2); [INFO] [stderr] | ^-------^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `cost_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:311:47 [INFO] [stderr] | [INFO] [stderr] 311 | let r_perpendicular: f64 = (&cost_1 - &n * &cost_2) / (&cost_1 + &n * &cost_2); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 311 | let r_perpendicular: f64 = (&cost_1 - n * cost_2) / (&cost_1 + &n * &cost_2); [INFO] [stderr] | ^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/material.rs:311:63 [INFO] [stderr] | [INFO] [stderr] 311 | let r_perpendicular: f64 = (&cost_1 - &n * &cost_2) / (&cost_1 + &n * &cost_2); [INFO] [stderr] | ^-------^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `cost_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:311:74 [INFO] [stderr] | [INFO] [stderr] 311 | let r_perpendicular: f64 = (&cost_1 - &n * &cost_2) / (&cost_1 + &n * &cost_2); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 311 | let r_perpendicular: f64 = (&cost_1 - &n * &cost_2) / (&cost_1 + n * cost_2); [INFO] [stderr] | ^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/material.rs:312:23 [INFO] [stderr] | [INFO] [stderr] 312 | let fr: f64 = &0.5 * (&r_parallel * &r_parallel + &r_perpendicular * &r_perpendicular); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `0.5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:312:31 [INFO] [stderr] | [INFO] [stderr] 312 | let fr: f64 = &0.5 * (&r_parallel * &r_parallel + &r_perpendicular * &r_perpendicular); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 312 | let fr: f64 = &0.5 * (r_parallel * r_parallel + &r_perpendicular * &r_perpendicular); [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:312:59 [INFO] [stderr] | [INFO] [stderr] 312 | let fr: f64 = &0.5 * (&r_parallel * &r_parallel + &r_perpendicular * &r_perpendicular); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 312 | let fr: f64 = &0.5 * (&r_parallel * &r_parallel + r_perpendicular * r_perpendicular); [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/material.rs:319:23 [INFO] [stderr] | [INFO] [stderr] 319 | let ft: f64 = (&1.0 - &fr) * &factor; // 屈折方向の割合。 [INFO] [stderr] | ^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `factor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:319:23 [INFO] [stderr] | [INFO] [stderr] 319 | let ft: f64 = (&1.0 - &fr) * &factor; // 屈折方向の割合。 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 319 | let ft: f64 = (1.0 - fr) * &factor; // 屈折方向の割合。 [INFO] [stderr] | ^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/material.rs:327:20 [INFO] [stderr] | [INFO] [stderr] 327 | *pdf = DELTA * &probability; [INFO] [stderr] | ^^^^^^^^------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `probability` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/material.rs:328:27 [INFO] [stderr] | [INFO] [stderr] 328 | *brdf_value = &fr * self.eval(input, normal, &reflection_dir); [INFO] [stderr] | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `fr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:332:28 [INFO] [stderr] | [INFO] [stderr] 332 | *pdf = DELTA * (&1.0 - &probability); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 332 | *pdf = DELTA * (1.0 - probability); [INFO] [stderr] | ^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/material.rs:333:27 [INFO] [stderr] | [INFO] [stderr] 333 | *brdf_value = &ft * self.eval(input, normal, &reflection_dir); [INFO] [stderr] | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `ft` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/ppm.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | file_handler.write(format!("P3\n{} {}\n{}\n", width, height, 255).as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/ppm.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | file_handler.write(format!("{} {} {} ", to_ldr(color.x), to_ldr(color.y), to_ldr(color.z)).as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/radiance.rs:13:71 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn radiance(scene: &Scene, ray: &Ray, random: &mut Random, depth: &i32) -> Color { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/radiance.rs:17:8 [INFO] [stderr] | [INFO] [stderr] 17 | if depth >= &DEPTH_LIMIT { [INFO] [stderr] | ^^^^^^^^^------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `DEPTH_LIMIT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:38:31 [INFO] [stderr] | [INFO] [stderr] 38 | let sensor_width = 30.0 * width as f64 / height as f64; // アスペクト比調整。 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:38:46 [INFO] [stderr] | [INFO] [stderr] 38 | let sensor_width = 30.0 * width as f64 / height as f64; // アスペクト比調整。 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/render.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | let sensor_x_vec = Vec::normalize(Vec::cross(&camera_dir, &camera_up)) * &sensor_width; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `sensor_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/render.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | let sensor_y_vec = Vec::normalize(Vec::cross(&sensor_x_vec, &camera_dir)) * &sensor_height; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `sensor_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of right operand [INFO] [stderr] --> src/render.rs:45:44 [INFO] [stderr] | [INFO] [stderr] 45 | let sensor_center = &camera_position + &camera_dir * &sensor_dist; [INFO] [stderr] | ^^^^^^^^^^^^^^------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `sensor_dist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:65:95 [INFO] [stderr] | [INFO] [stderr] 65 | eprint!("\rRendering (y= {}, {} %)\x1b[0K", count / width as i32, 100.0 * count as f64 / (width * height) as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:65:110 [INFO] [stderr] | [INFO] [stderr] 65 | eprint!("\rRendering (y= {}, {} %)\x1b[0K", count / width as i32, 100.0 * count as f64 / (width * height) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(width * height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:79:42 [INFO] [stderr] | [INFO] [stderr] 79 | let rate = 1.0 / num_subpixel as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_subpixel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:80:34 [INFO] [stderr] | [INFO] [stderr] 80 | let r1 = sx as f64 * rate + rate / 2.0; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(sx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:81:34 [INFO] [stderr] | [INFO] [stderr] 81 | let r2 = sy as f64 * rate + rate / 2.0; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(sy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:85:52 [INFO] [stderr] | [INFO] [stderr] 85 | &sensor_x_vec * ((r1 + x as f64) / width as f64 - 0.5) + [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:85:64 [INFO] [stderr] | [INFO] [stderr] 85 | &sensor_x_vec * ((r1 + x as f64) / width as f64 - 0.5) + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:86:52 [INFO] [stderr] | [INFO] [stderr] 86 | &sensor_y_vec * ((r2 + image_index as f64) / height as f64 - 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(image_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:86:74 [INFO] [stderr] | [INFO] [stderr] 86 | &sensor_y_vec * ((r2 + image_index as f64) / height as f64 - 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:92:31 [INFO] [stderr] | [INFO] [stderr] 92 | / num_sample_per_subpixel as f64 / (num_subpixel * num_subpixel) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_sample_per_subpixel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:92:64 [INFO] [stderr] | [INFO] [stderr] 92 | / num_sample_per_subpixel as f64 / (num_subpixel * num_subpixel) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_subpixel * num_subpixel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:103:68 [INFO] [stderr] | [INFO] [stderr] 103 | eprint!("\rRendering (y= {}, {} %)\x1b[0K", y, 100.0 * y as f64 / (height - 1) as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:103:79 [INFO] [stderr] | [INFO] [stderr] 103 | eprint!("\rRendering (y= {}, {} %)\x1b[0K", y, 100.0 * y as f64 / (height - 1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(height - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:114:46 [INFO] [stderr] | [INFO] [stderr] 114 | let rate = 1.0 / num_subpixel as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_subpixel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:115:38 [INFO] [stderr] | [INFO] [stderr] 115 | let r1 = sx as f64 * rate + rate / 2.0; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(sx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:116:38 [INFO] [stderr] | [INFO] [stderr] 116 | let r2 = sy as f64 * rate + rate / 2.0; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(sy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:120:56 [INFO] [stderr] | [INFO] [stderr] 120 | &sensor_x_vec * ((r1 + x as f64) / width as f64 - 0.5) + [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:120:68 [INFO] [stderr] | [INFO] [stderr] 120 | &sensor_x_vec * ((r1 + x as f64) / width as f64 - 0.5) + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:121:56 [INFO] [stderr] | [INFO] [stderr] 121 | &sensor_y_vec * ((r2 + y as f64) / height as f64 - 0.5); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:121:68 [INFO] [stderr] | [INFO] [stderr] 121 | &sensor_y_vec * ((r2 + y as f64) / height as f64 - 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:127:35 [INFO] [stderr] | [INFO] [stderr] 127 | / num_sample_per_subpixel as f64 / (num_subpixel * num_subpixel) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_sample_per_subpixel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:127:68 [INFO] [stderr] | [INFO] [stderr] 127 | / num_sample_per_subpixel as f64 / (num_subpixel * num_subpixel) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_subpixel * num_subpixel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gemspt-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/sphere.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | let c: f64 = &b * &b - Vec::dot(&o_to_p, &o_to_p) + &self.radius_ * &self.radius_; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 27 | let c: f64 = b * b - Vec::dot(&o_to_p, &o_to_p) + &self.radius_ * &self.radius_; [INFO] [stderr] | ^ ^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/sphere.rs:27:61 [INFO] [stderr] | [INFO] [stderr] 27 | let c: f64 = &b * &b - Vec::dot(&o_to_p, &o_to_p) + &self.radius_ * &self.radius_; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 27 | let c: f64 = &b * &b - Vec::dot(&o_to_p, &o_to_p) + self.radius_ * self.radius_; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/sphere.rs:34:23 [INFO] [stderr] | [INFO] [stderr] 34 | let t1: f64 = &b - &sqrt_c; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 34 | let t1: f64 = b - sqrt_c; [INFO] [stderr] | ^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/sphere.rs:35:23 [INFO] [stderr] | [INFO] [stderr] 35 | let t2: f64 = &b + &sqrt_c; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 35 | let t2: f64 = b + sqrt_c; [INFO] [stderr] | ^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/sphere.rs:52:39 [INFO] [stderr] | [INFO] [stderr] 52 | hitpoint.position = ray.org + &hitpoint.distance * ray.dir; [INFO] [stderr] | ------------------^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `hitpoint.distance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/material.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / match self { [INFO] [stderr] 53 | | &Material::LambertianMaterialSimple ( ref material ) => { &material.emission() }, [INFO] [stderr] 54 | | &Material::LambertianMaterial ( ref material ) => { &material.emission() }, [INFO] [stderr] 55 | | &Material::PhongMaterial ( ref material ) => { &material.emission() }, [INFO] [stderr] 56 | | &Material::GlassMaterial ( ref material ) => { &material.emission() }, [INFO] [stderr] 57 | | &Material::Lightsource ( ref material ) => { &material.emission() }, [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | match *self { [INFO] [stderr] 53 | Material::LambertianMaterialSimple ( ref material ) => { &material.emission() }, [INFO] [stderr] 54 | Material::LambertianMaterial ( ref material ) => { &material.emission() }, [INFO] [stderr] 55 | Material::PhongMaterial ( ref material ) => { &material.emission() }, [INFO] [stderr] 56 | Material::GlassMaterial ( ref material ) => { &material.emission() }, [INFO] [stderr] 57 | Material::Lightsource ( ref material ) => { &material.emission() }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/material.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / match self { [INFO] [stderr] 63 | | &Material::LambertianMaterialSimple ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 64 | | &Material::LambertianMaterial ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 65 | | &Material::PhongMaterial ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 66 | | &Material::GlassMaterial ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 67 | | &Material::Lightsource ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | match *self { [INFO] [stderr] 63 | Material::LambertianMaterialSimple ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 64 | Material::LambertianMaterial ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 65 | Material::PhongMaterial ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 66 | Material::GlassMaterial ( ref material ) => { &material.reflectance() }, [INFO] [stderr] 67 | Material::Lightsource ( ref material ) => { &material.reflectance() }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/material.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match self { [INFO] [stderr] 73 | | &Material::LambertianMaterialSimple ( ref material ) => { material.eval(input, normal, output) }, [INFO] [stderr] 74 | | &Material::LambertianMaterial ( ref material ) => { material.eval(input, normal, output) }, [INFO] [stderr] 75 | | &Material::PhongMaterial ( ref material ) => { material.eval(input, normal, output) }, [INFO] [stderr] 76 | | &Material::GlassMaterial ( ref material ) => { material.eval(input, normal, output)}, [INFO] [stderr] 77 | | &Material::Lightsource ( ref material ) => { material.eval(input, normal, output) }, [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 72 | match *self { [INFO] [stderr] 73 | Material::LambertianMaterialSimple ( ref material ) => { material.eval(input, normal, output) }, [INFO] [stderr] 74 | Material::LambertianMaterial ( ref material ) => { material.eval(input, normal, output) }, [INFO] [stderr] 75 | Material::PhongMaterial ( ref material ) => { material.eval(input, normal, output) }, [INFO] [stderr] 76 | Material::GlassMaterial ( ref material ) => { material.eval(input, normal, output)}, [INFO] [stderr] 77 | Material::Lightsource ( ref material ) => { material.eval(input, normal, output) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/material.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / match self { [INFO] [stderr] 84 | | &Material::LambertianMaterialSimple ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 85 | | &Material::LambertianMaterial ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 86 | | &Material::PhongMaterial ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 87 | | &Material::GlassMaterial ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 88 | | &Material::Lightsource ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 83 | match *self { [INFO] [stderr] 84 | Material::LambertianMaterialSimple ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 85 | Material::LambertianMaterial ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 86 | Material::PhongMaterial ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 87 | Material::GlassMaterial ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] 88 | Material::Lightsource ( ref material ) => { material.sample(random, input, normal, pdf, brdf_value) }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `::uniform_hemisphere_surface` doesn't need a mutable reference [INFO] [stderr] --> src/material.rs:126:81 [INFO] [stderr] | [INFO] [stderr] 126 | let dir: Vec = Sampling::uniform_hemisphere_surface(random, now_normal, &mut tangent, &mut binormal); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::uniform_hemisphere_surface` doesn't need a mutable reference [INFO] [stderr] --> src/material.rs:126:95 [INFO] [stderr] | [INFO] [stderr] 126 | let dir: Vec = Sampling::uniform_hemisphere_surface(random, now_normal, &mut tangent, &mut binormal); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::cosine_weighted_hemisphere_surface` doesn't need a mutable reference [INFO] [stderr] --> src/material.rs:168:89 [INFO] [stderr] | [INFO] [stderr] 168 | let dir: Vec = Sampling::cosine_weighted_hemisphere_surface(random, now_normal, &mut tangent, &mut binormal); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::cosine_weighted_hemisphere_surface` doesn't need a mutable reference [INFO] [stderr] --> src/material.rs:168:103 [INFO] [stderr] | [INFO] [stderr] 168 | let dir: Vec = Sampling::cosine_weighted_hemisphere_surface(random, now_normal, &mut tangent, &mut binormal); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/material.rs:226:24 [INFO] [stderr] | [INFO] [stderr] 226 | let phi: f64 = &u1 * 2.0 * &K_PI; [INFO] [stderr] | ^^^^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `K_PI` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/material.rs:235:16 [INFO] [stderr] | [INFO] [stderr] 235 | *pdf = (&self.n + 1.0) / (2.0 * K_PI) * &cosa.powf(self.n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `cosa.powf(self.n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of right operand [INFO] [stderr] --> src/material.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | &self.reflectance * &DELTA / Vec::dot(normal, output) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `DELTA` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:291:34 [INFO] [stderr] | [INFO] [stderr] 291 | let cos2t_2: f64 = 1.0 - &n * &n * (1.0 - &dir_dot_normal * &dir_dot_normal); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 291 | let cos2t_2: f64 = 1.0 - n * n * (1.0 - &dir_dot_normal * &dir_dot_normal); [INFO] [stderr] | ^ ^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:291:51 [INFO] [stderr] | [INFO] [stderr] 291 | let cos2t_2: f64 = 1.0 - &n * &n * (1.0 - &dir_dot_normal * &dir_dot_normal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 291 | let cos2t_2: f64 = 1.0 - &n * &n * (1.0 - dir_dot_normal * dir_dot_normal); [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/material.rs:305:35 [INFO] [stderr] | [INFO] [stderr] 305 | let refraction_dir: Vec = input * &n - &now_normal * (&dir_dot_normal * &n + cos2t_2.sqrt()); [INFO] [stderr] | ^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:305:63 [INFO] [stderr] | [INFO] [stderr] 305 | let refraction_dir: Vec = input * &n - &now_normal * (&dir_dot_normal * &n + cos2t_2.sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 305 | let refraction_dir: Vec = input * &n - &now_normal * (dir_dot_normal * n + cos2t_2.sqrt()); [INFO] [stderr] | ^^^^^^^^^^^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/material.rs:310:31 [INFO] [stderr] | [INFO] [stderr] 310 | let r_parallel: f64 = (&n * &cost_1 - &cost_2) / (&n * &cost_1 + &cost_2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^-------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `cost_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:310:32 [INFO] [stderr] | [INFO] [stderr] 310 | let r_parallel: f64 = (&n * &cost_1 - &cost_2) / (&n * &cost_1 + &cost_2); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 310 | let r_parallel: f64 = (n * cost_1 - &cost_2) / (&n * &cost_1 + &cost_2); [INFO] [stderr] | ^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/material.rs:310:58 [INFO] [stderr] | [INFO] [stderr] 310 | let r_parallel: f64 = (&n * &cost_1 - &cost_2) / (&n * &cost_1 + &cost_2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^-------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `cost_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:310:59 [INFO] [stderr] | [INFO] [stderr] 310 | let r_parallel: f64 = (&n * &cost_1 - &cost_2) / (&n * &cost_1 + &cost_2); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 310 | let r_parallel: f64 = (&n * &cost_1 - &cost_2) / (n * cost_1 + &cost_2); [INFO] [stderr] | ^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/material.rs:311:36 [INFO] [stderr] | [INFO] [stderr] 311 | let r_perpendicular: f64 = (&cost_1 - &n * &cost_2) / (&cost_1 + &n * &cost_2); [INFO] [stderr] | ^-------^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `cost_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:311:47 [INFO] [stderr] | [INFO] [stderr] 311 | let r_perpendicular: f64 = (&cost_1 - &n * &cost_2) / (&cost_1 + &n * &cost_2); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 311 | let r_perpendicular: f64 = (&cost_1 - n * cost_2) / (&cost_1 + &n * &cost_2); [INFO] [stderr] | ^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/material.rs:311:63 [INFO] [stderr] | [INFO] [stderr] 311 | let r_perpendicular: f64 = (&cost_1 - &n * &cost_2) / (&cost_1 + &n * &cost_2); [INFO] [stderr] | ^-------^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `cost_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:311:74 [INFO] [stderr] | [INFO] [stderr] 311 | let r_perpendicular: f64 = (&cost_1 - &n * &cost_2) / (&cost_1 + &n * &cost_2); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 311 | let r_perpendicular: f64 = (&cost_1 - &n * &cost_2) / (&cost_1 + n * cost_2); [INFO] [stderr] | ^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/material.rs:312:23 [INFO] [stderr] | [INFO] [stderr] 312 | let fr: f64 = &0.5 * (&r_parallel * &r_parallel + &r_perpendicular * &r_perpendicular); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `0.5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:312:31 [INFO] [stderr] | [INFO] [stderr] 312 | let fr: f64 = &0.5 * (&r_parallel * &r_parallel + &r_perpendicular * &r_perpendicular); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 312 | let fr: f64 = &0.5 * (r_parallel * r_parallel + &r_perpendicular * &r_perpendicular); [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:312:59 [INFO] [stderr] | [INFO] [stderr] 312 | let fr: f64 = &0.5 * (&r_parallel * &r_parallel + &r_perpendicular * &r_perpendicular); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 312 | let fr: f64 = &0.5 * (&r_parallel * &r_parallel + r_perpendicular * r_perpendicular); [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/material.rs:319:23 [INFO] [stderr] | [INFO] [stderr] 319 | let ft: f64 = (&1.0 - &fr) * &factor; // 屈折方向の割合。 [INFO] [stderr] | ^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `factor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:319:23 [INFO] [stderr] | [INFO] [stderr] 319 | let ft: f64 = (&1.0 - &fr) * &factor; // 屈折方向の割合。 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 319 | let ft: f64 = (1.0 - fr) * &factor; // 屈折方向の割合。 [INFO] [stderr] | ^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/material.rs:327:20 [INFO] [stderr] | [INFO] [stderr] 327 | *pdf = DELTA * &probability; [INFO] [stderr] | ^^^^^^^^------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `probability` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/material.rs:328:27 [INFO] [stderr] | [INFO] [stderr] 328 | *brdf_value = &fr * self.eval(input, normal, &reflection_dir); [INFO] [stderr] | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `fr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/material.rs:332:28 [INFO] [stderr] | [INFO] [stderr] 332 | *pdf = DELTA * (&1.0 - &probability); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 332 | *pdf = DELTA * (1.0 - probability); [INFO] [stderr] | ^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/material.rs:333:27 [INFO] [stderr] | [INFO] [stderr] 333 | *brdf_value = &ft * self.eval(input, normal, &reflection_dir); [INFO] [stderr] | ---^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `ft` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/ppm.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | file_handler.write(format!("P3\n{} {}\n{}\n", width, height, 255).as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/ppm.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | file_handler.write(format!("{} {} {} ", to_ldr(color.x), to_ldr(color.y), to_ldr(color.z)).as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/radiance.rs:13:71 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn radiance(scene: &Scene, ray: &Ray, random: &mut Random, depth: &i32) -> Color { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/radiance.rs:17:8 [INFO] [stderr] | [INFO] [stderr] 17 | if depth >= &DEPTH_LIMIT { [INFO] [stderr] | ^^^^^^^^^------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `DEPTH_LIMIT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:38:31 [INFO] [stderr] | [INFO] [stderr] 38 | let sensor_width = 30.0 * width as f64 / height as f64; // アスペクト比調整。 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:38:46 [INFO] [stderr] | [INFO] [stderr] 38 | let sensor_width = 30.0 * width as f64 / height as f64; // アスペクト比調整。 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/render.rs:43:24 [INFO] [stderr] | [INFO] [stderr] 43 | let sensor_x_vec = Vec::normalize(Vec::cross(&camera_dir, &camera_up)) * &sensor_width; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `sensor_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/render.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | let sensor_y_vec = Vec::normalize(Vec::cross(&sensor_x_vec, &camera_dir)) * &sensor_height; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `sensor_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of right operand [INFO] [stderr] --> src/render.rs:45:44 [INFO] [stderr] | [INFO] [stderr] 45 | let sensor_center = &camera_position + &camera_dir * &sensor_dist; [INFO] [stderr] | ^^^^^^^^^^^^^^------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `sensor_dist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:65:95 [INFO] [stderr] | [INFO] [stderr] 65 | eprint!("\rRendering (y= {}, {} %)\x1b[0K", count / width as i32, 100.0 * count as f64 / (width * height) as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:65:110 [INFO] [stderr] | [INFO] [stderr] 65 | eprint!("\rRendering (y= {}, {} %)\x1b[0K", count / width as i32, 100.0 * count as f64 / (width * height) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(width * height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:79:42 [INFO] [stderr] | [INFO] [stderr] 79 | let rate = 1.0 / num_subpixel as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_subpixel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:80:34 [INFO] [stderr] | [INFO] [stderr] 80 | let r1 = sx as f64 * rate + rate / 2.0; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(sx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:81:34 [INFO] [stderr] | [INFO] [stderr] 81 | let r2 = sy as f64 * rate + rate / 2.0; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(sy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:85:52 [INFO] [stderr] | [INFO] [stderr] 85 | &sensor_x_vec * ((r1 + x as f64) / width as f64 - 0.5) + [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:85:64 [INFO] [stderr] | [INFO] [stderr] 85 | &sensor_x_vec * ((r1 + x as f64) / width as f64 - 0.5) + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:86:52 [INFO] [stderr] | [INFO] [stderr] 86 | &sensor_y_vec * ((r2 + image_index as f64) / height as f64 - 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(image_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:86:74 [INFO] [stderr] | [INFO] [stderr] 86 | &sensor_y_vec * ((r2 + image_index as f64) / height as f64 - 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:92:31 [INFO] [stderr] | [INFO] [stderr] 92 | / num_sample_per_subpixel as f64 / (num_subpixel * num_subpixel) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_sample_per_subpixel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:92:64 [INFO] [stderr] | [INFO] [stderr] 92 | / num_sample_per_subpixel as f64 / (num_subpixel * num_subpixel) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_subpixel * num_subpixel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:103:68 [INFO] [stderr] | [INFO] [stderr] 103 | eprint!("\rRendering (y= {}, {} %)\x1b[0K", y, 100.0 * y as f64 / (height - 1) as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:103:79 [INFO] [stderr] | [INFO] [stderr] 103 | eprint!("\rRendering (y= {}, {} %)\x1b[0K", y, 100.0 * y as f64 / (height - 1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(height - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:114:46 [INFO] [stderr] | [INFO] [stderr] 114 | let rate = 1.0 / num_subpixel as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_subpixel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:115:38 [INFO] [stderr] | [INFO] [stderr] 115 | let r1 = sx as f64 * rate + rate / 2.0; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(sx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:116:38 [INFO] [stderr] | [INFO] [stderr] 116 | let r2 = sy as f64 * rate + rate / 2.0; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(sy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:120:56 [INFO] [stderr] | [INFO] [stderr] 120 | &sensor_x_vec * ((r1 + x as f64) / width as f64 - 0.5) + [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:120:68 [INFO] [stderr] | [INFO] [stderr] 120 | &sensor_x_vec * ((r1 + x as f64) / width as f64 - 0.5) + [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:121:56 [INFO] [stderr] | [INFO] [stderr] 121 | &sensor_y_vec * ((r2 + y as f64) / height as f64 - 0.5); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:121:68 [INFO] [stderr] | [INFO] [stderr] 121 | &sensor_y_vec * ((r2 + y as f64) / height as f64 - 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:127:35 [INFO] [stderr] | [INFO] [stderr] 127 | / num_sample_per_subpixel as f64 / (num_subpixel * num_subpixel) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_sample_per_subpixel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/render.rs:127:68 [INFO] [stderr] | [INFO] [stderr] 127 | / num_sample_per_subpixel as f64 / (num_subpixel * num_subpixel) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(num_subpixel * num_subpixel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gemspt-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c62cf6c94bbb8efd429a10631facf09b053e785d05a5d0321be38d924c691f65"` [INFO] running `"docker" "rm" "-f" "c62cf6c94bbb8efd429a10631facf09b053e785d05a5d0321be38d924c691f65"` [INFO] [stdout] c62cf6c94bbb8efd429a10631facf09b053e785d05a5d0321be38d924c691f65