[INFO] updating cached repository AntonHermann/space_invaders [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AntonHermann/space_invaders [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AntonHermann/space_invaders" "work/ex/clippy-test-run/sources/stable/gh/AntonHermann/space_invaders"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AntonHermann/space_invaders'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AntonHermann/space_invaders" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AntonHermann/space_invaders"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AntonHermann/space_invaders'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cc84f2f1b9e71481b7fb72a427d5dd5e6b5c736b [INFO] sha for GitHub repo AntonHermann/space_invaders: cc84f2f1b9e71481b7fb72a427d5dd5e6b5c736b [INFO] validating manifest of AntonHermann/space_invaders on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AntonHermann/space_invaders on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AntonHermann/space_invaders [INFO] finished frobbing AntonHermann/space_invaders [INFO] frobbed toml for AntonHermann/space_invaders written to work/ex/clippy-test-run/sources/stable/gh/AntonHermann/space_invaders/Cargo.toml [INFO] started frobbing AntonHermann/space_invaders [INFO] finished frobbing AntonHermann/space_invaders [INFO] frobbed toml for AntonHermann/space_invaders written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AntonHermann/space_invaders/Cargo.toml [INFO] crate AntonHermann/space_invaders has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AntonHermann/space_invaders against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AntonHermann/space_invaders:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f9c11176de519ddf6d790d4c6953b5904f2b6f779c339f527342e3c02115d509 [INFO] running `"docker" "start" "-a" "f9c11176de519ddf6d790d4c6953b5904f2b6f779c339f527342e3c02115d509"` [INFO] [stderr] Compiling backtrace-sys v0.1.21 [INFO] [stderr] Checking loggerv v0.7.1 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking shrev v1.0.1 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking backtrace v0.3.8 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking shred v0.7.0 [INFO] [stderr] Checking hibitset v0.5.0 [INFO] [stderr] Checking specs v0.11.2 [INFO] [stderr] Checking space_invaders v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/game/systems/movement.rs:96:16 [INFO] [stderr] | [INFO] [stderr] 96 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 97 | | if left_bound as isize - 1 <= 0 { [INFO] [stderr] 98 | | // reached left border, change direction and move 1 down [INFO] [stderr] 99 | | self.moving_right = true; [INFO] [stderr] ... | [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 96 | } else if left_bound as isize - 1 <= 0 { [INFO] [stderr] 97 | // reached left border, change direction and move 1 down [INFO] [stderr] 98 | self.moving_right = true; [INFO] [stderr] 99 | for (pos, _) in (&mut pos, &e_flag).join() { [INFO] [stderr] 100 | pos.y -= 1; [INFO] [stderr] 101 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/game/mod.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | const PLAYER_STR: &'static str = "/O\\"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/game/mod.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | const ENEMY_STR: &'static str = "U"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/game/mod.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | const SHOT_STR: &'static str = "|"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/game/systems/movement.rs:96:16 [INFO] [stderr] | [INFO] [stderr] 96 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 97 | | if left_bound as isize - 1 <= 0 { [INFO] [stderr] 98 | | // reached left border, change direction and move 1 down [INFO] [stderr] 99 | | self.moving_right = true; [INFO] [stderr] ... | [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 96 | } else if left_bound as isize - 1 <= 0 { [INFO] [stderr] 97 | // reached left border, change direction and move 1 down [INFO] [stderr] 98 | self.moving_right = true; [INFO] [stderr] 99 | for (pos, _) in (&mut pos, &e_flag).join() { [INFO] [stderr] 100 | pos.y -= 1; [INFO] [stderr] 101 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/game/mod.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | const PLAYER_STR: &'static str = "/O\\"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/game/mod.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | const ENEMY_STR: &'static str = "U"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/game/mod.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | const SHOT_STR: &'static str = "|"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pos` [INFO] [stderr] --> src/game/systems/debug.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | fn run(&mut self, (pos, ap): Self::SystemData) { [INFO] [stderr] | ^^^ help: consider using `_pos` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ap` [INFO] [stderr] --> src/game/systems/debug.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | fn run(&mut self, (pos, ap): Self::SystemData) { [INFO] [stderr] | ^^ help: consider using `_ap` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pos` [INFO] [stderr] --> src/game/systems/debug.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | fn run(&mut self, (pos, ap): Self::SystemData) { [INFO] [stderr] | ^^^ help: consider using `_pos` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ap` [INFO] [stderr] --> src/game/systems/debug.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | fn run(&mut self, (pos, ap): Self::SystemData) { [INFO] [stderr] | ^^ help: consider using `_ap` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Enemy` [INFO] [stderr] --> src/game/components.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | Enemy, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ENEMY_COUNT` [INFO] [stderr] --> src/game/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | const ENEMY_COUNT: usize = ENEMY_COUNT_X * ENEMY_COUNT_Y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Down` [INFO] [stderr] --> src/game/mod.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | Down, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/game/systems/player_interaction.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 20 | | WriteStorage<'a, Velocity>, [INFO] [stderr] 21 | | WriteStorage<'a, Weapon>, [INFO] [stderr] 22 | | ReadStorage<'a, Position>, [INFO] [stderr] 23 | | ReadStorage<'a, PlayerControls>, [INFO] [stderr] 24 | | Write<'a, GameActive>, [INFO] [stderr] 25 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Enemy` [INFO] [stderr] --> src/game/components.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | Enemy, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ENEMY_COUNT` [INFO] [stderr] --> src/game/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | const ENEMY_COUNT: usize = ENEMY_COUNT_X * ENEMY_COUNT_Y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Down` [INFO] [stderr] --> src/game/mod.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | Down, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> src/game/mod.rs:73:29 [INFO] [stderr] | [INFO] [stderr] 73 | dispatcher.dispatch(&mut world.res); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/game/mod.rs:75:12 [INFO] [stderr] | [INFO] [stderr] 75 | if world.read_resource::().0 == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!world.read_resource::().0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/game/systems/player_interaction.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 20 | | WriteStorage<'a, Velocity>, [INFO] [stderr] 21 | | WriteStorage<'a, Weapon>, [INFO] [stderr] 22 | | ReadStorage<'a, Position>, [INFO] [stderr] 23 | | ReadStorage<'a, PlayerControls>, [INFO] [stderr] 24 | | Write<'a, GameActive>, [INFO] [stderr] 25 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> src/game/mod.rs:73:29 [INFO] [stderr] | [INFO] [stderr] 73 | dispatcher.dispatch(&mut world.res); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/game/mod.rs:75:12 [INFO] [stderr] | [INFO] [stderr] 75 | if world.read_resource::().0 == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!world.read_resource::().0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.80s [INFO] running `"docker" "inspect" "f9c11176de519ddf6d790d4c6953b5904f2b6f779c339f527342e3c02115d509"` [INFO] running `"docker" "rm" "-f" "f9c11176de519ddf6d790d4c6953b5904f2b6f779c339f527342e3c02115d509"` [INFO] [stdout] f9c11176de519ddf6d790d4c6953b5904f2b6f779c339f527342e3c02115d509