[INFO] updating cached repository AntonHermann/lin_eq_solver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AntonHermann/lin_eq_solver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AntonHermann/lin_eq_solver" "work/ex/clippy-test-run/sources/stable/gh/AntonHermann/lin_eq_solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AntonHermann/lin_eq_solver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AntonHermann/lin_eq_solver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AntonHermann/lin_eq_solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AntonHermann/lin_eq_solver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0ae7f13ec535fb3e0efbf115440a59034b901bcb [INFO] sha for GitHub repo AntonHermann/lin_eq_solver: 0ae7f13ec535fb3e0efbf115440a59034b901bcb [INFO] validating manifest of AntonHermann/lin_eq_solver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AntonHermann/lin_eq_solver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AntonHermann/lin_eq_solver [INFO] finished frobbing AntonHermann/lin_eq_solver [INFO] frobbed toml for AntonHermann/lin_eq_solver written to work/ex/clippy-test-run/sources/stable/gh/AntonHermann/lin_eq_solver/Cargo.toml [INFO] started frobbing AntonHermann/lin_eq_solver [INFO] finished frobbing AntonHermann/lin_eq_solver [INFO] frobbed toml for AntonHermann/lin_eq_solver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AntonHermann/lin_eq_solver/Cargo.toml [INFO] crate AntonHermann/lin_eq_solver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AntonHermann/lin_eq_solver against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AntonHermann/lin_eq_solver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4edf15236324962d8fb90d6cd1a20580765fcbffe7614b111114e76a623d9d69 [INFO] running `"docker" "start" "-a" "4edf15236324962d8fb90d6cd1a20580765fcbffe7614b111114e76a623d9d69"` [INFO] [stderr] Checking simple_logger v0.5.0 [INFO] [stderr] Checking lin_eq_solver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/aug_matrix/matrix.rs:109:30 [INFO] [stderr] | [INFO] [stderr] 109 | .zip(row.into_iter().map(|val| val.to_string().len())) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/aug_matrix/matrix.rs:118:41 [INFO] [stderr] | [INFO] [stderr] 118 | for (i, (el, width)) in row.into_iter().zip(col_widths).enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | .map_err(|err| Error::ParseError(err)) // Result<_, Parse???Error> -> Result<_, Error> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::ParseError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/aug_matrix/matrix.rs:109:30 [INFO] [stderr] | [INFO] [stderr] 109 | .zip(row.into_iter().map(|val| val.to_string().len())) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/aug_matrix/matrix.rs:118:41 [INFO] [stderr] | [INFO] [stderr] 118 | for (i, (el, width)) in row.into_iter().zip(col_widths).enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | .map_err(|err| Error::ParseError(err)) // Result<_, Parse???Error> -> Result<_, Error> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::ParseError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.86s [INFO] running `"docker" "inspect" "4edf15236324962d8fb90d6cd1a20580765fcbffe7614b111114e76a623d9d69"` [INFO] running `"docker" "rm" "-f" "4edf15236324962d8fb90d6cd1a20580765fcbffe7614b111114e76a623d9d69"` [INFO] [stdout] 4edf15236324962d8fb90d6cd1a20580765fcbffe7614b111114e76a623d9d69