[INFO] updating cached repository Antiarchitect/rusty-vault [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Antiarchitect/rusty-vault [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Antiarchitect/rusty-vault" "work/ex/clippy-test-run/sources/stable/gh/Antiarchitect/rusty-vault"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Antiarchitect/rusty-vault'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Antiarchitect/rusty-vault" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Antiarchitect/rusty-vault"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Antiarchitect/rusty-vault'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0eb27265139421c727cbaa05ef0f6dee271c4a1e [INFO] sha for GitHub repo Antiarchitect/rusty-vault: 0eb27265139421c727cbaa05ef0f6dee271c4a1e [INFO] validating manifest of Antiarchitect/rusty-vault on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Antiarchitect/rusty-vault on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Antiarchitect/rusty-vault [INFO] finished frobbing Antiarchitect/rusty-vault [INFO] frobbed toml for Antiarchitect/rusty-vault written to work/ex/clippy-test-run/sources/stable/gh/Antiarchitect/rusty-vault/Cargo.toml [INFO] started frobbing Antiarchitect/rusty-vault [INFO] finished frobbing Antiarchitect/rusty-vault [INFO] frobbed toml for Antiarchitect/rusty-vault written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Antiarchitect/rusty-vault/Cargo.toml [INFO] crate Antiarchitect/rusty-vault has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Antiarchitect/rusty-vault against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Antiarchitect/rusty-vault:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 465a0e44e1b39a118413a238fa53673dcbd73e613a2cbba6f29bc1f68d2b5b4e [INFO] running `"docker" "start" "-a" "465a0e44e1b39a118413a238fa53673dcbd73e613a2cbba6f29bc1f68d2b5b4e"` [INFO] [stderr] Compiling gcc v0.3.48 [INFO] [stderr] Checking md5 v0.3.4 [INFO] [stderr] Checking textwrap v0.7.0 [INFO] [stderr] Checking uuid v0.5.0 [INFO] [stderr] Checking clap v2.26.0 [INFO] [stderr] Checking postgres-protocol v0.2.2 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking postgres-shared v0.2.1 [INFO] [stderr] Checking postgres v0.14.1 [INFO] [stderr] Checking structopt v0.1.0 [INFO] [stderr] Checking rusty-vault v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/crypt.rs:43:62 [INFO] [stderr] | [INFO] [stderr] 43 | EncryptionResult { key: Box::new(key), iv: Box::new(iv), ciphertext: ciphertext, tag: Box::new(tag) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ciphertext` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/crypt.rs:53:24 [INFO] [stderr] | [INFO] [stderr] 53 | DecryptionResult { plaintext: plaintext } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `plaintext` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:61:38 [INFO] [stderr] | [INFO] [stderr] 61 | let storable = StorableMap { key_id: key_id, data_id: data_id, tag: encrypted.tag }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `key_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:61:54 [INFO] [stderr] | [INFO] [stderr] 61 | let storable = StorableMap { key_id: key_id, data_id: data_id, tag: encrypted.tag }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `data_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/crypt.rs:43:62 [INFO] [stderr] | [INFO] [stderr] 43 | EncryptionResult { key: Box::new(key), iv: Box::new(iv), ciphertext: ciphertext, tag: Box::new(tag) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ciphertext` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/crypt.rs:53:24 [INFO] [stderr] | [INFO] [stderr] 53 | DecryptionResult { plaintext: plaintext } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `plaintext` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:61:38 [INFO] [stderr] | [INFO] [stderr] 61 | let storable = StorableMap { key_id: key_id, data_id: data_id, tag: encrypted.tag }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `key_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:61:54 [INFO] [stderr] | [INFO] [stderr] 61 | let storable = StorableMap { key_id: key_id, data_id: data_id, tag: encrypted.tag }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `data_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/storages/filesystem.rs:18:40 [INFO] [stderr] | [INFO] [stderr] 18 | fn ensure_storage_path(&self, key: &String) -> StorageResult { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/storages/filesystem.rs:18:40 [INFO] [stderr] | [INFO] [stderr] 18 | fn ensure_storage_path(&self, key: &String) -> StorageResult { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/storages/postgresql.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / for row in &connection.query(&format!("SELECT id, data FROM {} WHERE id = $1", &self.table_name), &[&Uuid::parse_str(id)?])? { [INFO] [stderr] 49 | | let json: json::Json = row.get(1); [INFO] [stderr] 50 | | let data: T = json::decode(&json.to_string())?; [INFO] [stderr] 51 | | return Ok(Some(data)) [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/storages/mod.rs:31:38 [INFO] [stderr] | [INFO] [stderr] 31 | fn dump(&self, id: &String, storable: T) -> StorageResult<()>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/storages/mod.rs:32:38 [INFO] [stderr] | [INFO] [stderr] 32 | fn load(&self, id: &String) -> StorageResultOption; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/storages/mod.rs:33:26 [INFO] [stderr] | [INFO] [stderr] 33 | fn delete(&self, id: &String) -> StorageResultOption<()>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:38:37 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn dump(&self, external_id: &String, data: Vec) -> VaultResult<()> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 38 | pub fn dump(&self, external_id: &str, data: Vec) -> VaultResult<()> { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `external_id.clone()` to [INFO] [stderr] | [INFO] [stderr] 63 | let map_id = external_id.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/storages/postgresql.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / for row in &connection.query(&format!("SELECT id, data FROM {} WHERE id = $1", &self.table_name), &[&Uuid::parse_str(id)?])? { [INFO] [stderr] 49 | | let json: json::Json = row.get(1); [INFO] [stderr] 50 | | let data: T = json::decode(&json.to_string())?; [INFO] [stderr] 51 | | return Ok(Some(data)) [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:80:37 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn load(&self, external_id: &String) -> VaultResultOption> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/storages/mod.rs:31:38 [INFO] [stderr] | [INFO] [stderr] 31 | fn dump(&self, id: &String, storable: T) -> StorageResult<()>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/storages/mod.rs:32:38 [INFO] [stderr] | [INFO] [stderr] 32 | fn load(&self, id: &String) -> StorageResultOption; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/storages/mod.rs:33:26 [INFO] [stderr] | [INFO] [stderr] 33 | fn delete(&self, id: &String) -> StorageResultOption<()>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:38:37 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn dump(&self, external_id: &String, data: Vec) -> VaultResult<()> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 38 | pub fn dump(&self, external_id: &str, data: Vec) -> VaultResult<()> { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `external_id.clone()` to [INFO] [stderr] | [INFO] [stderr] 63 | let map_id = external_id.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:114:39 [INFO] [stderr] | [INFO] [stderr] 114 | pub fn delete(&self, external_id: &String) -> VaultResultOption<()> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 114 | pub fn delete(&self, external_id: &str) -> VaultResultOption<()> { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `external_id.clone()` to [INFO] [stderr] | [INFO] [stderr] 123 | let id = external_id.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / match results.into_iter().all(|i| i.is_ok()) { [INFO] [stderr] 145 | | true => Ok(Some(())), [INFO] [stderr] 146 | | false => Err(From::from("Cannot delete object.")) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if results.into_iter().all(|i| i.is_ok()) { Ok(Some(())) } else { Err(From::from("Cannot delete object.")) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:80:37 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn load(&self, external_id: &String) -> VaultResultOption> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:114:39 [INFO] [stderr] | [INFO] [stderr] 114 | pub fn delete(&self, external_id: &String) -> VaultResultOption<()> { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 114 | pub fn delete(&self, external_id: &str) -> VaultResultOption<()> { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `external_id.clone()` to [INFO] [stderr] | [INFO] [stderr] 123 | let id = external_id.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty-vault`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / match results.into_iter().all(|i| i.is_ok()) { [INFO] [stderr] 145 | | true => Ok(Some(())), [INFO] [stderr] 146 | | false => Err(From::from("Cannot delete object.")) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if results.into_iter().all(|i| i.is_ok()) { Ok(Some(())) } else { Err(From::from("Cannot delete object.")) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty-vault`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "465a0e44e1b39a118413a238fa53673dcbd73e613a2cbba6f29bc1f68d2b5b4e"` [INFO] running `"docker" "rm" "-f" "465a0e44e1b39a118413a238fa53673dcbd73e613a2cbba6f29bc1f68d2b5b4e"` [INFO] [stdout] 465a0e44e1b39a118413a238fa53673dcbd73e613a2cbba6f29bc1f68d2b5b4e