[INFO] updating cached repository AnthonyP4312/i3-alt-tab [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AnthonyP4312/i3-alt-tab [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AnthonyP4312/i3-alt-tab" "work/ex/clippy-test-run/sources/stable/gh/AnthonyP4312/i3-alt-tab"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AnthonyP4312/i3-alt-tab'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AnthonyP4312/i3-alt-tab" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AnthonyP4312/i3-alt-tab"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AnthonyP4312/i3-alt-tab'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 64efd56944d26cce816fc0e4b7cefb9b5e201b0e [INFO] sha for GitHub repo AnthonyP4312/i3-alt-tab: 64efd56944d26cce816fc0e4b7cefb9b5e201b0e [INFO] validating manifest of AnthonyP4312/i3-alt-tab on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AnthonyP4312/i3-alt-tab on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AnthonyP4312/i3-alt-tab [INFO] finished frobbing AnthonyP4312/i3-alt-tab [INFO] frobbed toml for AnthonyP4312/i3-alt-tab written to work/ex/clippy-test-run/sources/stable/gh/AnthonyP4312/i3-alt-tab/Cargo.toml [INFO] started frobbing AnthonyP4312/i3-alt-tab [INFO] finished frobbing AnthonyP4312/i3-alt-tab [INFO] frobbed toml for AnthonyP4312/i3-alt-tab written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AnthonyP4312/i3-alt-tab/Cargo.toml [INFO] crate AnthonyP4312/i3-alt-tab has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AnthonyP4312/i3-alt-tab against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AnthonyP4312/i3-alt-tab:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a681ef51c1c3b414e170a5b500fe666c850be001d988be0ecef0a2e33e9f4bb3 [INFO] running `"docker" "start" "-a" "a681ef51c1c3b414e170a5b500fe666c850be001d988be0ecef0a2e33e9f4bb3"` [INFO] [stderr] Checking alt_tabber v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return () [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/main.rs:92:16 [INFO] [stderr] | [INFO] [stderr] 92 | return () [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | windows.iter().nth(focused_index - 1).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / Command::new("i3-msg") [INFO] [stderr] 40 | | .arg(format!("[con_id={}] focus", next.id)) [INFO] [stderr] 41 | | .output(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused variable: `child_c` [INFO] [stderr] --> src/main.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | let child_c = Node { [INFO] [stderr] | ^^^^^^^ help: consider using `_child_c` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `node_with_children` [INFO] [stderr] --> src/main.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | let node_with_children = Node { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using `_node_with_children` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `setup` [INFO] [stderr] --> src/main.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | fn setup() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | windows.iter().nth(focused_index - 1).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / Command::new("i3-msg") [INFO] [stderr] 40 | | .arg(format!("[con_id={}] focus", next.id)) [INFO] [stderr] 41 | | .output(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.73s [INFO] running `"docker" "inspect" "a681ef51c1c3b414e170a5b500fe666c850be001d988be0ecef0a2e33e9f4bb3"` [INFO] running `"docker" "rm" "-f" "a681ef51c1c3b414e170a5b500fe666c850be001d988be0ecef0a2e33e9f4bb3"` [INFO] [stdout] a681ef51c1c3b414e170a5b500fe666c850be001d988be0ecef0a2e33e9f4bb3