[INFO] updating cached repository AnimatedRNG/skype-vpn [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AnimatedRNG/skype-vpn [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AnimatedRNG/skype-vpn" "work/ex/clippy-test-run/sources/stable/gh/AnimatedRNG/skype-vpn"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AnimatedRNG/skype-vpn'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AnimatedRNG/skype-vpn" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AnimatedRNG/skype-vpn"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AnimatedRNG/skype-vpn'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bd6e16e4f35cbd700f78ca450562e5b71dcd9e47 [INFO] sha for GitHub repo AnimatedRNG/skype-vpn: bd6e16e4f35cbd700f78ca450562e5b71dcd9e47 [INFO] validating manifest of AnimatedRNG/skype-vpn on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AnimatedRNG/skype-vpn on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AnimatedRNG/skype-vpn [INFO] finished frobbing AnimatedRNG/skype-vpn [INFO] frobbed toml for AnimatedRNG/skype-vpn written to work/ex/clippy-test-run/sources/stable/gh/AnimatedRNG/skype-vpn/Cargo.toml [INFO] started frobbing AnimatedRNG/skype-vpn [INFO] finished frobbing AnimatedRNG/skype-vpn [INFO] frobbed toml for AnimatedRNG/skype-vpn written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AnimatedRNG/skype-vpn/Cargo.toml [INFO] crate AnimatedRNG/skype-vpn has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AnimatedRNG/skype-vpn against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AnimatedRNG/skype-vpn:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8e6ec1c41e468f03a12180ac8141d7fbf812f3b5256f48b9ebd80f929a7fdefb [INFO] running `"docker" "start" "-a" "8e6ec1c41e468f03a12180ac8141d7fbf812f3b5256f48b9ebd80f929a7fdefb"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Checking reed-solomon v0.2.1 [INFO] [stderr] Checking skype-vpn v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `server_tx` [INFO] [stderr] --> src/main.rs:303:10 [INFO] [stderr] | [INFO] [stderr] 303 | let (server_tx, server_rx) = handle_1_1_udp(server_sock, Some(socket_addr)); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_server_tx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MAX_UDP_PACKET_LEN` [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | const MAX_UDP_PACKET_LEN: usize = 576; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..v.len() { [INFO] [stderr] | ^^^^^^^^^^ help: try replacing the loop by: `f[..v.len()].clone_from_slice(&v[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:96:40 [INFO] [stderr] | [INFO] [stderr] 96 | raw_frame_data.extend([0u8; 2].into_iter()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:98:33 [INFO] [stderr] | [INFO] [stderr] 98 | raw_frame_data.extend(v.into_iter()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:106:26 [INFO] [stderr] | [INFO] [stderr] 106 | for i in 0..c.len() { [INFO] [stderr] | ^^^^^^^^^^ help: try replacing the loop by: `padded[..c.len()].clone_from_slice(&c[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | / c.iter() [INFO] [stderr] 148 | | .find(|&&x| x != 0) [INFO] [stderr] 149 | | .is_some() [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|&&x| x != 0).is_some()` with `any(|&&x| x != 0)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | io::stdout().write(&f).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:317:13 [INFO] [stderr] | [INFO] [stderr] 317 | io::stdout().write(&f).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `skype-vpn`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `server_tx` [INFO] [stderr] --> src/main.rs:303:10 [INFO] [stderr] | [INFO] [stderr] 303 | let (server_tx, server_rx) = handle_1_1_udp(server_sock, Some(socket_addr)); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_server_tx` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MAX_UDP_PACKET_LEN` [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | const MAX_UDP_PACKET_LEN: usize = 576; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | for i in 0..v.len() { [INFO] [stderr] | ^^^^^^^^^^ help: try replacing the loop by: `f[..v.len()].clone_from_slice(&v[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:96:40 [INFO] [stderr] | [INFO] [stderr] 96 | raw_frame_data.extend([0u8; 2].into_iter()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/main.rs:98:33 [INFO] [stderr] | [INFO] [stderr] 98 | raw_frame_data.extend(v.into_iter()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:106:26 [INFO] [stderr] | [INFO] [stderr] 106 | for i in 0..c.len() { [INFO] [stderr] | ^^^^^^^^^^ help: try replacing the loop by: `padded[..c.len()].clone_from_slice(&c[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | / c.iter() [INFO] [stderr] 148 | | .find(|&&x| x != 0) [INFO] [stderr] 149 | | .is_some() [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|&&x| x != 0).is_some()` with `any(|&&x| x != 0)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | io::stdout().write(&f).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:317:13 [INFO] [stderr] | [INFO] [stderr] 317 | io::stdout().write(&f).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `skype-vpn`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8e6ec1c41e468f03a12180ac8141d7fbf812f3b5256f48b9ebd80f929a7fdefb"` [INFO] running `"docker" "rm" "-f" "8e6ec1c41e468f03a12180ac8141d7fbf812f3b5256f48b9ebd80f929a7fdefb"` [INFO] [stdout] 8e6ec1c41e468f03a12180ac8141d7fbf812f3b5256f48b9ebd80f929a7fdefb