[INFO] updating cached repository Anfauglith/sudoku [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Anfauglith/sudoku [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Anfauglith/sudoku" "work/ex/clippy-test-run/sources/stable/gh/Anfauglith/sudoku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Anfauglith/sudoku'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Anfauglith/sudoku" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Anfauglith/sudoku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Anfauglith/sudoku'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 198a8b8f2a95bbbc42d9691a5c8a017d1b397c46 [INFO] sha for GitHub repo Anfauglith/sudoku: 198a8b8f2a95bbbc42d9691a5c8a017d1b397c46 [INFO] validating manifest of Anfauglith/sudoku on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Anfauglith/sudoku on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Anfauglith/sudoku [INFO] finished frobbing Anfauglith/sudoku [INFO] frobbed toml for Anfauglith/sudoku written to work/ex/clippy-test-run/sources/stable/gh/Anfauglith/sudoku/Cargo.toml [INFO] started frobbing Anfauglith/sudoku [INFO] finished frobbing Anfauglith/sudoku [INFO] frobbed toml for Anfauglith/sudoku written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Anfauglith/sudoku/Cargo.toml [INFO] crate Anfauglith/sudoku has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Anfauglith/sudoku against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Anfauglith/sudoku:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f2bee335bb48dad697f7884d351d650e497f0e55c6d4b683def5548c0f6ac411 [INFO] running `"docker" "start" "-a" "f2bee335bb48dad697f7884d351d650e497f0e55c6d4b683def5548c0f6ac411"` [INFO] [stderr] Checking sudoku v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | Some(_) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | None => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | Some(_) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | None => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CANDIDATE_MASK` [INFO] [stderr] --> src/field.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | const CANDIDATE_MASK: u16 = 0b0000_0011_1111_1110; // 0x03FE [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Field` [INFO] [stderr] --> src/field.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct Field { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Cell` [INFO] [stderr] --> src/field.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub struct Cell { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `empty_cell` [INFO] [stderr] --> src/field.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn empty_cell() -> Cell { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `fixed_cell` [INFO] [stderr] --> src/field.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn fixed_cell(digit: u8) -> Cell { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_solved` [INFO] [stderr] --> src/field.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn is_solved(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_fixed` [INFO] [stderr] --> src/field.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn is_fixed(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_digit` [INFO] [stderr] --> src/field.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn get_digit(&self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `fix` [INFO] [stderr] --> src/field.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | fn fix(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_to` [INFO] [stderr] --> src/field.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | fn set_to(&mut self, digit: u8) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `fix_to` [INFO] [stderr] --> src/field.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn fix_to(&mut self, digit: u8) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `has_candidate` [INFO] [stderr] --> src/field.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn has_candidate(&self, candidate: u8) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_candidates` [INFO] [stderr] --> src/field.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn get_candidates(&self) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_candidate_vector` [INFO] [stderr] --> src/field.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn get_candidate_vector(&self) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `remove_candidate` [INFO] [stderr] --> src/field.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn remove_candidate(&mut self, candidate: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `remove_candidates` [INFO] [stderr] --> src/field.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn remove_candidates(&mut self, candidates: Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `has_single_candidate` [INFO] [stderr] --> src/field.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn has_single_candidate(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_naked_single` [INFO] [stderr] --> src/field.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn get_naked_single(&self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `try_solve` [INFO] [stderr] --> src/field.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn try_solve(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/field.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | i = i << 1; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `i <<= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:34:24 [INFO] [stderr] | [INFO] [stderr] 34 | Some(_) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | None => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:122:24 [INFO] [stderr] | [INFO] [stderr] 122 | Some(_) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:123:21 [INFO] [stderr] | [INFO] [stderr] 123 | None => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Field` [INFO] [stderr] --> src/field.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub struct Field { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_solved` [INFO] [stderr] --> src/field.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn is_solved(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/field.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | i = i << 1; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `i <<= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.26s [INFO] running `"docker" "inspect" "f2bee335bb48dad697f7884d351d650e497f0e55c6d4b683def5548c0f6ac411"` [INFO] running `"docker" "rm" "-f" "f2bee335bb48dad697f7884d351d650e497f0e55c6d4b683def5548c0f6ac411"` [INFO] [stdout] f2bee335bb48dad697f7884d351d650e497f0e55c6d4b683def5548c0f6ac411