[INFO] updating cached repository AndyHoang/showrss [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AndyHoang/showrss [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AndyHoang/showrss" "work/ex/clippy-test-run/sources/stable/gh/AndyHoang/showrss"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AndyHoang/showrss'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AndyHoang/showrss" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AndyHoang/showrss"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AndyHoang/showrss'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 70d0c3a086ce5f03c900dd6c94e249d79885587b [INFO] sha for GitHub repo AndyHoang/showrss: 70d0c3a086ce5f03c900dd6c94e249d79885587b [INFO] validating manifest of AndyHoang/showrss on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AndyHoang/showrss on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AndyHoang/showrss [INFO] finished frobbing AndyHoang/showrss [INFO] frobbed toml for AndyHoang/showrss written to work/ex/clippy-test-run/sources/stable/gh/AndyHoang/showrss/Cargo.toml [INFO] started frobbing AndyHoang/showrss [INFO] finished frobbing AndyHoang/showrss [INFO] frobbed toml for AndyHoang/showrss written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AndyHoang/showrss/Cargo.toml [INFO] crate AndyHoang/showrss has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AndyHoang/showrss against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AndyHoang/showrss:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 700d087994c6c1c04e390ff3705241175347ca71320403e196f545050ba2f086 [INFO] running `"docker" "start" "-a" "700d087994c6c1c04e390ff3705241175347ca71320403e196f545050ba2f086"` [INFO] [stderr] Checking quick-xml v0.12.1 [INFO] [stderr] Checking rss v1.5.0 [INFO] [stderr] Checking showrss v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:32:33 [INFO] [stderr] | [INFO] [stderr] 32 | .and_then(|vec| vec.into_iter().last().and_then(|e| e.value())); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:33:62 [INFO] [stderr] | [INFO] [stderr] 33 | let link = item.link().map(String::from).map_or_else(|| Vec::new(), |link| vec![link]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:51:56 [INFO] [stderr] | [INFO] [stderr] 51 | let episodes :Vec = items.into_iter().map(|x| Episode::from(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Episode::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:60:28 [INFO] [stderr] | [INFO] [stderr] 60 | let selected = episodes.get(selector as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `episodes[selector as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | let the_output = Command::new("webtorrent") [INFO] [stderr] | ______________________________^ [INFO] [stderr] 64 | | .args(&[link, "--iina"]) [INFO] [stderr] 65 | | .output() [INFO] [stderr] 66 | | .ok() [INFO] [stderr] 67 | | .expect("failed to execute process"); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:32:33 [INFO] [stderr] | [INFO] [stderr] 32 | .and_then(|vec| vec.into_iter().last().and_then(|e| e.value())); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:33:62 [INFO] [stderr] | [INFO] [stderr] 33 | let link = item.link().map(String::from).map_or_else(|| Vec::new(), |link| vec![link]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:51:56 [INFO] [stderr] | [INFO] [stderr] 51 | let episodes :Vec = items.into_iter().map(|x| Episode::from(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Episode::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:60:28 [INFO] [stderr] | [INFO] [stderr] 60 | let selected = episodes.get(selector as usize).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `episodes[selector as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:63:30 [INFO] [stderr] | [INFO] [stderr] 63 | let the_output = Command::new("webtorrent") [INFO] [stderr] | ______________________________^ [INFO] [stderr] 64 | | .args(&[link, "--iina"]) [INFO] [stderr] 65 | | .output() [INFO] [stderr] 66 | | .ok() [INFO] [stderr] 67 | | .expect("failed to execute process"); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.55s [INFO] running `"docker" "inspect" "700d087994c6c1c04e390ff3705241175347ca71320403e196f545050ba2f086"` [INFO] running `"docker" "rm" "-f" "700d087994c6c1c04e390ff3705241175347ca71320403e196f545050ba2f086"` [INFO] [stdout] 700d087994c6c1c04e390ff3705241175347ca71320403e196f545050ba2f086