[INFO] updating cached repository AndyDSM/conwayprofile-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/AndyDSM/conwayprofile-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/AndyDSM/conwayprofile-rust" "work/ex/clippy-test-run/sources/stable/gh/AndyDSM/conwayprofile-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AndyDSM/conwayprofile-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/AndyDSM/conwayprofile-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AndyDSM/conwayprofile-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AndyDSM/conwayprofile-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 653d292cc65ba0da8b4c5902dc6713be36c7746c
[INFO] sha for GitHub repo AndyDSM/conwayprofile-rust: 653d292cc65ba0da8b4c5902dc6713be36c7746c
[INFO] validating manifest of AndyDSM/conwayprofile-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of AndyDSM/conwayprofile-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing AndyDSM/conwayprofile-rust
[INFO] finished frobbing AndyDSM/conwayprofile-rust
[INFO] frobbed toml for AndyDSM/conwayprofile-rust written to work/ex/clippy-test-run/sources/stable/gh/AndyDSM/conwayprofile-rust/Cargo.toml
[INFO] started frobbing AndyDSM/conwayprofile-rust
[INFO] finished frobbing AndyDSM/conwayprofile-rust
[INFO] frobbed toml for AndyDSM/conwayprofile-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AndyDSM/conwayprofile-rust/Cargo.toml
[INFO] crate AndyDSM/conwayprofile-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting AndyDSM/conwayprofile-rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AndyDSM/conwayprofile-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f5807f60726c50fef342817cb45f47e61ba9faf71862cf7420b4ca2b98f5a8d6
[INFO] running `"docker" "start" "-a" "f5807f60726c50fef342817cb45f47e61ba9faf71862cf7420b4ca2b98f5a8d6"`
[INFO] [stderr]     Checking conwayprofile v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/lib.rs:140:49
[INFO] [stderr]     |
[INFO] [stderr] 140 |     fn gen(&mut self, str: &String, max: usize) -> () {
[INFO] [stderr]     |                                                 ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/lib.rs:173:47
[INFO] [stderr]     |
[INFO] [stderr] 173 | pub fn from_string(str: &String, factor: u16) -> () {
[INFO] [stderr]     |                                               ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: immediately dereferencing a reference
[INFO] [stderr]    --> src/lib.rs:206:39
[INFO] [stderr]     |
[INFO] [stderr] 206 |         frame.buffer = Cow::Borrowed(&*&state[..]);
[INFO] [stderr]     |                                       ^^^^^^^^^^^ help: try this: `state[..]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::deref_addrof)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `wrap`
[INFO] [stderr]   --> src/lib.rs:90:43
[INFO] [stderr]    |
[INFO] [stderr] 90 |     fn board_next(&self, board: &Vec<u8>, wrap: bool) -> Vec<u8> {
[INFO] [stderr]    |                                           ^^^^ help: consider using `_wrap` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i`
[INFO] [stderr]    --> src/lib.rs:116:13
[INFO] [stderr]     |
[INFO] [stderr] 116 |         for i in 0..max {
[INFO] [stderr]     |             ^ help: consider using `_i` instead
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:24:29
[INFO] [stderr]    |
[INFO] [stderr] 24 |     fn get_hash(&self, str: &String) -> [u8; 32] {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:35:34
[INFO] [stderr]    |
[INFO] [stderr] 35 |     fn board_initial(&self, str: &String) -> Vec<u8> {
[INFO] [stderr]    |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `byte` is used to index `hash`
[INFO] [stderr]   --> src/lib.rs:40:21
[INFO] [stderr]    |
[INFO] [stderr] 40 |         for byte in 0..self.bytes_needed {
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 40 |         for (byte, <item>) in hash.iter_mut().enumerate().take(self.bytes_needed) {
[INFO] [stderr]    |             ^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:61:40
[INFO] [stderr]    |
[INFO] [stderr] 61 |     fn board_square_next(&self, board: &Vec<u8>, x: usize, y: usize, wrap: bool) -> u8 {
[INFO] [stderr]    |                                        ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]   --> src/lib.rs:76:22
[INFO] [stderr]    |
[INFO] [stderr] 76 |             for i in vec![(top,left), (top,x), (top,right), (y,left), (y,right), (bottom,left), (bottom,x), (bottom,right)] {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[(top,left), (top,x), (top,right), (y,left), (y,right), (bottom,left), (bottom,x), (bottom,right)]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:90:33
[INFO] [stderr]    |
[INFO] [stderr] 90 |     fn board_next(&self, board: &Vec<u8>, wrap: bool) -> Vec<u8> {
[INFO] [stderr]    |                                 ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:104:37
[INFO] [stderr]     |
[INFO] [stderr] 104 |     fn is_board_empty(&self, board: &Vec<u8>) -> bool {
[INFO] [stderr]     |                                     ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:111:31
[INFO] [stderr]     |
[INFO] [stderr] 111 |     fn all_boards(&self, str: &String, max: usize) -> Vec<Vec<u8>> {
[INFO] [stderr]     |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:140:28
[INFO] [stderr]     |
[INFO] [stderr] 140 |     fn gen(&mut self, str: &String, max: usize) -> () {
[INFO] [stderr]     |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:173:25
[INFO] [stderr]     |
[INFO] [stderr] 173 | pub fn from_string(str: &String, factor: u16) -> () {
[INFO] [stderr]     |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/lib.rs:140:49
[INFO] [stderr]     |
[INFO] [stderr] 140 |     fn gen(&mut self, str: &String, max: usize) -> () {
[INFO] [stderr]     |                                                 ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/lib.rs:173:47
[INFO] [stderr]     |
[INFO] [stderr] 173 | pub fn from_string(str: &String, factor: u16) -> () {
[INFO] [stderr]     |                                               ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: immediately dereferencing a reference
[INFO] [stderr]    --> src/lib.rs:206:39
[INFO] [stderr]     |
[INFO] [stderr] 206 |         frame.buffer = Cow::Borrowed(&*&state[..]);
[INFO] [stderr]     |                                       ^^^^^^^^^^^ help: try this: `state[..]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::deref_addrof)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `wrap`
[INFO] [stderr]   --> src/lib.rs:90:43
[INFO] [stderr]    |
[INFO] [stderr] 90 |     fn board_next(&self, board: &Vec<u8>, wrap: bool) -> Vec<u8> {
[INFO] [stderr]    |                                           ^^^^ help: consider using `_wrap` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i`
[INFO] [stderr]    --> src/lib.rs:116:13
[INFO] [stderr]     |
[INFO] [stderr] 116 |         for i in 0..max {
[INFO] [stderr]     |             ^ help: consider using `_i` instead
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:24:29
[INFO] [stderr]    |
[INFO] [stderr] 24 |     fn get_hash(&self, str: &String) -> [u8; 32] {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:35:34
[INFO] [stderr]    |
[INFO] [stderr] 35 |     fn board_initial(&self, str: &String) -> Vec<u8> {
[INFO] [stderr]    |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `byte` is used to index `hash`
[INFO] [stderr]   --> src/lib.rs:40:21
[INFO] [stderr]    |
[INFO] [stderr] 40 |         for byte in 0..self.bytes_needed {
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 40 |         for (byte, <item>) in hash.iter_mut().enumerate().take(self.bytes_needed) {
[INFO] [stderr]    |             ^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:61:40
[INFO] [stderr]    |
[INFO] [stderr] 61 |     fn board_square_next(&self, board: &Vec<u8>, x: usize, y: usize, wrap: bool) -> u8 {
[INFO] [stderr]    |                                        ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]   --> src/lib.rs:76:22
[INFO] [stderr]    |
[INFO] [stderr] 76 |             for i in vec![(top,left), (top,x), (top,right), (y,left), (y,right), (bottom,left), (bottom,x), (bottom,right)] {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[(top,left), (top,x), (top,right), (y,left), (y,right), (bottom,left), (bottom,x), (bottom,right)]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:90:33
[INFO] [stderr]    |
[INFO] [stderr] 90 |     fn board_next(&self, board: &Vec<u8>, wrap: bool) -> Vec<u8> {
[INFO] [stderr]    |                                 ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:104:37
[INFO] [stderr]     |
[INFO] [stderr] 104 |     fn is_board_empty(&self, board: &Vec<u8>) -> bool {
[INFO] [stderr]     |                                     ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:111:31
[INFO] [stderr]     |
[INFO] [stderr] 111 |     fn all_boards(&self, str: &String, max: usize) -> Vec<Vec<u8>> {
[INFO] [stderr]     |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:140:28
[INFO] [stderr]     |
[INFO] [stderr] 140 |     fn gen(&mut self, str: &String, max: usize) -> () {
[INFO] [stderr]     |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:173:25
[INFO] [stderr]     |
[INFO] [stderr] 173 | pub fn from_string(str: &String, factor: u16) -> () {
[INFO] [stderr]     |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.69s
[INFO] running `"docker" "inspect" "f5807f60726c50fef342817cb45f47e61ba9faf71862cf7420b4ca2b98f5a8d6"`
[INFO] running `"docker" "rm" "-f" "f5807f60726c50fef342817cb45f47e61ba9faf71862cf7420b4ca2b98f5a8d6"`
[INFO] [stdout] f5807f60726c50fef342817cb45f47e61ba9faf71862cf7420b4ca2b98f5a8d6