[INFO] updating cached repository Andre-Vink/vtail [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Andre-Vink/vtail [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Andre-Vink/vtail" "work/ex/clippy-test-run/sources/stable/gh/Andre-Vink/vtail"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Andre-Vink/vtail'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Andre-Vink/vtail" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Andre-Vink/vtail"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Andre-Vink/vtail'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2975fa60e45d5768e1e2261f20b137b734d3b7e2 [INFO] sha for GitHub repo Andre-Vink/vtail: 2975fa60e45d5768e1e2261f20b137b734d3b7e2 [INFO] validating manifest of Andre-Vink/vtail on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Andre-Vink/vtail on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Andre-Vink/vtail [INFO] finished frobbing Andre-Vink/vtail [INFO] frobbed toml for Andre-Vink/vtail written to work/ex/clippy-test-run/sources/stable/gh/Andre-Vink/vtail/Cargo.toml [INFO] started frobbing Andre-Vink/vtail [INFO] finished frobbing Andre-Vink/vtail [INFO] frobbed toml for Andre-Vink/vtail written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Andre-Vink/vtail/Cargo.toml [INFO] crate Andre-Vink/vtail has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Andre-Vink/vtail against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Andre-Vink/vtail:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3eb59c8a694e88e89f8dbcce9c65d500d1c5a1cc14612c14901e3c438dc3d9c2 [INFO] running `"docker" "start" "-a" "3eb59c8a694e88e89f8dbcce9c65d500d1c5a1cc14612c14901e3c438dc3d9c2"` [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking filetime v0.1.15 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking notify v4.0.3 [INFO] [stderr] Checking vtail v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/arguments.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/arguments.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/arguments.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | if usefull_args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!usefull_args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/arguments.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if usefull_args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `usefull_args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:54:62 [INFO] [stderr] | [INFO] [stderr] 54 | fn tail(file_map: &mut HashMap, paths_to_watch: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[PathBuf]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:132:80 [INFO] [stderr] | [INFO] [stderr] 132 | fn echo_file(file_map: &mut HashMap, file: &Path, paths_to_watch: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[PathBuf]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:161:31 [INFO] [stderr] | [INFO] [stderr] 161 | fn echo_whole_file(file_name: &String) -> u64 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:166:30 [INFO] [stderr] | [INFO] [stderr] 166 | fn echo_file_from(file_name: &String, fp: u64) -> u64 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:190:36 [INFO] [stderr] | [INFO] [stderr] 190 | if rest.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/arguments.rs:19:12 [INFO] [stderr] | [INFO] [stderr] 19 | if usefull_args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!usefull_args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/arguments.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | if usefull_args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `usefull_args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:54:62 [INFO] [stderr] | [INFO] [stderr] 54 | fn tail(file_map: &mut HashMap, paths_to_watch: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[PathBuf]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:132:80 [INFO] [stderr] | [INFO] [stderr] 132 | fn echo_file(file_map: &mut HashMap, file: &Path, paths_to_watch: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[PathBuf]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:161:31 [INFO] [stderr] | [INFO] [stderr] 161 | fn echo_whole_file(file_name: &String) -> u64 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:166:30 [INFO] [stderr] | [INFO] [stderr] 166 | fn echo_file_from(file_name: &String, fp: u64) -> u64 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:190:36 [INFO] [stderr] | [INFO] [stderr] 190 | if rest.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.51s [INFO] running `"docker" "inspect" "3eb59c8a694e88e89f8dbcce9c65d500d1c5a1cc14612c14901e3c438dc3d9c2"` [INFO] running `"docker" "rm" "-f" "3eb59c8a694e88e89f8dbcce9c65d500d1c5a1cc14612c14901e3c438dc3d9c2"` [INFO] [stdout] 3eb59c8a694e88e89f8dbcce9c65d500d1c5a1cc14612c14901e3c438dc3d9c2