[INFO] updating cached repository An-Tu/rust-template-creator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/An-Tu/rust-template-creator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/An-Tu/rust-template-creator" "work/ex/clippy-test-run/sources/stable/gh/An-Tu/rust-template-creator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/An-Tu/rust-template-creator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/An-Tu/rust-template-creator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/An-Tu/rust-template-creator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/An-Tu/rust-template-creator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e66be8bfb3607be658fcf362676d7c75351a8674 [INFO] sha for GitHub repo An-Tu/rust-template-creator: e66be8bfb3607be658fcf362676d7c75351a8674 [INFO] validating manifest of An-Tu/rust-template-creator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of An-Tu/rust-template-creator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing An-Tu/rust-template-creator [INFO] finished frobbing An-Tu/rust-template-creator [INFO] frobbed toml for An-Tu/rust-template-creator written to work/ex/clippy-test-run/sources/stable/gh/An-Tu/rust-template-creator/Cargo.toml [INFO] started frobbing An-Tu/rust-template-creator [INFO] finished frobbing An-Tu/rust-template-creator [INFO] frobbed toml for An-Tu/rust-template-creator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/An-Tu/rust-template-creator/Cargo.toml [INFO] crate An-Tu/rust-template-creator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting An-Tu/rust-template-creator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/An-Tu/rust-template-creator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 491ccf16c4a22cf52c139ba5f1710c3f635f0ecd821d82875260916897089b1e [INFO] running `"docker" "start" "-a" "491ccf16c4a22cf52c139ba5f1710c3f635f0ecd821d82875260916897089b1e"` [INFO] [stderr] Checking template_creator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/fs_helpers.rs:16:38 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn create_folder(path: &PathBuf) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/fs_helpers.rs:23:77 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn create_file(path: &PathBuf, name: &str, extension: &str, data: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/templ.rs:1:32 [INFO] [stderr] | [INFO] [stderr] 1 | pub const COMPONENT_TEMPLATE: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/templ.rs:22:28 [INFO] [stderr] | [INFO] [stderr] 22 | pub const STYLE_TEMPLATE: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/templ.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | pub const INDEX_TEMPLATE: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_file` [INFO] [stderr] --> src/fs_helpers.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn read_file>(path_to_file: P) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/fs_helpers.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | Err(_) => panic!("can't create folder {:?}", path) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/fs_helpers.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | Err(_) => panic!("can't create file {:?}", file_name) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/fs_helpers.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | Err(_) => panic!("can't create file {:?}", file_name) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/utils.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | / loop { [INFO] [stderr] 5 | | match content.find(from) { [INFO] [stderr] 6 | | Some(idx) => content.replace_range(idx..idx + from.len(), to), [INFO] [stderr] 7 | | _ => break, [INFO] [stderr] 8 | | } [INFO] [stderr] 9 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(idx) = content.find(from) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | let words = s.split("_"); [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/fs_helpers.rs:16:38 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn create_folder(path: &PathBuf) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/fs_helpers.rs:23:77 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn create_file(path: &PathBuf, name: &str, extension: &str, data: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/templ.rs:1:32 [INFO] [stderr] | [INFO] [stderr] 1 | pub const COMPONENT_TEMPLATE: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/templ.rs:22:28 [INFO] [stderr] | [INFO] [stderr] 22 | pub const STYLE_TEMPLATE: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/templ.rs:28:28 [INFO] [stderr] | [INFO] [stderr] 28 | pub const INDEX_TEMPLATE: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_file` [INFO] [stderr] --> src/fs_helpers.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn read_file>(path_to_file: P) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/fs_helpers.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | Err(_) => panic!("can't create folder {:?}", path) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/fs_helpers.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | Err(_) => panic!("can't create file {:?}", file_name) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/fs_helpers.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | Err(_) => panic!("can't create file {:?}", file_name) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/utils.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | / loop { [INFO] [stderr] 5 | | match content.find(from) { [INFO] [stderr] 6 | | Some(idx) => content.replace_range(idx..idx + from.len(), to), [INFO] [stderr] 7 | | _ => break, [INFO] [stderr] 8 | | } [INFO] [stderr] 9 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(idx) = content.find(from) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | let words = s.split("_"); [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `"docker" "inspect" "491ccf16c4a22cf52c139ba5f1710c3f635f0ecd821d82875260916897089b1e"` [INFO] running `"docker" "rm" "-f" "491ccf16c4a22cf52c139ba5f1710c3f635f0ecd821d82875260916897089b1e"` [INFO] [stdout] 491ccf16c4a22cf52c139ba5f1710c3f635f0ecd821d82875260916897089b1e