[INFO] updating cached repository AmaranthineCodices/n_body_simulation [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AmaranthineCodices/n_body_simulation [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AmaranthineCodices/n_body_simulation" "work/ex/clippy-test-run/sources/stable/gh/AmaranthineCodices/n_body_simulation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AmaranthineCodices/n_body_simulation'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AmaranthineCodices/n_body_simulation" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AmaranthineCodices/n_body_simulation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AmaranthineCodices/n_body_simulation'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 81a6ab1776560e13e4a24a3a62cacb5850621f5c [INFO] sha for GitHub repo AmaranthineCodices/n_body_simulation: 81a6ab1776560e13e4a24a3a62cacb5850621f5c [INFO] validating manifest of AmaranthineCodices/n_body_simulation on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AmaranthineCodices/n_body_simulation on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AmaranthineCodices/n_body_simulation [INFO] finished frobbing AmaranthineCodices/n_body_simulation [INFO] frobbed toml for AmaranthineCodices/n_body_simulation written to work/ex/clippy-test-run/sources/stable/gh/AmaranthineCodices/n_body_simulation/Cargo.toml [INFO] started frobbing AmaranthineCodices/n_body_simulation [INFO] finished frobbing AmaranthineCodices/n_body_simulation [INFO] frobbed toml for AmaranthineCodices/n_body_simulation written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AmaranthineCodices/n_body_simulation/Cargo.toml [INFO] crate AmaranthineCodices/n_body_simulation has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AmaranthineCodices/n_body_simulation against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AmaranthineCodices/n_body_simulation:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 952c8820adff2cbf449f80dcad4580f4be5d6fdf1cf933c791f3ec0908064021 [INFO] running `"docker" "start" "-a" "952c8820adff2cbf449f80dcad4580f4be5d6fdf1cf933c791f3ec0908064021"` [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Checking rayon-core v1.3.0 [INFO] [stderr] Checking x11-dl v2.16.0 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking libloading v0.3.4 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking glutin v0.10.1 [INFO] [stderr] Checking piston2d-opengl_graphics v0.49.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.42.0 [INFO] [stderr] Checking n_body_simulation v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/nbody.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / return Particle { [INFO] [stderr] 43 | | mass: rng.gen_range(10000000.0, 250000000.0), [INFO] [stderr] 44 | | position: [rng.gen_range(200.0, 600.0), rng.gen_range(200.0, 400.0)], [INFO] [stderr] 45 | | color: rng.gen(), [INFO] [stderr] 46 | | force: [0.0, 0.0], [INFO] [stderr] 47 | | velocity: [0.0, 0.0] [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 42 | Particle { [INFO] [stderr] 43 | mass: rng.gen_range(10000000.0, 250000000.0), [INFO] [stderr] 44 | position: [rng.gen_range(200.0, 600.0), rng.gen_range(200.0, 400.0)], [INFO] [stderr] 45 | color: rng.gen(), [INFO] [stderr] 46 | force: [0.0, 0.0], [INFO] [stderr] 47 | velocity: [0.0, 0.0] [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nbody.rs:43:29 [INFO] [stderr] | [INFO] [stderr] 43 | mass: rng.gen_range(10000000.0, 250000000.0), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `10_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nbody.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | mass: rng.gen_range(10000000.0, 250000000.0), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `250_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:32:81 [INFO] [stderr] | [INFO] [stderr] 32 | let particle_render = ellipse::circle(0.0, 0.0, particle.mass / 10000000.0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `10_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:39:32 [INFO] [stderr] | [INFO] [stderr] 39 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/nbody.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / return Particle { [INFO] [stderr] 43 | | mass: rng.gen_range(10000000.0, 250000000.0), [INFO] [stderr] 44 | | position: [rng.gen_range(200.0, 600.0), rng.gen_range(200.0, 400.0)], [INFO] [stderr] 45 | | color: rng.gen(), [INFO] [stderr] 46 | | force: [0.0, 0.0], [INFO] [stderr] 47 | | velocity: [0.0, 0.0] [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 42 | Particle { [INFO] [stderr] 43 | mass: rng.gen_range(10000000.0, 250000000.0), [INFO] [stderr] 44 | position: [rng.gen_range(200.0, 600.0), rng.gen_range(200.0, 400.0)], [INFO] [stderr] 45 | color: rng.gen(), [INFO] [stderr] 46 | force: [0.0, 0.0], [INFO] [stderr] 47 | velocity: [0.0, 0.0] [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nbody.rs:43:29 [INFO] [stderr] | [INFO] [stderr] 43 | mass: rng.gen_range(10000000.0, 250000000.0), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `10_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nbody.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | mass: rng.gen_range(10000000.0, 250000000.0), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `250_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:32:81 [INFO] [stderr] | [INFO] [stderr] 32 | let particle_render = ellipse::circle(0.0, 0.0, particle.mass / 10000000.0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `10_000_000.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:39:32 [INFO] [stderr] | [INFO] [stderr] 39 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 52.61s [INFO] running `"docker" "inspect" "952c8820adff2cbf449f80dcad4580f4be5d6fdf1cf933c791f3ec0908064021"` [INFO] running `"docker" "rm" "-f" "952c8820adff2cbf449f80dcad4580f4be5d6fdf1cf933c791f3ec0908064021"` [INFO] [stdout] 952c8820adff2cbf449f80dcad4580f4be5d6fdf1cf933c791f3ec0908064021