[INFO] updating cached repository AllesCoolAllesBestens/getting-started-with-piston [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AllesCoolAllesBestens/getting-started-with-piston [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AllesCoolAllesBestens/getting-started-with-piston" "work/ex/clippy-test-run/sources/stable/gh/AllesCoolAllesBestens/getting-started-with-piston"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AllesCoolAllesBestens/getting-started-with-piston'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AllesCoolAllesBestens/getting-started-with-piston" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AllesCoolAllesBestens/getting-started-with-piston"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AllesCoolAllesBestens/getting-started-with-piston'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a0a071f74897a505cbdab1dd9d51eab22bcc1aca [INFO] sha for GitHub repo AllesCoolAllesBestens/getting-started-with-piston: a0a071f74897a505cbdab1dd9d51eab22bcc1aca [INFO] validating manifest of AllesCoolAllesBestens/getting-started-with-piston on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AllesCoolAllesBestens/getting-started-with-piston on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AllesCoolAllesBestens/getting-started-with-piston [INFO] finished frobbing AllesCoolAllesBestens/getting-started-with-piston [INFO] frobbed toml for AllesCoolAllesBestens/getting-started-with-piston written to work/ex/clippy-test-run/sources/stable/gh/AllesCoolAllesBestens/getting-started-with-piston/Cargo.toml [INFO] started frobbing AllesCoolAllesBestens/getting-started-with-piston [INFO] finished frobbing AllesCoolAllesBestens/getting-started-with-piston [INFO] frobbed toml for AllesCoolAllesBestens/getting-started-with-piston written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AllesCoolAllesBestens/getting-started-with-piston/Cargo.toml [INFO] crate AllesCoolAllesBestens/getting-started-with-piston has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AllesCoolAllesBestens/getting-started-with-piston against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AllesCoolAllesBestens/getting-started-with-piston:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8a79edcd2c53385caed67a31a852507dd68310600868142762ebd09dc346ac0e [INFO] running `"docker" "start" "-a" "8a79edcd2c53385caed67a31a852507dd68310600868142762ebd09dc346ac0e"` [INFO] [stderr] Checking deflate v0.7.5 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Checking pistoncore-input v0.17.1 [INFO] [stderr] Checking arrayvec v0.3.21 [INFO] [stderr] Compiling gl v0.6.1 [INFO] [stderr] Checking jpeg-decoder v0.1.11 [INFO] [stderr] Checking rusttype v0.2.1 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking pistoncore-window v0.26.2 [INFO] [stderr] Checking pistoncore-event_loop v0.31.4 [INFO] [stderr] Checking image v0.12.3 [INFO] [stderr] Checking piston v0.31.4 [INFO] [stderr] Checking piston-gfx_texture v0.22.1 [INFO] [stderr] Checking piston2d-gfx_graphics v0.38.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.35.1 [INFO] [stderr] Checking piston_window v0.64.0 [INFO] [stderr] Checking getting-started-with-piston v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this looks like you are trying to use `.. -= ..`, but you really are doing `.. = (- ..)` [INFO] [stderr] --> src/main.rs:34:33 [INFO] [stderr] | [INFO] [stderr] 34 | self.velocity[0] =- self.velocity[0]; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_assignment_formatting)] on by default [INFO] [stderr] = note: to remove this lint, use either `-=` or `= -` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_assignment_formatting [INFO] [stderr] [INFO] [stderr] warning: this looks like you are trying to use `.. -= ..`, but you really are doing `.. = (- ..)` [INFO] [stderr] --> src/main.rs:41:33 [INFO] [stderr] | [INFO] [stderr] 41 | self.velocity[1] =- self.velocity[1]; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, use either `-=` or `= -` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_assignment_formatting [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:66:32 [INFO] [stderr] | [INFO] [stderr] 66 | window_size = (r.width as f64, r.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(r.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:66:49 [INFO] [stderr] | [INFO] [stderr] 66 | window_size = (r.width as f64, r.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(r.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | / match b { [INFO] [stderr] 80 | | Button::Keyboard(k) => { [INFO] [stderr] 81 | | match k { [INFO] [stderr] 82 | | Key::W => { [INFO] [stderr] ... | [INFO] [stderr] 91 | | _ => {} [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 79 | if let Button::Keyboard(k) = b { [INFO] [stderr] 80 | match k { [INFO] [stderr] 81 | Key::W => { [INFO] [stderr] 82 | rect.change_velocity(1.1); [INFO] [stderr] 83 | } [INFO] [stderr] 84 | Key::S => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this looks like you are trying to use `.. -= ..`, but you really are doing `.. = (- ..)` [INFO] [stderr] --> src/main.rs:34:33 [INFO] [stderr] | [INFO] [stderr] 34 | self.velocity[0] =- self.velocity[0]; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_assignment_formatting)] on by default [INFO] [stderr] = note: to remove this lint, use either `-=` or `= -` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_assignment_formatting [INFO] [stderr] [INFO] [stderr] warning: this looks like you are trying to use `.. -= ..`, but you really are doing `.. = (- ..)` [INFO] [stderr] --> src/main.rs:41:33 [INFO] [stderr] | [INFO] [stderr] 41 | self.velocity[1] =- self.velocity[1]; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, use either `-=` or `= -` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_assignment_formatting [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:66:32 [INFO] [stderr] | [INFO] [stderr] 66 | window_size = (r.width as f64, r.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(r.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:66:49 [INFO] [stderr] | [INFO] [stderr] 66 | window_size = (r.width as f64, r.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(r.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | / match b { [INFO] [stderr] 80 | | Button::Keyboard(k) => { [INFO] [stderr] 81 | | match k { [INFO] [stderr] 82 | | Key::W => { [INFO] [stderr] ... | [INFO] [stderr] 91 | | _ => {} [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 79 | if let Button::Keyboard(k) = b { [INFO] [stderr] 80 | match k { [INFO] [stderr] 81 | Key::W => { [INFO] [stderr] 82 | rect.change_velocity(1.1); [INFO] [stderr] 83 | } [INFO] [stderr] 84 | Key::S => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 33.47s [INFO] running `"docker" "inspect" "8a79edcd2c53385caed67a31a852507dd68310600868142762ebd09dc346ac0e"` [INFO] running `"docker" "rm" "-f" "8a79edcd2c53385caed67a31a852507dd68310600868142762ebd09dc346ac0e"` [INFO] [stdout] 8a79edcd2c53385caed67a31a852507dd68310600868142762ebd09dc346ac0e