[INFO] updating cached repository Aligorith/xspf_parser_jsl-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Aligorith/xspf_parser_jsl-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Aligorith/xspf_parser_jsl-rs" "work/ex/clippy-test-run/sources/stable/gh/Aligorith/xspf_parser_jsl-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Aligorith/xspf_parser_jsl-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Aligorith/xspf_parser_jsl-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aligorith/xspf_parser_jsl-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aligorith/xspf_parser_jsl-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 27bd7d66c8d22d695c3af26a14439eb7e02d14ec [INFO] sha for GitHub repo Aligorith/xspf_parser_jsl-rs: 27bd7d66c8d22d695c3af26a14439eb7e02d14ec [INFO] validating manifest of Aligorith/xspf_parser_jsl-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Aligorith/xspf_parser_jsl-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Aligorith/xspf_parser_jsl-rs [INFO] finished frobbing Aligorith/xspf_parser_jsl-rs [INFO] frobbed toml for Aligorith/xspf_parser_jsl-rs written to work/ex/clippy-test-run/sources/stable/gh/Aligorith/xspf_parser_jsl-rs/Cargo.toml [INFO] started frobbing Aligorith/xspf_parser_jsl-rs [INFO] finished frobbing Aligorith/xspf_parser_jsl-rs [INFO] frobbed toml for Aligorith/xspf_parser_jsl-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aligorith/xspf_parser_jsl-rs/Cargo.toml [INFO] crate Aligorith/xspf_parser_jsl-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Aligorith/xspf_parser_jsl-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Aligorith/xspf_parser_jsl-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fbd06b9b3c9bbe6723cec395466c295e2c9ab53295aaf7de26ef6623bbc87b73 [INFO] running `"docker" "start" "-a" "fbd06b9b3c9bbe6723cec395466c295e2c9ab53295aaf7de26ef6623bbc87b73"` [INFO] [stderr] Checking num-traits v0.2.0 [INFO] [stderr] Compiling indoc-impl v0.2.3 [INFO] [stderr] Checking quick-xml v0.11.0 [INFO] [stderr] Checking serde_json v1.0.10 [INFO] [stderr] Checking indoc v0.2.3 [INFO] [stderr] Checking minidom v0.8.0 [INFO] [stderr] Checking xspf_tools v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/track_name_info.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | index : index, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/track_name_info.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | index : index, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/track_name_info.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | name : name, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/track_name_info.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | track_type : track_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `track_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/track_name_info.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | index : index, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xspf_parser.rs:184:4 [INFO] [stderr] | [INFO] [stderr] 184 | title: title [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/track_name_info.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | index : index, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/track_name_info.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | index : index, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:159:4 [INFO] [stderr] | [INFO] [stderr] 159 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/track_name_info.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | name : name, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/track_name_info.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | track_type : track_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `track_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/track_name_info.rs:180:5 [INFO] [stderr] | [INFO] [stderr] 180 | index : index, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xspf_parser.rs:184:4 [INFO] [stderr] | [INFO] [stderr] 184 | title: title [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:159:4 [INFO] [stderr] | [INFO] [stderr] 159 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/xspf_parser.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | const FILE_URI_PREFIX: &'static str = "file:///"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:71:2 [INFO] [stderr] | [INFO] [stderr] 71 | out_writer [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | let out_writer = match out_file { [INFO] [stderr] | ______________________^ [INFO] [stderr] 63 | | Some(x) => { [INFO] [stderr] 64 | | let path = Path::new(x); [INFO] [stderr] 65 | | Box::new(File::create(&path).unwrap()) as Box [INFO] [stderr] ... | [INFO] [stderr] 69 | | }, [INFO] [stderr] 70 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/xspf_parser.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | const FILE_URI_PREFIX: &'static str = "file:///"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:71:2 [INFO] [stderr] | [INFO] [stderr] 71 | out_writer [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:62:19 [INFO] [stderr] | [INFO] [stderr] 62 | let out_writer = match out_file { [INFO] [stderr] | ______________________^ [INFO] [stderr] 63 | | Some(x) => { [INFO] [stderr] 64 | | let path = Path::new(x); [INFO] [stderr] 65 | | Box::new(File::create(&path).unwrap()) as Box [INFO] [stderr] ... | [INFO] [stderr] 69 | | }, [INFO] [stderr] 70 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/xspf_parser.rs:68:51 [INFO] [stderr] | [INFO] [stderr] 68 | let mut path_elems : Vec<&str> = fullpath.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/xspf_parser.rs:101:46 [INFO] [stderr] | [INFO] [stderr] 101 | let e_location = e_track.children().find(|&& ref x| x.name() == "location"); [INFO] [stderr] | ^^^^^^^ help: try removing the `&ref` part and just keep: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_borrowed_reference)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/xspf_parser.rs:102:46 [INFO] [stderr] | [INFO] [stderr] 102 | let e_duration = e_track.children().find(|&& ref x| x.name() == "duration"); [INFO] [stderr] | ^^^^^^^ help: try removing the `&ref` part and just keep: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/xspf_parser.rs:159:10 [INFO] [stderr] | [INFO] [stderr] 159 | match e_section.name().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `e_section.name()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:101:4 [INFO] [stderr] | [INFO] [stderr] 101 | match writeln!(out, "{0}", track.path) { [INFO] [stderr] | _____________^ [INFO] [stderr] 102 | | Err(why) => { [INFO] [stderr] 103 | | eprintln!("ERROR: {}", why.description()); [INFO] [stderr] 104 | | break; [INFO] [stderr] 105 | | }, [INFO] [stderr] 106 | | _ => { /* continue */} [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | if let Err(why) = $ dst . write_fmt ( format_args_nl ! ( $ ( $ arg ) * ) ) { [INFO] [stderr] 102 | eprintln!("ERROR: {}", why.description()); [INFO] [stderr] 103 | break; [INFO] [stderr] 104 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | match writeln!(out, "{}", j) { [INFO] [stderr] | _________________^ [INFO] [stderr] 127 | | Err(why) => { [INFO] [stderr] 128 | | eprintln!("ERROR: Couldn't write JSON output - {}", why.description()); [INFO] [stderr] 129 | | }, [INFO] [stderr] 130 | | _ => { /* continue */} [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 126 | if let Err(why) = $ dst . write_fmt ( format_args_nl ! ( $ ( $ arg ) * ) ) { [INFO] [stderr] 127 | eprintln!("ERROR: Couldn't write JSON output - {}", why.description()); [INFO] [stderr] 128 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:257:7 [INFO] [stderr] | [INFO] [stderr] 257 | match writeln!(f, "{}", filename) { [INFO] [stderr] | _________________________^ [INFO] [stderr] 258 | | Err(why) => { [INFO] [stderr] 259 | | eprintln!("ERROR: Problem encountered while writing manifest file - {}", why.description()); [INFO] [stderr] 260 | | break; [INFO] [stderr] 261 | | } [INFO] [stderr] 262 | | _ => { /* keep going */ } [INFO] [stderr] 263 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 257 | if let Err(why) = $ dst . write_fmt ( format_args_nl ! ( $ ( $ arg ) * ) ) { [INFO] [stderr] 258 | eprintln!("ERROR: Problem encountered while writing manifest file - {}", why.description()); [INFO] [stderr] 259 | break; [INFO] [stderr] 260 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:282:38 [INFO] [stderr] | [INFO] [stderr] 282 | fn handle_xspf_processing_mode(args: &Vec, processing_func: XspfProcessingModeFunc) [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:289:7 [INFO] [stderr] | [INFO] [stderr] 289 | if f.ends_with(".xspf") == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!f.ends_with(".xspf")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/xspf_parser.rs:68:51 [INFO] [stderr] | [INFO] [stderr] 68 | let mut path_elems : Vec<&str> = fullpath.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/xspf_parser.rs:101:46 [INFO] [stderr] | [INFO] [stderr] 101 | let e_location = e_track.children().find(|&& ref x| x.name() == "location"); [INFO] [stderr] | ^^^^^^^ help: try removing the `&ref` part and just keep: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_borrowed_reference)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced [INFO] [stderr] --> src/xspf_parser.rs:102:46 [INFO] [stderr] | [INFO] [stderr] 102 | let e_duration = e_track.children().find(|&& ref x| x.name() == "duration"); [INFO] [stderr] | ^^^^^^^ help: try removing the `&ref` part and just keep: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/xspf_parser.rs:159:10 [INFO] [stderr] | [INFO] [stderr] 159 | match e_section.name().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `e_section.name()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:101:4 [INFO] [stderr] | [INFO] [stderr] 101 | match writeln!(out, "{0}", track.path) { [INFO] [stderr] | _____________^ [INFO] [stderr] 102 | | Err(why) => { [INFO] [stderr] 103 | | eprintln!("ERROR: {}", why.description()); [INFO] [stderr] 104 | | break; [INFO] [stderr] 105 | | }, [INFO] [stderr] 106 | | _ => { /* continue */} [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | if let Err(why) = $ dst . write_fmt ( format_args_nl ! ( $ ( $ arg ) * ) ) { [INFO] [stderr] 102 | eprintln!("ERROR: {}", why.description()); [INFO] [stderr] 103 | break; [INFO] [stderr] 104 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | match writeln!(out, "{}", j) { [INFO] [stderr] | _________________^ [INFO] [stderr] 127 | | Err(why) => { [INFO] [stderr] 128 | | eprintln!("ERROR: Couldn't write JSON output - {}", why.description()); [INFO] [stderr] 129 | | }, [INFO] [stderr] 130 | | _ => { /* continue */} [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 126 | if let Err(why) = $ dst . write_fmt ( format_args_nl ! ( $ ( $ arg ) * ) ) { [INFO] [stderr] 127 | eprintln!("ERROR: Couldn't write JSON output - {}", why.description()); [INFO] [stderr] 128 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:257:7 [INFO] [stderr] | [INFO] [stderr] 257 | match writeln!(f, "{}", filename) { [INFO] [stderr] | _________________________^ [INFO] [stderr] 258 | | Err(why) => { [INFO] [stderr] 259 | | eprintln!("ERROR: Problem encountered while writing manifest file - {}", why.description()); [INFO] [stderr] 260 | | break; [INFO] [stderr] 261 | | } [INFO] [stderr] 262 | | _ => { /* keep going */ } [INFO] [stderr] 263 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 257 | if let Err(why) = $ dst . write_fmt ( format_args_nl ! ( $ ( $ arg ) * ) ) { [INFO] [stderr] 258 | eprintln!("ERROR: Problem encountered while writing manifest file - {}", why.description()); [INFO] [stderr] 259 | break; [INFO] [stderr] 260 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:282:38 [INFO] [stderr] | [INFO] [stderr] 282 | fn handle_xspf_processing_mode(args: &Vec, processing_func: XspfProcessingModeFunc) [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:289:7 [INFO] [stderr] | [INFO] [stderr] 289 | if f.ends_with(".xspf") == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!f.ends_with(".xspf")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.77s [INFO] running `"docker" "inspect" "fbd06b9b3c9bbe6723cec395466c295e2c9ab53295aaf7de26ef6623bbc87b73"` [INFO] running `"docker" "rm" "-f" "fbd06b9b3c9bbe6723cec395466c295e2c9ab53295aaf7de26ef6623bbc87b73"` [INFO] [stdout] fbd06b9b3c9bbe6723cec395466c295e2c9ab53295aaf7de26ef6623bbc87b73