[INFO] updating cached repository AlexeyErzyamkin/game-servers [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AlexeyErzyamkin/game-servers [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AlexeyErzyamkin/game-servers" "work/ex/clippy-test-run/sources/stable/gh/AlexeyErzyamkin/game-servers"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AlexeyErzyamkin/game-servers'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AlexeyErzyamkin/game-servers" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexeyErzyamkin/game-servers"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexeyErzyamkin/game-servers'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6b4329394bbcd460e4c4ddbc806fddbee11fac9b [INFO] sha for GitHub repo AlexeyErzyamkin/game-servers: 6b4329394bbcd460e4c4ddbc806fddbee11fac9b [INFO] validating manifest of AlexeyErzyamkin/game-servers on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AlexeyErzyamkin/game-servers on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AlexeyErzyamkin/game-servers [INFO] finished frobbing AlexeyErzyamkin/game-servers [INFO] frobbed toml for AlexeyErzyamkin/game-servers written to work/ex/clippy-test-run/sources/stable/gh/AlexeyErzyamkin/game-servers/Cargo.toml [INFO] started frobbing AlexeyErzyamkin/game-servers [INFO] finished frobbing AlexeyErzyamkin/game-servers [INFO] frobbed toml for AlexeyErzyamkin/game-servers written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexeyErzyamkin/game-servers/Cargo.toml [INFO] crate AlexeyErzyamkin/game-servers has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AlexeyErzyamkin/game-servers against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AlexeyErzyamkin/game-servers:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32710b40f9dd5b00e0d1bbb7fe1b50d7c5a5aadd8b0a3cd333d4cf2d51e6ab13 [INFO] running `"docker" "start" "-a" "32710b40f9dd5b00e0d1bbb7fe1b50d7c5a5aadd8b0a3cd333d4cf2d51e6ab13"` [INFO] [stderr] Checking game-servers v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/echo/server.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/echo/connection.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/echo/connection.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | buffers: buffers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `buffers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/echo/server.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/echo/connection.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/echo/connection.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | buffers: buffers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `buffers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::option::Option` [INFO] [stderr] --> src/echo/connection.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::option::Option; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ErrorKind`, `Error` [INFO] [stderr] --> src/echo/connection.rs:3:28 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{Read, Write, Error, ErrorKind}; [INFO] [stderr] | ^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/echo/server.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match connection { [INFO] [stderr] 44 | | Connection::Fail => break, [INFO] [stderr] 45 | | _ => {} [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Connection::Fail = connection { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/echo/connection.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match self.stream.read(&mut buf) { [INFO] [stderr] 66 | | Ok(size) => { [INFO] [stderr] 67 | | if size == 4 && buf == [2,2,3,3] { [INFO] [stderr] 68 | | return Connection::Connected(self.into()); [INFO] [stderr] ... | [INFO] [stderr] 71 | | Err(_) => {} [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let Ok(size) = self.stream.read(&mut buf) { [INFO] [stderr] 66 | if size == 4 && buf == [2,2,3,3] { [INFO] [stderr] 67 | return Connection::Connected(self.into()); [INFO] [stderr] 68 | } [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/echo/connection.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / match self.stream.read(&mut buf) { [INFO] [stderr] 90 | | Ok(size) => { [INFO] [stderr] 91 | | match self.stream.write_all(&buf[0 .. size]) { [INFO] [stderr] 92 | | Ok(_) => { [INFO] [stderr] ... | [INFO] [stderr] 98 | | Err(_) => {} [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 89 | if let Ok(size) = self.stream.read(&mut buf) { [INFO] [stderr] 90 | match self.stream.write_all(&buf[0 .. size]) { [INFO] [stderr] 91 | Ok(_) => { [INFO] [stderr] 92 | return Connection::Connected(self); [INFO] [stderr] 93 | }, [INFO] [stderr] 94 | Err(_) => {} [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/echo/connection.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | / match self.stream.write_all(&buf[0 .. size]) { [INFO] [stderr] 92 | | Ok(_) => { [INFO] [stderr] 93 | | return Connection::Connected(self); [INFO] [stderr] 94 | | }, [INFO] [stderr] 95 | | Err(_) => {} [INFO] [stderr] 96 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 91 | if let Ok(_) = self.stream.write_all(&buf[0 .. size]) { [INFO] [stderr] 92 | return Connection::Connected(self); [INFO] [stderr] 93 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/echo/server.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match connection { [INFO] [stderr] 44 | | Connection::Fail => break, [INFO] [stderr] 45 | | _ => {} [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Connection::Fail = connection { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/echo/connection.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match self.stream.read(&mut buf) { [INFO] [stderr] 66 | | Ok(size) => { [INFO] [stderr] 67 | | if size == 4 && buf == [2,2,3,3] { [INFO] [stderr] 68 | | return Connection::Connected(self.into()); [INFO] [stderr] ... | [INFO] [stderr] 71 | | Err(_) => {} [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let Ok(size) = self.stream.read(&mut buf) { [INFO] [stderr] 66 | if size == 4 && buf == [2,2,3,3] { [INFO] [stderr] 67 | return Connection::Connected(self.into()); [INFO] [stderr] 68 | } [INFO] [stderr] 69 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/echo/connection.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / match self.stream.read(&mut buf) { [INFO] [stderr] 90 | | Ok(size) => { [INFO] [stderr] 91 | | match self.stream.write_all(&buf[0 .. size]) { [INFO] [stderr] 92 | | Ok(_) => { [INFO] [stderr] ... | [INFO] [stderr] 98 | | Err(_) => {} [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 89 | if let Ok(size) = self.stream.read(&mut buf) { [INFO] [stderr] 90 | match self.stream.write_all(&buf[0 .. size]) { [INFO] [stderr] 91 | Ok(_) => { [INFO] [stderr] 92 | return Connection::Connected(self); [INFO] [stderr] 93 | }, [INFO] [stderr] 94 | Err(_) => {} [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/echo/connection.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | / match self.stream.write_all(&buf[0 .. size]) { [INFO] [stderr] 92 | | Ok(_) => { [INFO] [stderr] 93 | | return Connection::Connected(self); [INFO] [stderr] 94 | | }, [INFO] [stderr] 95 | | Err(_) => {} [INFO] [stderr] 96 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 91 | if let Ok(_) = self.stream.write_all(&buf[0 .. size]) { [INFO] [stderr] 92 | return Connection::Connected(self); [INFO] [stderr] 93 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/echo/connection.rs:214:38 [INFO] [stderr] | [INFO] [stderr] 214 | Some(ref vec) if vec.as_slice() == &[1, 2, 3, 3, 5, 6] => {}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[1, 2, 3, 3, 5, 6]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `"docker" "inspect" "32710b40f9dd5b00e0d1bbb7fe1b50d7c5a5aadd8b0a3cd333d4cf2d51e6ab13"` [INFO] running `"docker" "rm" "-f" "32710b40f9dd5b00e0d1bbb7fe1b50d7c5a5aadd8b0a3cd333d4cf2d51e6ab13"` [INFO] [stdout] 32710b40f9dd5b00e0d1bbb7fe1b50d7c5a5aadd8b0a3cd333d4cf2d51e6ab13