[INFO] updating cached repository AlexanderEkdahl/symmetric-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AlexanderEkdahl/symmetric-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AlexanderEkdahl/symmetric-rs" "work/ex/clippy-test-run/sources/stable/gh/AlexanderEkdahl/symmetric-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AlexanderEkdahl/symmetric-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AlexanderEkdahl/symmetric-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexanderEkdahl/symmetric-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexanderEkdahl/symmetric-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fdc84475e92f8165d33bc01d9282302d88b70377 [INFO] sha for GitHub repo AlexanderEkdahl/symmetric-rs: fdc84475e92f8165d33bc01d9282302d88b70377 [INFO] validating manifest of AlexanderEkdahl/symmetric-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AlexanderEkdahl/symmetric-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AlexanderEkdahl/symmetric-rs [INFO] finished frobbing AlexanderEkdahl/symmetric-rs [INFO] frobbed toml for AlexanderEkdahl/symmetric-rs written to work/ex/clippy-test-run/sources/stable/gh/AlexanderEkdahl/symmetric-rs/Cargo.toml [INFO] started frobbing AlexanderEkdahl/symmetric-rs [INFO] finished frobbing AlexanderEkdahl/symmetric-rs [INFO] frobbed toml for AlexanderEkdahl/symmetric-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexanderEkdahl/symmetric-rs/Cargo.toml [INFO] crate AlexanderEkdahl/symmetric-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AlexanderEkdahl/symmetric-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AlexanderEkdahl/symmetric-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ca0339e8c37a91b8de97bb6a0c718905ec6355127887b0ddcaabbb639fb40af7 [INFO] running `"docker" "start" "-a" "ca0339e8c37a91b8de97bb6a0c718905ec6355127887b0ddcaabbb639fb40af7"` [INFO] [stderr] Checking symmetric v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | encrypt(0x12345678, [0x00, 0x11, 0x22, 0x33, 0x44, 0x55]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | encrypt(0x12345678, [0x00, 0x11, 0x22, 0x33, 0x44, 0x55]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i * 4` [INFO] [stderr] --> src/main.rs:50:16 [INFO] [stderr] | [INFO] [stderr] 50 | rk[i * 4 + 0] = b[3]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `r * 6` [INFO] [stderr] --> src/main.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | rk[r * 6 + 0], [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `r * 6` [INFO] [stderr] --> src/main.rs:105:21 [INFO] [stderr] | [INFO] [stderr] 105 | let t0 = rk[r * 6 + 0] ^ SBOX1[dst[1] as usize] ^ SBOX2[dst[2] as usize] ^ [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i * 4` [INFO] [stderr] --> src/main.rs:50:16 [INFO] [stderr] | [INFO] [stderr] 50 | rk[i * 4 + 0] = b[3]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `r * 6` [INFO] [stderr] --> src/main.rs:97:21 [INFO] [stderr] | [INFO] [stderr] 97 | rk[r * 6 + 0], [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `r * 6` [INFO] [stderr] --> src/main.rs:105:21 [INFO] [stderr] | [INFO] [stderr] 105 | let t0 = rk[r * 6 + 0] ^ SBOX1[dst[1] as usize] ^ SBOX2[dst[2] as usize] ^ [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.65s [INFO] running `"docker" "inspect" "ca0339e8c37a91b8de97bb6a0c718905ec6355127887b0ddcaabbb639fb40af7"` [INFO] running `"docker" "rm" "-f" "ca0339e8c37a91b8de97bb6a0c718905ec6355127887b0ddcaabbb639fb40af7"` [INFO] [stdout] ca0339e8c37a91b8de97bb6a0c718905ec6355127887b0ddcaabbb639fb40af7