[INFO] updating cached repository Alexander-Hjelm/construct.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Alexander-Hjelm/construct.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Alexander-Hjelm/construct.rs" "work/ex/clippy-test-run/sources/stable/gh/Alexander-Hjelm/construct.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Alexander-Hjelm/construct.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Alexander-Hjelm/construct.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Alexander-Hjelm/construct.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Alexander-Hjelm/construct.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7a22c57b8571ce6654db6774f3d8bb03faec48ed [INFO] sha for GitHub repo Alexander-Hjelm/construct.rs: 7a22c57b8571ce6654db6774f3d8bb03faec48ed [INFO] validating manifest of Alexander-Hjelm/construct.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Alexander-Hjelm/construct.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Alexander-Hjelm/construct.rs [INFO] finished frobbing Alexander-Hjelm/construct.rs [INFO] frobbed toml for Alexander-Hjelm/construct.rs written to work/ex/clippy-test-run/sources/stable/gh/Alexander-Hjelm/construct.rs/Cargo.toml [INFO] started frobbing Alexander-Hjelm/construct.rs [INFO] finished frobbing Alexander-Hjelm/construct.rs [INFO] frobbed toml for Alexander-Hjelm/construct.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Alexander-Hjelm/construct.rs/Cargo.toml [INFO] crate Alexander-Hjelm/construct.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Alexander-Hjelm/construct.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Alexander-Hjelm/construct.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7062c4c596084ad760f6af55210bde032012714e60c46a3305989ba160116715 [INFO] running `"docker" "start" "-a" "7062c4c596084ad760f6af55210bde032012714e60c46a3305989ba160116715"` [INFO] [stderr] Checking construct v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> construct.rs:367:5 [INFO] [stderr] | [INFO] [stderr] 367 | return Ok(tag); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(tag)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> construct.rs:367:5 [INFO] [stderr] | [INFO] [stderr] 367 | return Ok(tag); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(tag)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `bracket_count` is never read [INFO] [stderr] --> construct.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | let mut bracket_count = 0; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `bracket_count` is never read [INFO] [stderr] --> construct.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | let mut bracket_count = 0; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: the variable `c` is used as a loop counter. Consider using `for (c, item) in env::args().enumerate()` or similar iterators [INFO] [stderr] --> construct.rs:61:16 [INFO] [stderr] | [INFO] [stderr] 61 | for arg in env::args() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> construct.rs:153:41 [INFO] [stderr] | [INFO] [stderr] 153 | fn write_block(block: Block, templates: &Vec