[INFO] updating cached repository AlexRiedler/iridium-vm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AlexRiedler/iridium-vm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AlexRiedler/iridium-vm" "work/ex/clippy-test-run/sources/stable/gh/AlexRiedler/iridium-vm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AlexRiedler/iridium-vm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AlexRiedler/iridium-vm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexRiedler/iridium-vm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexRiedler/iridium-vm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 554c82d20809f6793aadd7de1d5b7f4d8e8849ab [INFO] sha for GitHub repo AlexRiedler/iridium-vm: 554c82d20809f6793aadd7de1d5b7f4d8e8849ab [INFO] validating manifest of AlexRiedler/iridium-vm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AlexRiedler/iridium-vm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AlexRiedler/iridium-vm [INFO] finished frobbing AlexRiedler/iridium-vm [INFO] frobbed toml for AlexRiedler/iridium-vm written to work/ex/clippy-test-run/sources/stable/gh/AlexRiedler/iridium-vm/Cargo.toml [INFO] started frobbing AlexRiedler/iridium-vm [INFO] finished frobbing AlexRiedler/iridium-vm [INFO] frobbed toml for AlexRiedler/iridium-vm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexRiedler/iridium-vm/Cargo.toml [INFO] crate AlexRiedler/iridium-vm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AlexRiedler/iridium-vm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AlexRiedler/iridium-vm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 394ae62e15580ed8074ad04ead132a49ae22fdfe8e745e5548b9f9853611b6dd [INFO] running `"docker" "start" "-a" "394ae62e15580ed8074ad04ead132a49ae22fdfe8e745e5548b9f9853611b6dd"` [INFO] [stderr] Checking iridium-mine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | opcode: opcode [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | opcode: opcode [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | 0 => return Opcode::LOAD, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::LOAD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | 1 => return Opcode::ADD, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::ADD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | 2 => return Opcode::SUB, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::SUB` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | 3 => return Opcode::MUL, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::MUL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:42:18 [INFO] [stderr] | [INFO] [stderr] 42 | 4 => return Opcode::DIV, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::DIV` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | 5 => return Opcode::HLT, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::HLT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | 6 => return Opcode::JMP, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JMP` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | 7 => return Opcode::JMPF, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JMPF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | 8 => return Opcode::JMPB, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JMPB` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | 9 => return Opcode::JMPE, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JMPE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:48:19 [INFO] [stderr] | [INFO] [stderr] 48 | 10 => return Opcode::EQ, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::EQ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:49:19 [INFO] [stderr] | [INFO] [stderr] 49 | 11 => return Opcode::NEQ, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::NEQ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:50:19 [INFO] [stderr] | [INFO] [stderr] 50 | 12 => return Opcode::GTE, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::GTE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:51:19 [INFO] [stderr] | [INFO] [stderr] 51 | 13 => return Opcode::LTE, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::LTE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | 14 => return Opcode::GT, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::GT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | 15 => return Opcode::LT, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::LT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | _ => return Opcode::IGL [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::IGL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | 0 => return Opcode::LOAD, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::LOAD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | 1 => return Opcode::ADD, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::ADD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | 2 => return Opcode::SUB, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::SUB` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | 3 => return Opcode::MUL, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::MUL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:42:18 [INFO] [stderr] | [INFO] [stderr] 42 | 4 => return Opcode::DIV, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::DIV` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | 5 => return Opcode::HLT, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::HLT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | 6 => return Opcode::JMP, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JMP` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | 7 => return Opcode::JMPF, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JMPF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | 8 => return Opcode::JMPB, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JMPB` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | 9 => return Opcode::JMPE, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JMPE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:48:19 [INFO] [stderr] | [INFO] [stderr] 48 | 10 => return Opcode::EQ, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::EQ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:49:19 [INFO] [stderr] | [INFO] [stderr] 49 | 11 => return Opcode::NEQ, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::NEQ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:50:19 [INFO] [stderr] | [INFO] [stderr] 50 | 12 => return Opcode::GTE, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::GTE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:51:19 [INFO] [stderr] | [INFO] [stderr] 51 | 13 => return Opcode::LTE, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::LTE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | 14 => return Opcode::GT, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::GT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | 15 => return Opcode::LT, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::LT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | _ => return Opcode::IGL [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::IGL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::VM` [INFO] [stderr] --> src/vm.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> VM { [INFO] [stderr] 13 | | VM { [INFO] [stderr] 14 | | registers: [0; 32], [INFO] [stderr] 15 | | program: vec![], [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:45:30 [INFO] [stderr] | [INFO] [stderr] 45 | let number = self.next_two_bytes() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.next_two_bytes())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/vm.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | false; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/vm.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | false; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:152:23 [INFO] [stderr] | [INFO] [stderr] 152 | let result = ((self.program[self.pc] as u16) << 8) | self.program[self.pc + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.pc])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:152:62 [INFO] [stderr] | [INFO] [stderr] 152 | let result = ((self.program[self.pc] as u16) << 8) | self.program[self.pc + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.pc + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `repl::REPL` [INFO] [stderr] --> src/repl/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> REPL { [INFO] [stderr] 18 | | REPL { [INFO] [stderr] 19 | | vm: VM::new(), [INFO] [stderr] 20 | | command_buffer: vec![] [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for repl::REPL { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/repl/mod.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | let split = i.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::VM` [INFO] [stderr] --> src/vm.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> VM { [INFO] [stderr] 13 | | VM { [INFO] [stderr] 14 | | registers: [0; 32], [INFO] [stderr] 15 | | program: vec![], [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:45:30 [INFO] [stderr] | [INFO] [stderr] 45 | let number = self.next_two_bytes() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.next_two_bytes())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/vm.rs:130:17 [INFO] [stderr] | [INFO] [stderr] 130 | false; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/vm.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | false; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:152:23 [INFO] [stderr] | [INFO] [stderr] 152 | let result = ((self.program[self.pc] as u16) << 8) | self.program[self.pc + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.pc])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:152:62 [INFO] [stderr] | [INFO] [stderr] 152 | let result = ((self.program[self.pc] as u16) << 8) | self.program[self.pc + 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.pc + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `repl::REPL` [INFO] [stderr] --> src/repl/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> REPL { [INFO] [stderr] 18 | | REPL { [INFO] [stderr] 19 | | vm: VM::new(), [INFO] [stderr] 20 | | command_buffer: vec![] [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for repl::REPL { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/repl/mod.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | let split = i.split(" ").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.96s [INFO] running `"docker" "inspect" "394ae62e15580ed8074ad04ead132a49ae22fdfe8e745e5548b9f9853611b6dd"` [INFO] running `"docker" "rm" "-f" "394ae62e15580ed8074ad04ead132a49ae22fdfe8e745e5548b9f9853611b6dd"` [INFO] [stdout] 394ae62e15580ed8074ad04ead132a49ae22fdfe8e745e5548b9f9853611b6dd