[INFO] updating cached repository AlexNav73/tanks-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AlexNav73/tanks-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AlexNav73/tanks-rs" "work/ex/clippy-test-run/sources/stable/gh/AlexNav73/tanks-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AlexNav73/tanks-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AlexNav73/tanks-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexNav73/tanks-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexNav73/tanks-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 09a1e5014fc9b3c0b4923d26ff26573e2427068a [INFO] sha for GitHub repo AlexNav73/tanks-rs: 09a1e5014fc9b3c0b4923d26ff26573e2427068a [INFO] validating manifest of AlexNav73/tanks-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AlexNav73/tanks-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AlexNav73/tanks-rs [INFO] finished frobbing AlexNav73/tanks-rs [INFO] frobbed toml for AlexNav73/tanks-rs written to work/ex/clippy-test-run/sources/stable/gh/AlexNav73/tanks-rs/Cargo.toml [INFO] started frobbing AlexNav73/tanks-rs [INFO] finished frobbing AlexNav73/tanks-rs [INFO] frobbed toml for AlexNav73/tanks-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlexNav73/tanks-rs/Cargo.toml [INFO] crate AlexNav73/tanks-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AlexNav73/tanks-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AlexNav73/tanks-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 52a1d1e7e10643c273ff1377a23e7823b4728433532cd997c1fc5a7dfc190f99 [INFO] running `"docker" "start" "-a" "52a1d1e7e10643c273ff1377a23e7823b4728433532cd997c1fc5a7dfc190f99"` [INFO] [stderr] Checking smallvec v0.4.3 [INFO] [stderr] Checking mint v0.2.0 [INFO] [stderr] Checking shared_library v0.1.6 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking obj-rs v0.4.19 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Checking gfx v0.15.1 [INFO] [stderr] Checking genmesh v0.5.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking pulse v0.5.3 [INFO] [stderr] Checking winit v0.6.4 [INFO] [stderr] Checking rayon v0.7.1 [INFO] [stderr] Checking glutin v0.8.1 [INFO] [stderr] Checking hibitset v0.1.3 [INFO] [stderr] Checking shred v0.4.3 [INFO] [stderr] Checking specs v0.9.5 [INFO] [stderr] Checking gfx_device_gl v0.14.1 [INFO] [stderr] Checking gfx_window_glutin v0.16.0 [INFO] [stderr] Checking tanks-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/context.rs:76:67 [INFO] [stderr] | [INFO] [stderr] 76 | self.event_loop.poll_events(|glutin::Event::WindowEvent { window_id: _, event }| events.push(event)); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `WindowEvent { event, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/context.rs:82:48 [INFO] [stderr] | [INFO] [stderr] 82 | (events, delta.subsec_nanos() as f32 / 1000_000_000.0) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/context.rs:76:67 [INFO] [stderr] | [INFO] [stderr] 76 | self.event_loop.poll_events(|glutin::Event::WindowEvent { window_id: _, event }| events.push(event)); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `WindowEvent { event, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/context.rs:82:48 [INFO] [stderr] | [INFO] [stderr] 82 | (events, delta.subsec_nanos() as f32 / 1000_000_000.0) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/defines.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | tex_coord: [t[0] as f32, t[1] as f32], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(t[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/defines.rs:36:38 [INFO] [stderr] | [INFO] [stderr] 36 | tex_coord: [t[0] as f32, t[1] as f32], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(t[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/context.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / match cmd { [INFO] [stderr] 106 | | Command::Render(mesh) => self.render(mesh), [INFO] [stderr] 107 | | _ => {} [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ help: try this: `if let Command::Render(mesh) = cmd { self.render(mesh) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mesh/model.rs:27:53 [INFO] [stderr] | [INFO] [stderr] 27 | let idxs = obj_data.indices.iter().map(|&i| i as u32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/systems.rs:55:23 [INFO] [stderr] | [INFO] [stderr] 55 | type SystemData = (Fetch<'a, Arc>>>, [INFO] [stderr] | _______________________^ [INFO] [stderr] 56 | | WriteStorage<'a, Camera>); [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/systems.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | type SystemData = (Fetch<'a, Arc>>>, [INFO] [stderr] | _______________________^ [INFO] [stderr] 78 | | ReadStorage<'a, Cube>, [INFO] [stderr] 79 | | ReadStorage<'a, Model>); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/components.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn into_vec(&self) -> Vector3 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/defines.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | tex_coord: [t[0] as f32, t[1] as f32], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(t[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/defines.rs:36:38 [INFO] [stderr] | [INFO] [stderr] 36 | tex_coord: [t[0] as f32, t[1] as f32], [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f32::from(t[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/context.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / match cmd { [INFO] [stderr] 106 | | Command::Render(mesh) => self.render(mesh), [INFO] [stderr] 107 | | _ => {} [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ help: try this: `if let Command::Render(mesh) = cmd { self.render(mesh) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mesh/model.rs:27:53 [INFO] [stderr] | [INFO] [stderr] 27 | let idxs = obj_data.indices.iter().map(|&i| i as u32).collect::>(); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/systems.rs:55:23 [INFO] [stderr] | [INFO] [stderr] 55 | type SystemData = (Fetch<'a, Arc>>>, [INFO] [stderr] | _______________________^ [INFO] [stderr] 56 | | WriteStorage<'a, Camera>); [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/systems.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | type SystemData = (Fetch<'a, Arc>>>, [INFO] [stderr] | _______________________^ [INFO] [stderr] 78 | | ReadStorage<'a, Cube>, [INFO] [stderr] 79 | | ReadStorage<'a, Model>); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/components.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn into_vec(&self) -> Vector3 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.44s [INFO] running `"docker" "inspect" "52a1d1e7e10643c273ff1377a23e7823b4728433532cd997c1fc5a7dfc190f99"` [INFO] running `"docker" "rm" "-f" "52a1d1e7e10643c273ff1377a23e7823b4728433532cd997c1fc5a7dfc190f99"` [INFO] [stdout] 52a1d1e7e10643c273ff1377a23e7823b4728433532cd997c1fc5a7dfc190f99