[INFO] updating cached repository AlcaYezz/pong_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AlcaYezz/pong_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AlcaYezz/pong_rust" "work/ex/clippy-test-run/sources/stable/gh/AlcaYezz/pong_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AlcaYezz/pong_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AlcaYezz/pong_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlcaYezz/pong_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlcaYezz/pong_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8181cbd1d13f674dcbb6ffb4f3444f03143d28ce [INFO] sha for GitHub repo AlcaYezz/pong_rust: 8181cbd1d13f674dcbb6ffb4f3444f03143d28ce [INFO] validating manifest of AlcaYezz/pong_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AlcaYezz/pong_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AlcaYezz/pong_rust [INFO] finished frobbing AlcaYezz/pong_rust [INFO] frobbed toml for AlcaYezz/pong_rust written to work/ex/clippy-test-run/sources/stable/gh/AlcaYezz/pong_rust/Cargo.toml [INFO] started frobbing AlcaYezz/pong_rust [INFO] finished frobbing AlcaYezz/pong_rust [INFO] frobbed toml for AlcaYezz/pong_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AlcaYezz/pong_rust/Cargo.toml [INFO] crate AlcaYezz/pong_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting AlcaYezz/pong_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AlcaYezz/pong_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b638dbc8eeeaf3f4d48afec9ddac31cc0c7da6d1d3b91ee79189f9cdaf92287d [INFO] running `"docker" "start" "-a" "b638dbc8eeeaf3f4d48afec9ddac31cc0c7da6d1d3b91ee79189f9cdaf92287d"` [INFO] [stderr] Compiling x11-dl v2.18.2 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling syn v0.14.7 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Compiling serde_derive v1.0.70 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking glutin v0.14.0 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking rusty v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/models/mod.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | let c = f.dot(f) - BALL_RADIUS * BALL_RADIUS; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/models/mod.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | let c = f.dot(f) - BALL_RADIUS * BALL_RADIUS; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:45:30 [INFO] [stderr] | [INFO] [stderr] 45 | line(BLACK, 1., [args.width as f64 / 2., 0., args.width as f64 / 2., args.height as f64], c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:45:58 [INFO] [stderr] | [INFO] [stderr] 45 | line(BLACK, 1., [args.width as f64 / 2., 0., args.width as f64 / 2., args.height as f64], c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:45:82 [INFO] [stderr] | [INFO] [stderr] 45 | line(BLACK, 1., [args.width as f64 / 2., 0., args.width as f64 / 2., args.height as f64], c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:51:39 [INFO] [stderr] | [INFO] [stderr] 51 | c.transform.trans(args.width as f64 * 0.25, args.height as f64 * 0.5), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:51:65 [INFO] [stderr] | [INFO] [stderr] 51 | c.transform.trans(args.width as f64 * 0.25, args.height as f64 * 0.5), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:59:39 [INFO] [stderr] | [INFO] [stderr] 59 | c.transform.trans(args.width as f64 * 0.75, args.height as f64 * 0.5), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:59:65 [INFO] [stderr] | [INFO] [stderr] 59 | c.transform.trans(args.width as f64 * 0.75, args.height as f64 * 0.5), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/enemy.rs:18:38 [INFO] [stderr] | [INFO] [stderr] 18 | pos: geom::Position::new(WINDOW_WIDTH as f64 - RACKET_WIDTH, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/enemy.rs:19:38 [INFO] [stderr] | [INFO] [stderr] 19 | (WINDOW_HEIGHT / 2) as f64 - RACKET_HEIGHT / 2.), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/enemy.rs:42:49 [INFO] [stderr] | [INFO] [stderr] 42 | if self.pos.y + RACKET_HEIGHT < WINDOW_HEIGHT as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/player.rs:20:38 [INFO] [stderr] | [INFO] [stderr] 20 | (WINDOW_HEIGHT / 2) as f64 - RACKET_HEIGHT / 2.), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/player.rs:52:49 [INFO] [stderr] | [INFO] [stderr] 52 | if self.pos.y + RACKET_HEIGHT < WINDOW_HEIGHT as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/ball.rs:19:32 [INFO] [stderr] | [INFO] [stderr] 19 | pos: Position::new(WINDOW_WIDTH as f64 / 2., [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/ball.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | WINDOW_HEIGHT as f64 / 2.), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/ball.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | self.pos.x = WINDOW_WIDTH as f64 / 2.; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/ball.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | self.pos.y = WINDOW_HEIGHT as f64 / 2.; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/ball.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | tmp as f64 / 1000. [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/ball.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | (tmp as f64 / 1000. + PI) % (2. * PI) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/mod.rs:35:96 [INFO] [stderr] | [INFO] [stderr] 35 | } else if ball.pos.y > enemy.pos.y + RACKET_HEIGHT * 0.75 && enemy.pos.y + RACKET_HEIGHT < WINDOW_HEIGHT as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/mod.rs:46:29 [INFO] [stderr] | [INFO] [stderr] 46 | } else if ball.pos.x >= WINDOW_WIDTH as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/mod.rs:49:77 [INFO] [stderr] | [INFO] [stderr] 49 | } else if ball.pos.y - BALL_RADIUS <= 0. || ball.pos.y + BALL_RADIUS >= WINDOW_HEIGHT as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/models/mod.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / if (x1 >= 0. && x1 <= 1.) || [INFO] [stderr] 95 | | (x2 >= 0. && x2 <= 1.) { [INFO] [stderr] 96 | | true [INFO] [stderr] 97 | | } else { [INFO] [stderr] 98 | | false [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 94 | (x1 >= 0. && x1 <= 1.) || [INFO] [stderr] 95 | (x2 >= 0. && x2 <= 1.) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | let ref font = assets.join("FiraSans-Regular.ttf"); [INFO] [stderr] | ----^^^^^^^^--------------------------------------- help: try: `let font = &assets.join("FiraSans-Regular.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:45:30 [INFO] [stderr] | [INFO] [stderr] 45 | line(BLACK, 1., [args.width as f64 / 2., 0., args.width as f64 / 2., args.height as f64], c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:45:58 [INFO] [stderr] | [INFO] [stderr] 45 | line(BLACK, 1., [args.width as f64 / 2., 0., args.width as f64 / 2., args.height as f64], c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:45:82 [INFO] [stderr] | [INFO] [stderr] 45 | line(BLACK, 1., [args.width as f64 / 2., 0., args.width as f64 / 2., args.height as f64], c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:51:39 [INFO] [stderr] | [INFO] [stderr] 51 | c.transform.trans(args.width as f64 * 0.25, args.height as f64 * 0.5), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:51:65 [INFO] [stderr] | [INFO] [stderr] 51 | c.transform.trans(args.width as f64 * 0.25, args.height as f64 * 0.5), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:59:39 [INFO] [stderr] | [INFO] [stderr] 59 | c.transform.trans(args.width as f64 * 0.75, args.height as f64 * 0.5), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:59:65 [INFO] [stderr] | [INFO] [stderr] 59 | c.transform.trans(args.width as f64 * 0.75, args.height as f64 * 0.5), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/enemy.rs:18:38 [INFO] [stderr] | [INFO] [stderr] 18 | pos: geom::Position::new(WINDOW_WIDTH as f64 - RACKET_WIDTH, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/enemy.rs:19:38 [INFO] [stderr] | [INFO] [stderr] 19 | (WINDOW_HEIGHT / 2) as f64 - RACKET_HEIGHT / 2.), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/enemy.rs:42:49 [INFO] [stderr] | [INFO] [stderr] 42 | if self.pos.y + RACKET_HEIGHT < WINDOW_HEIGHT as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/player.rs:20:38 [INFO] [stderr] | [INFO] [stderr] 20 | (WINDOW_HEIGHT / 2) as f64 - RACKET_HEIGHT / 2.), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/player.rs:52:49 [INFO] [stderr] | [INFO] [stderr] 52 | if self.pos.y + RACKET_HEIGHT < WINDOW_HEIGHT as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/ball.rs:19:32 [INFO] [stderr] | [INFO] [stderr] 19 | pos: Position::new(WINDOW_WIDTH as f64 / 2., [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/ball.rs:20:32 [INFO] [stderr] | [INFO] [stderr] 20 | WINDOW_HEIGHT as f64 / 2.), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/ball.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | self.pos.x = WINDOW_WIDTH as f64 / 2.; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/ball.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | self.pos.y = WINDOW_HEIGHT as f64 / 2.; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/ball.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | tmp as f64 / 1000. [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/ball.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | (tmp as f64 / 1000. + PI) % (2. * PI) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(tmp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/mod.rs:35:96 [INFO] [stderr] | [INFO] [stderr] 35 | } else if ball.pos.y > enemy.pos.y + RACKET_HEIGHT * 0.75 && enemy.pos.y + RACKET_HEIGHT < WINDOW_HEIGHT as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/mod.rs:46:29 [INFO] [stderr] | [INFO] [stderr] 46 | } else if ball.pos.x >= WINDOW_WIDTH as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/models/mod.rs:49:77 [INFO] [stderr] | [INFO] [stderr] 49 | } else if ball.pos.y - BALL_RADIUS <= 0. || ball.pos.y + BALL_RADIUS >= WINDOW_HEIGHT as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WINDOW_HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/models/mod.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / if (x1 >= 0. && x1 <= 1.) || [INFO] [stderr] 95 | | (x2 >= 0. && x2 <= 1.) { [INFO] [stderr] 96 | | true [INFO] [stderr] 97 | | } else { [INFO] [stderr] 98 | | false [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 94 | (x1 >= 0. && x1 <= 1.) || [INFO] [stderr] 95 | (x2 >= 0. && x2 <= 1.) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | let ref font = assets.join("FiraSans-Regular.ttf"); [INFO] [stderr] | ----^^^^^^^^--------------------------------------- help: try: `let font = &assets.join("FiraSans-Regular.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 52.51s [INFO] running `"docker" "inspect" "b638dbc8eeeaf3f4d48afec9ddac31cc0c7da6d1d3b91ee79189f9cdaf92287d"` [INFO] running `"docker" "rm" "-f" "b638dbc8eeeaf3f4d48afec9ddac31cc0c7da6d1d3b91ee79189f9cdaf92287d"` [INFO] [stdout] b638dbc8eeeaf3f4d48afec9ddac31cc0c7da6d1d3b91ee79189f9cdaf92287d