[INFO] updating cached repository Akavall/FileParsingTools [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Akavall/FileParsingTools [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Akavall/FileParsingTools" "work/ex/clippy-test-run/sources/stable/gh/Akavall/FileParsingTools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Akavall/FileParsingTools'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Akavall/FileParsingTools" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Akavall/FileParsingTools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Akavall/FileParsingTools'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2313b051de3864577c4dd128f97daa28f06760bd [INFO] sha for GitHub repo Akavall/FileParsingTools: 2313b051de3864577c4dd128f97daa28f06760bd [INFO] validating manifest of Akavall/FileParsingTools on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Akavall/FileParsingTools on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Akavall/FileParsingTools [INFO] finished frobbing Akavall/FileParsingTools [INFO] frobbed toml for Akavall/FileParsingTools written to work/ex/clippy-test-run/sources/stable/gh/Akavall/FileParsingTools/Cargo.toml [INFO] started frobbing Akavall/FileParsingTools [INFO] finished frobbing Akavall/FileParsingTools [INFO] frobbed toml for Akavall/FileParsingTools written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Akavall/FileParsingTools/Cargo.toml [INFO] crate Akavall/FileParsingTools has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Akavall/FileParsingTools against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Akavall/FileParsingTools:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 064d48b3f491b75832d7b35c06e30ccf6811d6767500f881bde7732ea15d1635 [INFO] running `"docker" "start" "-a" "064d48b3f491b75832d7b35c06e30ccf6811d6767500f881bde7732ea15d1635"` [INFO] [stderr] Checking temp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `line` [INFO] [stderr] --> src/n_rows/bin/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | for line in reader.lines() { [INFO] [stderr] | ^^^^ help: consider using `_line` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/col_counter/bin/main.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | return col_string; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `col_string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/col_counter/bin/main.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | / if col == col_tracker { [INFO] [stderr] 107 | | if c != delim || quote == true { [INFO] [stderr] 108 | | col_string.push(c) [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 106 | if col == col_tracker && (c != delim || quote == true) { [INFO] [stderr] 107 | col_string.push(c) [INFO] [stderr] 108 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/col_counter/bin/main.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | let ref file_name = args[1]; [INFO] [stderr] | ----^^^^^^^^^^^^^----------- help: try: `let file_name = &args[1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/col_counter/bin/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let ref col_number_str = args[2]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^----------- help: try: `let col_number_str = &args[2];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/col_counter/bin/main.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | Err(_) => panic!("Could not parse the col number: {}", example_input), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/col_counter/bin/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let ref delim_raw = args[3]; [INFO] [stderr] | ----^^^^^^^^^^^^^----------- help: try: `let delim_raw = &args[3];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/col_counter/bin/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | let ref n_lines_str = args[4]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^----------- help: try: `let n_lines_str = &args[4];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/col_counter/bin/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | Err(_) => panic!("Could not parse n_lines: {}", example_input), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/col_counter/bin/main.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | Err(_) => panic!("Could not open file: {} check if the file exists. Are you sure your input is correct? {}", file_name, example_input), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/col_counter/bin/main.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / if my_counter.contains_key(&col_string) { [INFO] [stderr] 67 | | *my_counter.get_mut(&col_string).unwrap() += 1; [INFO] [stderr] 68 | | } else { [INFO] [stderr] 69 | | my_counter.insert(col_string, 1); [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ help: consider using: `my_counter.entry(col_string)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: the loop variable `ind` is used to index `my_counter_items` [INFO] [stderr] --> src/col_counter/bin/main.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | for ind in 0..(n_lines_to_print) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 88 | for (ind, ) in my_counter_items.iter().enumerate().take((n_lines_to_print)) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/col_counter/bin/main.rs:107:30 [INFO] [stderr] | [INFO] [stderr] 107 | if c != delim || quote == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `quote` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/col_counter/bin/main.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | if quote == false { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `!quote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/col_counter/bin/main.rs:120:26 [INFO] [stderr] | [INFO] [stderr] 120 | if c == delim && quote == false { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `!quote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/col_counter/bin/main.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | return col_string; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `col_string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/col_counter/bin/main.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | / if col == col_tracker { [INFO] [stderr] 107 | | if c != delim || quote == true { [INFO] [stderr] 108 | | col_string.push(c) [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 106 | if col == col_tracker && (c != delim || quote == true) { [INFO] [stderr] 107 | col_string.push(c) [INFO] [stderr] 108 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `line` [INFO] [stderr] --> src/n_rows/bin/main.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | for line in reader.lines() { [INFO] [stderr] | ^^^^ help: consider using `_line` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/col_counter/bin/main.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | let ref file_name = args[1]; [INFO] [stderr] | ----^^^^^^^^^^^^^----------- help: try: `let file_name = &args[1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/col_counter/bin/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | let ref col_number_str = args[2]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^----------- help: try: `let col_number_str = &args[2];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/col_counter/bin/main.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | Err(_) => panic!("Could not parse the col number: {}", example_input), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/col_counter/bin/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let ref delim_raw = args[3]; [INFO] [stderr] | ----^^^^^^^^^^^^^----------- help: try: `let delim_raw = &args[3];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/col_counter/bin/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | let ref n_lines_str = args[4]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^----------- help: try: `let n_lines_str = &args[4];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/col_counter/bin/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | Err(_) => panic!("Could not parse n_lines: {}", example_input), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/col_counter/bin/main.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | Err(_) => panic!("Could not open file: {} check if the file exists. Are you sure your input is correct? {}", file_name, example_input), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/col_counter/bin/main.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / if my_counter.contains_key(&col_string) { [INFO] [stderr] 67 | | *my_counter.get_mut(&col_string).unwrap() += 1; [INFO] [stderr] 68 | | } else { [INFO] [stderr] 69 | | my_counter.insert(col_string, 1); [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ help: consider using: `my_counter.entry(col_string)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: the loop variable `ind` is used to index `my_counter_items` [INFO] [stderr] --> src/col_counter/bin/main.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | for ind in 0..(n_lines_to_print) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 88 | for (ind, ) in my_counter_items.iter().enumerate().take((n_lines_to_print)) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/col_counter/bin/main.rs:107:30 [INFO] [stderr] | [INFO] [stderr] 107 | if c != delim || quote == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `quote` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/col_counter/bin/main.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | if quote == false { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `!quote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/col_counter/bin/main.rs:120:26 [INFO] [stderr] | [INFO] [stderr] 120 | if c == delim && quote == false { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `!quote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/head_color/bin/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | let ref file_name = args[1]; [INFO] [stderr] | ----^^^^^^^^^^^^^----------- help: try: `let file_name = &args[1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/head_color/bin/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let ref col_number_str = args[2]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^----------- help: try: `let col_number_str = &args[2];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/head_color/bin/main.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | Err(_) => panic!("Could not parse the col number: {}", example_input), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/head_color/bin/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | let ref delim_raw = args[3]; [INFO] [stderr] | ----^^^^^^^^^^^^^----------- help: try: `let delim_raw = &args[3];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/head_color/bin/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | let ref n_lines_str = args[4]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^----------- help: try: `let n_lines_str = &args[4];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/head_color/bin/main.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | Err(_) => panic!("Could not parse n_lines: {}", example_input), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/head_color/bin/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | Err(_) => panic!("Could not open file: {} check if the file exists. Are you sure your input is correct? {}", file_name, example_input), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: the variable `row_number` is used as a loop counter. Consider using `for (row_number, item) in reader.lines().enumerate()` or similar iterators [INFO] [stderr] --> src/head_color/bin/main.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | for line in reader.lines() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/head_color/bin/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | let ref file_name = args[1]; [INFO] [stderr] | ----^^^^^^^^^^^^^----------- help: try: `let file_name = &args[1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/head_color/bin/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let ref col_number_str = args[2]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^----------- help: try: `let col_number_str = &args[2];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/head_color/bin/main.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | Err(_) => panic!("Could not parse the col number: {}", example_input), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/head_color/bin/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | let ref delim_raw = args[3]; [INFO] [stderr] | ----^^^^^^^^^^^^^----------- help: try: `let delim_raw = &args[3];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/head_color/bin/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | let ref n_lines_str = args[4]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^----------- help: try: `let n_lines_str = &args[4];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/head_color/bin/main.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | Err(_) => panic!("Could not parse n_lines: {}", example_input), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/head_color/bin/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | Err(_) => panic!("Could not open file: {} check if the file exists. Are you sure your input is correct? {}", file_name, example_input), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: the variable `row_number` is used as a loop counter. Consider using `for (row_number, item) in reader.lines().enumerate()` or similar iterators [INFO] [stderr] --> src/head_color/bin/main.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | for line in reader.lines() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/head_color/bin/main.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | if quote == false { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `!quote` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/head_color/bin/main.rs:86:26 [INFO] [stderr] | [INFO] [stderr] 86 | if c == delim && quote == false { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `!quote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/head_color/bin/main.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | if quote == false { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `!quote` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/head_color/bin/main.rs:86:26 [INFO] [stderr] | [INFO] [stderr] 86 | if c == delim && quote == false { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `!quote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.18s [INFO] running `"docker" "inspect" "064d48b3f491b75832d7b35c06e30ccf6811d6767500f881bde7732ea15d1635"` [INFO] running `"docker" "rm" "-f" "064d48b3f491b75832d7b35c06e30ccf6811d6767500f881bde7732ea15d1635"` [INFO] [stdout] 064d48b3f491b75832d7b35c06e30ccf6811d6767500f881bde7732ea15d1635