[INFO] updating cached repository AgustinCB/rustedpond [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AgustinCB/rustedpond [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AgustinCB/rustedpond" "work/ex/clippy-test-run/sources/stable/gh/AgustinCB/rustedpond"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AgustinCB/rustedpond'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AgustinCB/rustedpond" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AgustinCB/rustedpond"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AgustinCB/rustedpond'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2bdd36825b61fd611a58a5e28a7f5cb4f82cbda0 [INFO] sha for GitHub repo AgustinCB/rustedpond: 2bdd36825b61fd611a58a5e28a7f5cb4f82cbda0 [INFO] validating manifest of AgustinCB/rustedpond on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AgustinCB/rustedpond on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AgustinCB/rustedpond [INFO] finished frobbing AgustinCB/rustedpond [INFO] frobbed toml for AgustinCB/rustedpond written to work/ex/clippy-test-run/sources/stable/gh/AgustinCB/rustedpond/Cargo.toml [INFO] started frobbing AgustinCB/rustedpond [INFO] finished frobbing AgustinCB/rustedpond [INFO] frobbed toml for AgustinCB/rustedpond written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AgustinCB/rustedpond/Cargo.toml [INFO] crate AgustinCB/rustedpond has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AgustinCB/rustedpond against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AgustinCB/rustedpond:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e26d2b086d7a1e9668a444b74e56352fba2f6c5ef428572dd3296bf502803633 [INFO] running `"docker" "start" "-a" "e26d2b086d7a1e9668a444b74e56352fba2f6c5ef428572dd3296bf502803633"` [INFO] [stderr] Checking rustedpond v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib/mod.rs:17:37 [INFO] [stderr] | [INFO] [stderr] 17 | pub const REPORT_FREQUENCY: usize = 200000; [INFO] [stderr] | ^^^^^^ help: consider: `200_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib/mod.rs:17:37 [INFO] [stderr] | [INFO] [stderr] 17 | pub const REPORT_FREQUENCY: usize = 200000; [INFO] [stderr] | ^^^^^^ help: consider: `200_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cell::CellIdGenerator` [INFO] [stderr] --> src/lib/cell.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> CellIdGenerator { [INFO] [stderr] 16 | | CellIdGenerator { [INFO] [stderr] 17 | | current: 0, [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib/cell.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn next(&mut self) -> CellId { [INFO] [stderr] 23 | | self.current += 1; [INFO] [stderr] 24 | | CellId(self.current) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `genome::Genome` [INFO] [stderr] --> src/lib/genome.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> Genome { [INFO] [stderr] 9 | | Genome([!0; GENOME_SIZE]) [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | impl Default for genome::Genome { [INFO] [stderr] 7 | fn default() -> Self { [INFO] [stderr] 8 | Self::new() [INFO] [stderr] 9 | } [INFO] [stderr] 10 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `genome`. [INFO] [stderr] --> src/lib/genome.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | for i in 0..GENOME_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 14 | for in genome.iter_mut().take(GENOME_SIZE) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lib/instruction.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | INSTRUCTIONS.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `statistics::Statistics` [INFO] [stderr] --> src/lib/statistics.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | / pub fn new() -> Statistics { [INFO] [stderr] 104 | | Statistics { [INFO] [stderr] 105 | | instruction_executions: InstructionCounter::new(), [INFO] [stderr] 106 | | cell_executions: 0, [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 102 | impl Default for statistics::Statistics { [INFO] [stderr] 103 | fn default() -> Self { [INFO] [stderr] 104 | Self::new() [INFO] [stderr] 105 | } [INFO] [stderr] 106 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustedpond`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cell::CellIdGenerator` [INFO] [stderr] --> src/lib/cell.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> CellIdGenerator { [INFO] [stderr] 16 | | CellIdGenerator { [INFO] [stderr] 17 | | current: 0, [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib/cell.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn next(&mut self) -> CellId { [INFO] [stderr] 23 | | self.current += 1; [INFO] [stderr] 24 | | CellId(self.current) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `genome::Genome` [INFO] [stderr] --> src/lib/genome.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> Genome { [INFO] [stderr] 9 | | Genome([!0; GENOME_SIZE]) [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | impl Default for genome::Genome { [INFO] [stderr] 7 | fn default() -> Self { [INFO] [stderr] 8 | Self::new() [INFO] [stderr] 9 | } [INFO] [stderr] 10 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `genome`. [INFO] [stderr] --> src/lib/genome.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | for i in 0..GENOME_SIZE { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 14 | for in genome.iter_mut().take(GENOME_SIZE) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lib/instruction.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | INSTRUCTIONS.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `statistics::Statistics` [INFO] [stderr] --> src/lib/statistics.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | / pub fn new() -> Statistics { [INFO] [stderr] 104 | | Statistics { [INFO] [stderr] 105 | | instruction_executions: InstructionCounter::new(), [INFO] [stderr] 106 | | cell_executions: 0, [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 102 | impl Default for statistics::Statistics { [INFO] [stderr] 103 | fn default() -> Self { [INFO] [stderr] 104 | Self::new() [INFO] [stderr] 105 | } [INFO] [stderr] 106 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustedpond`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e26d2b086d7a1e9668a444b74e56352fba2f6c5ef428572dd3296bf502803633"` [INFO] running `"docker" "rm" "-f" "e26d2b086d7a1e9668a444b74e56352fba2f6c5ef428572dd3296bf502803633"` [INFO] [stdout] e26d2b086d7a1e9668a444b74e56352fba2f6c5ef428572dd3296bf502803633