[INFO] updating cached repository Aehmlo/deoxy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Aehmlo/deoxy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Aehmlo/deoxy" "work/ex/clippy-test-run/sources/stable/gh/Aehmlo/deoxy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Aehmlo/deoxy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Aehmlo/deoxy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aehmlo/deoxy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aehmlo/deoxy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3b9d19d30b288f81fae765fd109da9999ccbf723 [INFO] sha for GitHub repo Aehmlo/deoxy: 3b9d19d30b288f81fae765fd109da9999ccbf723 [INFO] validating manifest of Aehmlo/deoxy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Aehmlo/deoxy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Aehmlo/deoxy [INFO] finished frobbing Aehmlo/deoxy [INFO] frobbed toml for Aehmlo/deoxy written to work/ex/clippy-test-run/sources/stable/gh/Aehmlo/deoxy/Cargo.toml [INFO] started frobbing Aehmlo/deoxy [INFO] finished frobbing Aehmlo/deoxy [INFO] frobbed toml for Aehmlo/deoxy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aehmlo/deoxy/Cargo.toml [INFO] crate Aehmlo/deoxy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Aehmlo/deoxy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Aehmlo/deoxy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f63e7111e2698a31d1ebeaf03ca04181ba2bf9ea9336e1e6cc3c55f79d8cbf5 [INFO] running `"docker" "start" "-a" "9f63e7111e2698a31d1ebeaf03ca04181ba2bf9ea9336e1e6cc3c55f79d8cbf5"` [INFO] [stderr] Checking gpio v0.3.0 [INFO] [stderr] Checking backtrace-sys v0.1.23 [INFO] [stderr] Checking backtrace v0.3.8 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking deoxy v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/communication.rs:159:48 [INFO] [stderr] | [INFO] [stderr] 159 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `angle::Angle` [INFO] [stderr] --> src/lib.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | use angle::Angle; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:38:44 [INFO] [stderr] | [INFO] [stderr] 38 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/communication.rs:159:48 [INFO] [stderr] | [INFO] [stderr] 159 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/communication.rs:159:48 [INFO] [stderr] | [INFO] [stderr] 159 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `angle::Angle` [INFO] [stderr] --> src/lib.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | use angle::Angle; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:38:44 [INFO] [stderr] | [INFO] [stderr] 38 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/communication.rs:159:48 [INFO] [stderr] | [INFO] [stderr] 159 | #[cfg_attr(feature = "cargo-clippy", allow(needless_pass_by_value))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/communication.rs:105:39 [INFO] [stderr] | [INFO] [stderr] 105 | is_blocking: Arc::new(Mutex::new(false)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/communication.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | action.0 = action.0 + delta; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `action.0 += delta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/communication.rs:318:37 [INFO] [stderr] | [INFO] [stderr] 318 | let pump_is_free = Arc::new(Mutex::new(true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/communication.rs:105:39 [INFO] [stderr] | [INFO] [stderr] 105 | is_blocking: Arc::new(Mutex::new(false)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/communication.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | action.0 = action.0 + delta; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `action.0 += delta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/motion.rs:130:21 [INFO] [stderr] | [INFO] [stderr] 130 | let width = pulse_width.lock().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `pulse_width.lock().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/communication.rs:318:37 [INFO] [stderr] | [INFO] [stderr] 318 | let pump_is_free = Arc::new(Mutex::new(true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/motion.rs:130:21 [INFO] [stderr] | [INFO] [stderr] 130 | let width = pulse_width.lock().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `pulse_width.lock().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.38s [INFO] running `"docker" "inspect" "9f63e7111e2698a31d1ebeaf03ca04181ba2bf9ea9336e1e6cc3c55f79d8cbf5"` [INFO] running `"docker" "rm" "-f" "9f63e7111e2698a31d1ebeaf03ca04181ba2bf9ea9336e1e6cc3c55f79d8cbf5"` [INFO] [stdout] 9f63e7111e2698a31d1ebeaf03ca04181ba2bf9ea9336e1e6cc3c55f79d8cbf5