[INFO] updating cached repository Aehmlo/advent-of-code [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Aehmlo/advent-of-code [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Aehmlo/advent-of-code" "work/ex/clippy-test-run/sources/stable/gh/Aehmlo/advent-of-code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Aehmlo/advent-of-code'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Aehmlo/advent-of-code" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aehmlo/advent-of-code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aehmlo/advent-of-code'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7141827310f9c78db020085ce1f172724c5626ab [INFO] sha for GitHub repo Aehmlo/advent-of-code: 7141827310f9c78db020085ce1f172724c5626ab [INFO] validating manifest of Aehmlo/advent-of-code on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Aehmlo/advent-of-code on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Aehmlo/advent-of-code [INFO] finished frobbing Aehmlo/advent-of-code [INFO] frobbed toml for Aehmlo/advent-of-code written to work/ex/clippy-test-run/sources/stable/gh/Aehmlo/advent-of-code/Cargo.toml [INFO] started frobbing Aehmlo/advent-of-code [INFO] finished frobbing Aehmlo/advent-of-code [INFO] frobbed toml for Aehmlo/advent-of-code written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aehmlo/advent-of-code/Cargo.toml [INFO] crate Aehmlo/advent-of-code has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Aehmlo/advent-of-code against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Aehmlo/advent-of-code:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 38bbc160ff46b70e3c3b210ca573c3cc534714d9508c6a3b8dc9e103bdecb8b4 [INFO] running `"docker" "start" "-a" "38bbc160ff46b70e3c3b210ca573c3cc534714d9508c6a3b8dc9e103bdecb8b4"` [INFO] [stderr] Checking advent-of-code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fourteen.rs:123:42 [INFO] [stderr] | [INFO] [stderr] 123 | assert_eq!(after(&mut board, 9), 5158916779); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `5_158_916_779` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/fourteen.rs:125:42 [INFO] [stderr] | [INFO] [stderr] 125 | assert_eq!(after(&mut board, 5), 0124515891); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 125 | assert_eq!(after(&mut board, 5), 124515891); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 125 | assert_eq!(after(&mut board, 5), 0o124515891); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fourteen.rs:125:42 [INFO] [stderr] | [INFO] [stderr] 125 | assert_eq!(after(&mut board, 5), 0124515891); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0_124_515_891` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fourteen.rs:127:43 [INFO] [stderr] | [INFO] [stderr] 127 | assert_eq!(after(&mut board, 18), 9251071085); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `9_251_071_085` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fourteen.rs:129:45 [INFO] [stderr] | [INFO] [stderr] 129 | assert_eq!(after(&mut board, 2018), 5941429882); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `5_941_429_882` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `grid` [INFO] [stderr] --> src/eleven.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | for j in 0..AXIS { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 28 | for (j, ) in grid.iter_mut().enumerate().take(AXIS) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `grid` [INFO] [stderr] --> src/eleven.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | for j in 0..AXIS { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 28 | for (j, ) in grid.iter_mut().enumerate().take(AXIS) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is used to index `new` [INFO] [stderr] --> src/twelve.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | for index in 2..(self.pots.len() - 2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 55 | for (index, ) in new.iter_mut().enumerate().take((self.pots.len() - 2)).skip(2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/four.rs:132:31 [INFO] [stderr] | [INFO] [stderr] 132 | assert_eq!(sleepy.0 * sleepy.1 as u16, 240); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(sleepy.1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/four.rs:134:35 [INFO] [stderr] | [INFO] [stderr] 134 | assert_eq!(consistent.0 * consistent.1 as u16, 4455); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(consistent.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/one.rs:59:34 [INFO] [stderr] | [INFO] [stderr] 59 | let parsed = input.split("\n").filter_map(|v| v.parse::().ok()); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/one.rs:70:34 [INFO] [stderr] | [INFO] [stderr] 70 | let parsed = input.split("\n").filter_map(|v| v.parse::().ok()); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `index` is used to index `new` [INFO] [stderr] --> src/twelve.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | for index in 2..(self.pots.len() - 2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 55 | for (index, ) in new.iter_mut().enumerate().take((self.pots.len() - 2)).skip(2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.65s [INFO] running `"docker" "inspect" "38bbc160ff46b70e3c3b210ca573c3cc534714d9508c6a3b8dc9e103bdecb8b4"` [INFO] running `"docker" "rm" "-f" "38bbc160ff46b70e3c3b210ca573c3cc534714d9508c6a3b8dc9e103bdecb8b4"` [INFO] [stdout] 38bbc160ff46b70e3c3b210ca573c3cc534714d9508c6a3b8dc9e103bdecb8b4