[INFO] updating cached repository AdrienneCohea/countermeasurely [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AdrienneCohea/countermeasurely [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AdrienneCohea/countermeasurely" "work/ex/clippy-test-run/sources/stable/gh/AdrienneCohea/countermeasurely"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AdrienneCohea/countermeasurely'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AdrienneCohea/countermeasurely" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AdrienneCohea/countermeasurely"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AdrienneCohea/countermeasurely'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 92c4ea65f355d8dc6d6f964755d68e7cf9e52780 [INFO] sha for GitHub repo AdrienneCohea/countermeasurely: 92c4ea65f355d8dc6d6f964755d68e7cf9e52780 [INFO] validating manifest of AdrienneCohea/countermeasurely on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AdrienneCohea/countermeasurely on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AdrienneCohea/countermeasurely [INFO] finished frobbing AdrienneCohea/countermeasurely [INFO] frobbed toml for AdrienneCohea/countermeasurely written to work/ex/clippy-test-run/sources/stable/gh/AdrienneCohea/countermeasurely/Cargo.toml [INFO] started frobbing AdrienneCohea/countermeasurely [INFO] finished frobbing AdrienneCohea/countermeasurely [INFO] frobbed toml for AdrienneCohea/countermeasurely written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AdrienneCohea/countermeasurely/Cargo.toml [INFO] crate AdrienneCohea/countermeasurely has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AdrienneCohea/countermeasurely against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AdrienneCohea/countermeasurely:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98ea071579eea8f9d4103ebb850f4c928fee800f0e6ad1162687608099d37808 [INFO] running `"docker" "start" "-a" "98ea071579eea8f9d4103ebb850f4c928fee800f0e6ad1162687608099d37808"` [INFO] [stderr] Compiling openssl v0.9.23 [INFO] [stderr] Checking tokio-core v0.1.11 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.9 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking countermeasurely v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / match query { [INFO] [stderr] 20 | | Some(value) => { [INFO] [stderr] 21 | | let tokens: Vec<&str> = value.split('&').collect(); [INFO] [stderr] 22 | | for token in tokens { [INFO] [stderr] ... | [INFO] [stderr] 29 | | None => () [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | if let Some(value) = query { [INFO] [stderr] 20 | let tokens: Vec<&str> = value.split('&').collect(); [INFO] [stderr] 21 | for token in tokens { [INFO] [stderr] 22 | let pair: Vec<&str> = token.split('=').collect(); [INFO] [stderr] 23 | if pair.len() == 2 { [INFO] [stderr] 24 | result.insert(String::from(pair[0]), String::from(pair[1])); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:42:8 [INFO] [stderr] | [INFO] [stderr] 42 | if params.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / match uri.scheme() { [INFO] [stderr] 60 | | Some(scheme) => { [INFO] [stderr] 61 | | temp.push_str(scheme); [INFO] [stderr] 62 | | temp.push_str("://"); [INFO] [stderr] 63 | | }, [INFO] [stderr] 64 | | None => () [INFO] [stderr] 65 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | if let Some(scheme) = uri.scheme() { [INFO] [stderr] 60 | temp.push_str(scheme); [INFO] [stderr] 61 | temp.push_str("://"); [INFO] [stderr] 62 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / match uri.authority() { [INFO] [stderr] 68 | | Some(authority) => temp.push_str(authority), [INFO] [stderr] 69 | | None => () [INFO] [stderr] 70 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(authority) = uri.authority() { temp.push_str(authority) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / match query { [INFO] [stderr] 20 | | Some(value) => { [INFO] [stderr] 21 | | let tokens: Vec<&str> = value.split('&').collect(); [INFO] [stderr] 22 | | for token in tokens { [INFO] [stderr] ... | [INFO] [stderr] 29 | | None => () [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | if let Some(value) = query { [INFO] [stderr] 20 | let tokens: Vec<&str> = value.split('&').collect(); [INFO] [stderr] 21 | for token in tokens { [INFO] [stderr] 22 | let pair: Vec<&str> = token.split('=').collect(); [INFO] [stderr] 23 | if pair.len() == 2 { [INFO] [stderr] 24 | result.insert(String::from(pair[0]), String::from(pair[1])); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:42:8 [INFO] [stderr] | [INFO] [stderr] 42 | if params.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / match uri.scheme() { [INFO] [stderr] 60 | | Some(scheme) => { [INFO] [stderr] 61 | | temp.push_str(scheme); [INFO] [stderr] 62 | | temp.push_str("://"); [INFO] [stderr] 63 | | }, [INFO] [stderr] 64 | | None => () [INFO] [stderr] 65 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | if let Some(scheme) = uri.scheme() { [INFO] [stderr] 60 | temp.push_str(scheme); [INFO] [stderr] 61 | temp.push_str("://"); [INFO] [stderr] 62 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / match uri.authority() { [INFO] [stderr] 68 | | Some(authority) => temp.push_str(authority), [INFO] [stderr] 69 | | None => () [INFO] [stderr] 70 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Some(authority) = uri.authority() { temp.push_str(authority) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.04s [INFO] running `"docker" "inspect" "98ea071579eea8f9d4103ebb850f4c928fee800f0e6ad1162687608099d37808"` [INFO] running `"docker" "rm" "-f" "98ea071579eea8f9d4103ebb850f4c928fee800f0e6ad1162687608099d37808"` [INFO] [stdout] 98ea071579eea8f9d4103ebb850f4c928fee800f0e6ad1162687608099d37808