[INFO] updating cached repository AdrienPensart/rtarot
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/AdrienPensart/rtarot
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/AdrienPensart/rtarot" "work/ex/clippy-test-run/sources/stable/gh/AdrienPensart/rtarot"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AdrienPensart/rtarot'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/AdrienPensart/rtarot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AdrienPensart/rtarot"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AdrienPensart/rtarot'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b57295290848058db3ba03d542e5bbd2070bcd87
[INFO] sha for GitHub repo AdrienPensart/rtarot: b57295290848058db3ba03d542e5bbd2070bcd87
[INFO] validating manifest of AdrienPensart/rtarot on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of AdrienPensart/rtarot on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing AdrienPensart/rtarot
[INFO] finished frobbing AdrienPensart/rtarot
[INFO] frobbed toml for AdrienPensart/rtarot written to work/ex/clippy-test-run/sources/stable/gh/AdrienPensart/rtarot/Cargo.toml
[INFO] started frobbing AdrienPensart/rtarot
[INFO] finished frobbing AdrienPensart/rtarot
[INFO] frobbed toml for AdrienPensart/rtarot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AdrienPensart/rtarot/Cargo.toml
[INFO] crate AdrienPensart/rtarot has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting AdrienPensart/rtarot against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AdrienPensart/rtarot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6432e38d5759a082e116b8eab21eaeb1f4e122347a49fb46b5ff685e60889be7
[INFO] running `"docker" "start" "-a" "6432e38d5759a082e116b8eab21eaeb1f4e122347a49fb46b5ff685e60889be7"`
[INFO] [stderr]    Compiling serde v1.0.60
[INFO] [stderr]     Checking clap v2.31.2
[INFO] [stderr]    Compiling serde_derive v1.0.60
[INFO] [stderr]     Checking serde_json v1.0.17
[INFO] [stderr]     Checking rtarot v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/deck.rs:137:56
[INFO] [stderr]     |
[INFO] [stderr] 137 |     assert_eq!(combinations.collect::<Vec<_>>().len(), 134596);
[INFO] [stderr]     |                                                        ^^^^^^ help: consider: `134_596`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/game.rs:84:33
[INFO] [stderr]    |
[INFO] [stderr] 84 |     assert_eq!(binomial(24, 6), 134596);
[INFO] [stderr]    |                                 ^^^^^^ help: consider: `134_596`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:33:20
[INFO] [stderr]    |
[INFO] [stderr] 33 |     pub fn master (&self, arg: Card) -> bool {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:37:24
[INFO] [stderr]    |
[INFO] [stderr] 37 |     pub fn discardable(&self) -> bool {
[INFO] [stderr]    |                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:44:31
[INFO] [stderr]    |
[INFO] [stderr] 44 |     pub fn discardable_forced(&self) -> bool {
[INFO] [stderr]    |                               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:53:19
[INFO] [stderr]    |
[INFO] [stderr] 53 |     pub fn points(&self) -> f32 {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/game.rs:71:14
[INFO] [stderr]    |
[INFO] [stderr] 71 |     for d in 1 .. k + 1 {
[INFO] [stderr]    |              ^^^^^^^^^^ help: use: `1..=k`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:33:20
[INFO] [stderr]    |
[INFO] [stderr] 33 |     pub fn master (&self, arg: Card) -> bool {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:37:24
[INFO] [stderr]    |
[INFO] [stderr] 37 |     pub fn discardable(&self) -> bool {
[INFO] [stderr]    |                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:44:31
[INFO] [stderr]    |
[INFO] [stderr] 44 |     pub fn discardable_forced(&self) -> bool {
[INFO] [stderr]    |                               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/card.rs:53:19
[INFO] [stderr]    |
[INFO] [stderr] 53 |     pub fn points(&self) -> f32 {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/card.rs:100:5
[INFO] [stderr]     |
[INFO] [stderr] 100 |     assert_eq!(pique_un.points(), 0.5);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/card.rs:100:5
[INFO] [stderr]     |
[INFO] [stderr] 100 |     assert_eq!(pique_un.points(), 0.5);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/card.rs:104:5
[INFO] [stderr]     |
[INFO] [stderr] 104 |     assert_eq!(atout_7.points(), 0.5);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/card.rs:104:5
[INFO] [stderr]     |
[INFO] [stderr] 104 |     assert_eq!(atout_7.points(), 0.5);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/card.rs:115:5
[INFO] [stderr]     |
[INFO] [stderr] 115 |     assert_eq!(_21.points(), 4.5);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/card.rs:115:5
[INFO] [stderr]     |
[INFO] [stderr] 115 |     assert_eq!(_21.points(), 4.5);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/deck.rs:77:5
[INFO] [stderr]    |
[INFO] [stderr] 77 |     assert_eq!(stack.points(), 91.0);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/deck.rs:77:5
[INFO] [stderr]    |
[INFO] [stderr] 77 |     assert_eq!(stack.points(), 91.0);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/deck.rs:80:12
[INFO] [stderr]    |
[INFO] [stderr] 80 |         if card.points() == 4.5 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(card.points() - 4.5).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/deck.rs:80:12
[INFO] [stderr]    |
[INFO] [stderr] 80 |         if card.points() == 4.5 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: avoid using `collect()` when not needed
[INFO] [stderr]    --> src/deck.rs:137:28
[INFO] [stderr]     |
[INFO] [stderr] 137 |     assert_eq!(combinations.collect::<Vec<_>>().len(), 134596);
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_collect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/game.rs:71:14
[INFO] [stderr]    |
[INFO] [stderr] 71 |     for d in 1 .. k + 1 {
[INFO] [stderr]    |              ^^^^^^^^^^ help: use: `1..=k`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 5 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rtarot`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "6432e38d5759a082e116b8eab21eaeb1f4e122347a49fb46b5ff685e60889be7"`
[INFO] running `"docker" "rm" "-f" "6432e38d5759a082e116b8eab21eaeb1f4e122347a49fb46b5ff685e60889be7"`
[INFO] [stdout] 6432e38d5759a082e116b8eab21eaeb1f4e122347a49fb46b5ff685e60889be7