[INFO] updating cached repository AdrienChampion/benchi [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AdrienChampion/benchi [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AdrienChampion/benchi" "work/ex/clippy-test-run/sources/stable/gh/AdrienChampion/benchi"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AdrienChampion/benchi'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AdrienChampion/benchi" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AdrienChampion/benchi"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AdrienChampion/benchi'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 42a95c97c7eac9a9112f92ca4f9e447e2e2d44be [INFO] sha for GitHub repo AdrienChampion/benchi: 42a95c97c7eac9a9112f92ca4f9e447e2e2d44be [INFO] validating manifest of AdrienChampion/benchi on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AdrienChampion/benchi on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AdrienChampion/benchi [INFO] finished frobbing AdrienChampion/benchi [INFO] frobbed toml for AdrienChampion/benchi written to work/ex/clippy-test-run/sources/stable/gh/AdrienChampion/benchi/Cargo.toml [INFO] started frobbing AdrienChampion/benchi [INFO] finished frobbing AdrienChampion/benchi [INFO] frobbed toml for AdrienChampion/benchi written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AdrienChampion/benchi/Cargo.toml [INFO] crate AdrienChampion/benchi has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AdrienChampion/benchi against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AdrienChampion/benchi:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 757c1a9bce487b9f6dd2ab4eb28dea9201eecc4705c11473d5dbc1a62efd4071 [INFO] running `"docker" "start" "-a" "757c1a9bce487b9f6dd2ab4eb28dea9201eecc4705c11473d5dbc1a62efd4071"` [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking benchi v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/common/mod.rs:180:7 [INFO] [stderr] | [INFO] [stderr] 180 | / write!( [INFO] [stderr] 181 | | w, "# success: {}, {}, {}\n", [INFO] [stderr] 182 | | code, info.alias, info.desc [INFO] [stderr] 183 | | ).chain_err( [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/run/mod.rs:439:15 [INFO] [stderr] | [INFO] [stderr] 439 | println!("") ; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/run/mod.rs:444:15 [INFO] [stderr] | [INFO] [stderr] 444 | println!("") ; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/run/mod.rs:532:17 [INFO] [stderr] | [INFO] [stderr] 532 | println!("") ; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/run/mod.rs:534:17 [INFO] [stderr] | [INFO] [stderr] 534 | println!("") [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:108:7 [INFO] [stderr] | [INFO] [stderr] 108 | println!("") ; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | println!("") ; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/common/mod.rs:180:7 [INFO] [stderr] | [INFO] [stderr] 180 | / write!( [INFO] [stderr] 181 | | w, "# success: {}, {}, {}\n", [INFO] [stderr] 182 | | code, info.alias, info.desc [INFO] [stderr] 183 | | ).chain_err( [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/run/mod.rs:439:15 [INFO] [stderr] | [INFO] [stderr] 439 | println!("") ; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/run/mod.rs:444:15 [INFO] [stderr] | [INFO] [stderr] 444 | println!("") ; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/run/mod.rs:532:17 [INFO] [stderr] | [INFO] [stderr] 532 | println!("") ; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/run/mod.rs:534:17 [INFO] [stderr] | [INFO] [stderr] 534 | println!("") [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:108:7 [INFO] [stderr] | [INFO] [stderr] 108 | println!("") ; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | println!("") ; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/clap.rs:366:10 [INFO] [stderr] | [INFO] [stderr] 366 | } else { [INFO] [stderr] | __________^ [INFO] [stderr] 367 | | if matches.occurs("quiet") { [INFO] [stderr] 368 | | Verb::Quiet [INFO] [stderr] 369 | | } else if matches.occurs("verbose") { [INFO] [stderr] ... | [INFO] [stderr] 373 | | } [INFO] [stderr] 374 | | } ; [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 366 | } else if matches.occurs("quiet") { [INFO] [stderr] 367 | Verb::Quiet [INFO] [stderr] 368 | } else if matches.occurs("verbose") { [INFO] [stderr] 369 | Verb::Verbose [INFO] [stderr] 370 | } else { [INFO] [stderr] 371 | Verb::Normal [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/run/mod.rs:237:7 [INFO] [stderr] | [INFO] [stderr] 237 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/run/mod.rs:364:7 [INFO] [stderr] | [INFO] [stderr] 364 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/plot/cumul.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/plot/cumul.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/clap.rs:366:10 [INFO] [stderr] | [INFO] [stderr] 366 | } else { [INFO] [stderr] | __________^ [INFO] [stderr] 367 | | if matches.occurs("quiet") { [INFO] [stderr] 368 | | Verb::Quiet [INFO] [stderr] 369 | | } else if matches.occurs("verbose") { [INFO] [stderr] ... | [INFO] [stderr] 373 | | } [INFO] [stderr] 374 | | } ; [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 366 | } else if matches.occurs("quiet") { [INFO] [stderr] 367 | Verb::Quiet [INFO] [stderr] 368 | } else if matches.occurs("verbose") { [INFO] [stderr] 369 | Verb::Verbose [INFO] [stderr] 370 | } else { [INFO] [stderr] 371 | Verb::Normal [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/run/mod.rs:237:7 [INFO] [stderr] | [INFO] [stderr] 237 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/run/mod.rs:364:7 [INFO] [stderr] | [INFO] [stderr] 364 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/plot/cumul.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/plot/cumul.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/common/res.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / match * self { [INFO] [stderr] 23 | | BenchRes::Success(_, ref mut opt) => * opt = Some(code), [INFO] [stderr] 24 | | _ => (), [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ help: try this: `if let BenchRes::Success(_, ref mut opt) = * self { * opt = Some(code) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/common/res.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | for (_, res) in & res { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 89 | for res in res.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/common/res.rs:116:21 [INFO] [stderr] | [INFO] [stderr] 116 | for (_, res) in & self.res { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 116 | for res in self.res.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/common/res.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | / match self.benchs.get(& bench) { [INFO] [stderr] 268 | | Some(bench_name) => if name == * bench_name { [INFO] [stderr] 269 | | return Ok(()) [INFO] [stderr] 270 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 280 | | None => () [INFO] [stderr] 281 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 267 | if let Some(bench_name) = self.benchs.get(& bench) { if name == * bench_name { [INFO] [stderr] 268 | return Ok(()) [INFO] [stderr] 269 | } else { [INFO] [stderr] 270 | let e: Res<()> = Err( [INFO] [stderr] 271 | format!( [INFO] [stderr] 272 | "but was previously seen as `{}`", bench_name [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/common/res.rs:398:14 [INFO] [stderr] | [INFO] [stderr] 398 | } else if let & mut Some((ref mut file, ref path)) = unknown { [INFO] [stderr] | ______________^ [INFO] [stderr] 399 | | Ok((file, path)) [INFO] [stderr] 400 | | } else { [INFO] [stderr] 401 | | * unknown = Some( Self::data_file_of(conf, Some("err_or_tmo")) ? ) ; [INFO] [stderr] 402 | | let file_n_path = unknown.as_mut().unwrap() ; [INFO] [stderr] 403 | | Ok( (& mut file_n_path.0, & file_n_path.1) ) [INFO] [stderr] 404 | | }, [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 398 | } else if let Some((ref mut file, ref path)) = *unknown { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/common/run.rs:42:3 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn mk( [INFO] [stderr] 43 | | bench_par: usize, tool_par: usize, [INFO] [stderr] 44 | | timeout: Duration, try: Option, log_stdout: bool, [INFO] [stderr] 45 | | out_dir: String, tool_file: String, bench_file: String, [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/common/run.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / if tool.validator.is_none() { [INFO] [stderr] 60 | | None [INFO] [stderr] 61 | | } else { [INFO] [stderr] 62 | | let mut path = PathBuf::from(& self.out_dir) ; [INFO] [stderr] ... | [INFO] [stderr] 66 | | Some(path) [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ help: replace_it_with: `tool.validator?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/common/plot.rs:33:3 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn mk( [INFO] [stderr] 34 | | file: String, gnuplot: bool, then: Option, [INFO] [stderr] 35 | | fmt: PlotFmt, title: bool, [INFO] [stderr] 36 | | no_errors: bool, errs_as_tmos: bool, merge: bool, [INFO] [stderr] ... | [INFO] [stderr] 82 | | ) [INFO] [stderr] 83 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/common/plot.rs:131:14 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn ext(& self) -> & 'static str { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/common/plot.rs:140:15 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn term(& self) -> & 'static str { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/common/plot.rs:158:23 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn compare_term(& self) -> & 'static str { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/common/plot.rs:198:12 [INFO] [stderr] | [INFO] [stderr] 198 | if let None = PlotFmt::of_str(& s) { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 199 | | Err( format!("expected `{}`, got `{}`", Self::values(), s) ) [INFO] [stderr] 200 | | } else { [INFO] [stderr] 201 | | Ok(()) [INFO] [stderr] 202 | | } [INFO] [stderr] | |_____- help: try this: `if PlotFmt::of_str(& s).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/common/mod.rs:201:33 [INFO] [stderr] | [INFO] [stderr] 201 | fn check_succ(& self, status: & ExitStatus) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `ExitStatus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `styles` which has no body [INFO] [stderr] --> src/common/mod.rs:241:3 [INFO] [stderr] | [INFO] [stderr] 241 | #[inline] [INFO] [stderr] | ___-^^^^^^^^ [INFO] [stderr] 242 | | fn styles(& self) -> & Styles ; [INFO] [stderr] | |__- help: remove [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::inline_fn_without_body)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `verb` which has no body [INFO] [stderr] --> src/common/mod.rs:308:3 [INFO] [stderr] | [INFO] [stderr] 308 | #[inline] [INFO] [stderr] | ___-^^^^^^^^ [INFO] [stderr] 309 | | fn verb(& self) -> & Verb ; [INFO] [stderr] | |__- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `gconf` which has no body [INFO] [stderr] --> src/common/mod.rs:382:3 [INFO] [stderr] | [INFO] [stderr] 382 | #[inline] [INFO] [stderr] | ___-^^^^^^^^ [INFO] [stderr] 383 | | fn gconf(& self) -> & GConf ; [INFO] [stderr] | |__- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/common/mod.rs:789:14 [INFO] [stderr] | [INFO] [stderr] 789 | || format!("could chmod validator file to executable") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"could chmod validator file to executable".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/common/mod.rs:835:49 [INFO] [stderr] | [INFO] [stderr] 835 | tool: ToolIndex, bench: BenchIndex, status: & ExitStatus [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `ExitStatus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/common/mod.rs:859:13 [INFO] [stderr] | [INFO] [stderr] 859 | ).map(|s| Some(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/common/mod.rs:892:3 [INFO] [stderr] | [INFO] [stderr] 892 | / pub fn into_iter(self) -> ::std::vec::IntoIter { [INFO] [stderr] 893 | | self.vec.into_iter() [INFO] [stderr] 894 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/common/res.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / match * self { [INFO] [stderr] 23 | | BenchRes::Success(_, ref mut opt) => * opt = Some(code), [INFO] [stderr] 24 | | _ => (), [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ help: try this: `if let BenchRes::Success(_, ref mut opt) = * self { * opt = Some(code) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `as_sec_str` which has no body [INFO] [stderr] --> src/common/mod.rs:936:3 [INFO] [stderr] | [INFO] [stderr] 936 | #[inline] [INFO] [stderr] | ___-^^^^^^^^ [INFO] [stderr] 937 | | fn as_sec_str(& self) -> String ; [INFO] [stderr] | |__- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/common/res.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | for (_, res) in & res { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 89 | for res in res.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/common/res.rs:116:21 [INFO] [stderr] | [INFO] [stderr] 116 | for (_, res) in & self.res { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 116 | for res in self.res.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/common/res.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | / match self.benchs.get(& bench) { [INFO] [stderr] 268 | | Some(bench_name) => if name == * bench_name { [INFO] [stderr] 269 | | return Ok(()) [INFO] [stderr] 270 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 280 | | None => () [INFO] [stderr] 281 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 267 | if let Some(bench_name) = self.benchs.get(& bench) { if name == * bench_name { [INFO] [stderr] 268 | return Ok(()) [INFO] [stderr] 269 | } else { [INFO] [stderr] 270 | let e: Res<()> = Err( [INFO] [stderr] 271 | format!( [INFO] [stderr] 272 | "but was previously seen as `{}`", bench_name [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/common/res.rs:398:14 [INFO] [stderr] | [INFO] [stderr] 398 | } else if let & mut Some((ref mut file, ref path)) = unknown { [INFO] [stderr] | ______________^ [INFO] [stderr] 399 | | Ok((file, path)) [INFO] [stderr] 400 | | } else { [INFO] [stderr] 401 | | * unknown = Some( Self::data_file_of(conf, Some("err_or_tmo")) ? ) ; [INFO] [stderr] 402 | | let file_n_path = unknown.as_mut().unwrap() ; [INFO] [stderr] 403 | | Ok( (& mut file_n_path.0, & file_n_path.1) ) [INFO] [stderr] 404 | | }, [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 398 | } else if let Some((ref mut file, ref path)) = *unknown { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/common/run.rs:42:3 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn mk( [INFO] [stderr] 43 | | bench_par: usize, tool_par: usize, [INFO] [stderr] 44 | | timeout: Duration, try: Option, log_stdout: bool, [INFO] [stderr] 45 | | out_dir: String, tool_file: String, bench_file: String, [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/common/run.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / if tool.validator.is_none() { [INFO] [stderr] 60 | | None [INFO] [stderr] 61 | | } else { [INFO] [stderr] 62 | | let mut path = PathBuf::from(& self.out_dir) ; [INFO] [stderr] ... | [INFO] [stderr] 66 | | Some(path) [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ help: replace_it_with: `tool.validator?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/clap.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | format!("missing time unit `s` or `min`") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"missing time unit `s` or `min`".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/clap.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | if let Ok(_) = tmo_of_str(& s) { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 84 | | Ok(()) [INFO] [stderr] 85 | | } else { [INFO] [stderr] 86 | | Err( [INFO] [stderr] 87 | | format!("expected <{}>, got `{}`", ::consts::clap::tmo_format, s) [INFO] [stderr] 88 | | ) [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____- help: try this: `if tmo_of_str(& s).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/clap.rs:103:12 [INFO] [stderr] | [INFO] [stderr] 103 | if let Some(_) = bool_of_str(& s) { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 104 | | Ok(()) [INFO] [stderr] 105 | | } else { [INFO] [stderr] 106 | | Err( [INFO] [stderr] 107 | | format!("expected `on/true` or `off/false`, got `{}`", s) [INFO] [stderr] 108 | | ) [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____- help: try this: `if bool_of_str(& s).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/common/plot.rs:33:3 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn mk( [INFO] [stderr] 34 | | file: String, gnuplot: bool, then: Option, [INFO] [stderr] 35 | | fmt: PlotFmt, title: bool, [INFO] [stderr] 36 | | no_errors: bool, errs_as_tmos: bool, merge: bool, [INFO] [stderr] ... | [INFO] [stderr] 82 | | ) [INFO] [stderr] 83 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/common/plot.rs:131:14 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn ext(& self) -> & 'static str { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/common/plot.rs:140:15 [INFO] [stderr] | [INFO] [stderr] 140 | pub fn term(& self) -> & 'static str { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/common/plot.rs:158:23 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn compare_term(& self) -> & 'static str { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/common/plot.rs:198:12 [INFO] [stderr] | [INFO] [stderr] 198 | if let None = PlotFmt::of_str(& s) { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 199 | | Err( format!("expected `{}`, got `{}`", Self::values(), s) ) [INFO] [stderr] 200 | | } else { [INFO] [stderr] 201 | | Ok(()) [INFO] [stderr] 202 | | } [INFO] [stderr] | |_____- help: try this: `if PlotFmt::of_str(& s).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/parse.rs:90:12 [INFO] [stderr] | [INFO] [stderr] 90 | if let Some(_) = self.cmd { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 91 | | bail!( [INFO] [stderr] 92 | | format!( [INFO] [stderr] 93 | | "trying to set the command for {} twice", self.name [INFO] [stderr] ... | [INFO] [stderr] 98 | | Ok(()) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____- help: try this: `if self.cmd.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/parse.rs:103:12 [INFO] [stderr] | [INFO] [stderr] 103 | if let Some(_) = self.validator { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 104 | | bail!( [INFO] [stderr] 105 | | format!( [INFO] [stderr] 106 | | "trying to set the validator for {} twice", self.name [INFO] [stderr] ... | [INFO] [stderr] 111 | | Ok(()) [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____- help: try this: `if self.validator.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/parse.rs:116:18 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn to_conf(self) -> Res { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/common/mod.rs:201:33 [INFO] [stderr] | [INFO] [stderr] 201 | fn check_succ(& self, status: & ExitStatus) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `ExitStatus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `styles` which has no body [INFO] [stderr] --> src/common/mod.rs:241:3 [INFO] [stderr] | [INFO] [stderr] 241 | #[inline] [INFO] [stderr] | ___-^^^^^^^^ [INFO] [stderr] 242 | | fn styles(& self) -> & Styles ; [INFO] [stderr] | |__- help: remove [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::inline_fn_without_body)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `verb` which has no body [INFO] [stderr] --> src/common/mod.rs:308:3 [INFO] [stderr] | [INFO] [stderr] 308 | #[inline] [INFO] [stderr] | ___-^^^^^^^^ [INFO] [stderr] 309 | | fn verb(& self) -> & Verb ; [INFO] [stderr] | |__- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `gconf` which has no body [INFO] [stderr] --> src/common/mod.rs:382:3 [INFO] [stderr] | [INFO] [stderr] 382 | #[inline] [INFO] [stderr] | ___-^^^^^^^^ [INFO] [stderr] 383 | | fn gconf(& self) -> & GConf ; [INFO] [stderr] | |__- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parse.rs:318:12 [INFO] [stderr] | [INFO] [stderr] 318 | || format!("non utf8 string during signed int parsing") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"non utf8 string during signed int parsing".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 55 [INFO] [stderr] --> src/parse.rs:337:1 [INFO] [stderr] | [INFO] [stderr] 337 | / fn validator_conf(bytes: & [u8]) -> IResult< & [u8], Res > { [INFO] [stderr] 338 | | let mut vald_conf = Ok( ValdConf::empty() ) ; [INFO] [stderr] 339 | | map!( [INFO] [stderr] 340 | | bytes, [INFO] [stderr] ... | [INFO] [stderr] 380 | | ) [INFO] [stderr] 381 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/common/mod.rs:789:14 [INFO] [stderr] | [INFO] [stderr] 789 | || format!("could chmod validator file to executable") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"could chmod validator file to executable".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/common/mod.rs:835:49 [INFO] [stderr] | [INFO] [stderr] 835 | tool: ToolIndex, bench: BenchIndex, status: & ExitStatus [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `ExitStatus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/common/mod.rs:859:13 [INFO] [stderr] | [INFO] [stderr] 859 | ).map(|s| Some(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/common/mod.rs:892:3 [INFO] [stderr] | [INFO] [stderr] 892 | / pub fn into_iter(self) -> ::std::vec::IntoIter { [INFO] [stderr] 893 | | self.vec.into_iter() [INFO] [stderr] 894 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `as_sec_str` which has no body [INFO] [stderr] --> src/common/mod.rs:936:3 [INFO] [stderr] | [INFO] [stderr] 936 | #[inline] [INFO] [stderr] | ___-^^^^^^^^ [INFO] [stderr] 937 | | fn as_sec_str(& self) -> String ; [INFO] [stderr] | |__- help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 63 [INFO] [stderr] --> src/parse.rs:385:1 [INFO] [stderr] | [INFO] [stderr] 385 | / fn tool_conf_field<'a, 'b>( [INFO] [stderr] 386 | | bytes: & 'a [u8], builder: & 'b mut ToolConfBuilder [INFO] [stderr] 387 | | ) -> IResult< & 'a [u8], Res<()> > { [INFO] [stderr] 388 | | alt_complete!( [INFO] [stderr] ... | [INFO] [stderr] 442 | | ) [INFO] [stderr] 443 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/clap.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | format!("missing time unit `s` or `min`") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"missing time unit `s` or `min`".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/clap.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | if let Ok(_) = tmo_of_str(& s) { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 84 | | Ok(()) [INFO] [stderr] 85 | | } else { [INFO] [stderr] 86 | | Err( [INFO] [stderr] 87 | | format!("expected <{}>, got `{}`", ::consts::clap::tmo_format, s) [INFO] [stderr] 88 | | ) [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____- help: try this: `if tmo_of_str(& s).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/clap.rs:103:12 [INFO] [stderr] | [INFO] [stderr] 103 | if let Some(_) = bool_of_str(& s) { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 104 | | Ok(()) [INFO] [stderr] 105 | | } else { [INFO] [stderr] 106 | | Err( [INFO] [stderr] 107 | | format!("expected `on/true` or `off/false`, got `{}`", s) [INFO] [stderr] 108 | | ) [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____- help: try this: `if bool_of_str(& s).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/parse.rs:475:6 [INFO] [stderr] | [INFO] [stderr] 475 | ) -> IResult< [INFO] [stderr] | ______^ [INFO] [stderr] 476 | | & 'a [u8], ( Vec, Res, Vec> ) [INFO] [stderr] 477 | | > { [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/parse.rs:473:1 [INFO] [stderr] | [INFO] [stderr] 473 | / fn tool_confs<'a>( [INFO] [stderr] 474 | | bytes: & 'a [u8] [INFO] [stderr] 475 | | ) -> IResult< [INFO] [stderr] 476 | | & 'a [u8], ( Vec, Res, Vec> ) [INFO] [stderr] ... | [INFO] [stderr] 490 | | ) [INFO] [stderr] 491 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parse.rs:488:14 [INFO] [stderr] | [INFO] [stderr] 488 | ( opts.unwrap_or(vec![]), vald_conf, vec ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parse.rs:542:7 [INFO] [stderr] | [INFO] [stderr] 542 | format!("conf file parse error: incomplete") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"conf file parse error: incomplete".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parse.rs:592:47 [INFO] [stderr] | [INFO] [stderr] 592 | map!( signed_int, |int: Res| int.map(|int| Some(int)) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/parse.rs:90:12 [INFO] [stderr] | [INFO] [stderr] 90 | if let Some(_) = self.cmd { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 91 | | bail!( [INFO] [stderr] 92 | | format!( [INFO] [stderr] 93 | | "trying to set the command for {} twice", self.name [INFO] [stderr] ... | [INFO] [stderr] 98 | | Ok(()) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____- help: try this: `if self.cmd.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/parse.rs:103:12 [INFO] [stderr] | [INFO] [stderr] 103 | if let Some(_) = self.validator { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 104 | | bail!( [INFO] [stderr] 105 | | format!( [INFO] [stderr] 106 | | "trying to set the validator for {} twice", self.name [INFO] [stderr] ... | [INFO] [stderr] 111 | | Ok(()) [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____- help: try this: `if self.validator.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/parse.rs:116:18 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn to_conf(self) -> Res { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/parse.rs:654:1 [INFO] [stderr] | [INFO] [stderr] 654 | / fn parse_dump<'a>( [INFO] [stderr] 655 | | bytes: & 'a [u8], file: String, run_res: & mut RunRes [INFO] [stderr] 656 | | ) -> IResult<& 'a [u8], Res> { [INFO] [stderr] 657 | | let mut benchs: HashMap = HashMap::new() ; [INFO] [stderr] ... | [INFO] [stderr] 713 | | ) [INFO] [stderr] 714 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parse.rs:36:35 [INFO] [stderr] | [INFO] [stderr] 36 | $p( data.as_bytes() ), Done($rest.as_bytes(), $res) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"blah"` [INFO] [stderr] ... [INFO] [stderr] 146 | / test_success!{ [INFO] [stderr] 147 | | spc_cmt "# " => () ; [INFO] [stderr] 148 | | spc_cmt " \t# " => () ; [INFO] [stderr] 149 | | spc_cmt " \t# \n " => () ; [INFO] [stderr] 150 | | spc_cmt " \t# \n blah" => "blah", () ; [INFO] [stderr] 151 | | } [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parse.rs:36:35 [INFO] [stderr] | [INFO] [stderr] 36 | $p( data.as_bytes() ), Done($rest.as_bytes(), $res) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"# pound sign"` [INFO] [stderr] ... [INFO] [stderr] 194 | / test_success!{ [INFO] [stderr] 195 | | string "blah" => "blah".to_string() ; [INFO] [stderr] 196 | | string "anything &]+)=[]![+)&[]+'\t |?^`8%~" => [INFO] [stderr] 197 | | "anything &]+)=[]![+)&[]+'\t |?^`8%~".to_string() ; [INFO] [stderr] ... | [INFO] [stderr] 211 | | "} curly brace", "anything but".to_string() ; [INFO] [stderr] 212 | | } [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parse.rs:36:35 [INFO] [stderr] | [INFO] [stderr] 36 | $p( data.as_bytes() ), Done($rest.as_bytes(), $res) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"{ curly brace"` [INFO] [stderr] ... [INFO] [stderr] 194 | / test_success!{ [INFO] [stderr] 195 | | string "blah" => "blah".to_string() ; [INFO] [stderr] 196 | | string "anything &]+)=[]![+)&[]+'\t |?^`8%~" => [INFO] [stderr] 197 | | "anything &]+)=[]![+)&[]+'\t |?^`8%~".to_string() ; [INFO] [stderr] ... | [INFO] [stderr] 211 | | "} curly brace", "anything but".to_string() ; [INFO] [stderr] 212 | | } [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parse.rs:36:35 [INFO] [stderr] | [INFO] [stderr] 36 | $p( data.as_bytes() ), Done($rest.as_bytes(), $res) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"} curly brace"` [INFO] [stderr] ... [INFO] [stderr] 194 | / test_success!{ [INFO] [stderr] 195 | | string "blah" => "blah".to_string() ; [INFO] [stderr] 196 | | string "anything &]+)=[]![+)&[]+'\t |?^`8%~" => [INFO] [stderr] 197 | | "anything &]+)=[]![+)&[]+'\t |?^`8%~".to_string() ; [INFO] [stderr] ... | [INFO] [stderr] 211 | | "} curly brace", "anything but".to_string() ; [INFO] [stderr] 212 | | } [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parse.rs:36:35 [INFO] [stderr] | [INFO] [stderr] 36 | $p( data.as_bytes() ), Done($rest.as_bytes(), $res) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"} curly brace"` [INFO] [stderr] ... [INFO] [stderr] 194 | / test_success!{ [INFO] [stderr] 195 | | string "blah" => "blah".to_string() ; [INFO] [stderr] 196 | | string "anything &]+)=[]![+)&[]+'\t |?^`8%~" => [INFO] [stderr] 197 | | "anything &]+)=[]![+)&[]+'\t |?^`8%~".to_string() ; [INFO] [stderr] ... | [INFO] [stderr] 211 | | "} curly brace", "anything but".to_string() ; [INFO] [stderr] 212 | | } [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parse.rs:738:7 [INFO] [stderr] | [INFO] [stderr] 738 | format!("dump parse error: incomplete") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"dump parse error: incomplete".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/run/utils.rs:41:35 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn bench_to_tool_channel() -> ( [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 42 | | Sender< (ToolIndex, BenchIndex) >, Receiver< (ToolIndex, BenchIndex) > [INFO] [stderr] 43 | | ) { [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/run/utils.rs:57:3 [INFO] [stderr] | [INFO] [stderr] 57 | BenchiError(Error), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 57 | BenchiError(Box), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/run/mod.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | if let Err(_) = self.bench_run.send(self.index) { [INFO] [stderr] | _______- ^^^^^^ [INFO] [stderr] 57 | | // Disconnected, can happen if we're done. (Maybe? Nothing we can [INFO] [stderr] 58 | | // do anyways.) [INFO] [stderr] 59 | | break 'work [INFO] [stderr] 60 | | } [INFO] [stderr] | |_______- help: try this: `if self.bench_run.send(self.index).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/run/mod.rs:80:18 [INFO] [stderr] | [INFO] [stderr] 80 | if let Err(_) = self.master.send( [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 80 | if self.master.send( [INFO] [stderr] 81 | RunRes { tool, bench, res } [INFO] [stderr] 82 | ).is_err() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/run/mod.rs:101:14 [INFO] [stderr] | [INFO] [stderr] 101 | assert!( kid_cmd.len() > 0 ) ; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!kid_cmd.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/run/mod.rs:251:14 [INFO] [stderr] | [INFO] [stderr] 251 | if let Err(_) = self.master.send( Ok(self.index) ) { [INFO] [stderr] | _______- ^^^^^^ [INFO] [stderr] 252 | | // Disconnected, can happen if we're done. (Maybe? Nothing we can [INFO] [stderr] 253 | | // do anyways.) [INFO] [stderr] 254 | | break 'work [INFO] [stderr] 255 | | } [INFO] [stderr] | |_______- help: try this: `if self.master.send( Ok(self.index) ).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/run/mod.rs:263:20 [INFO] [stderr] | [INFO] [stderr] 263 | if let Err(_) = self.master.send( Err(e) ) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 264 | | // Disconnected, should not happen. [INFO] [stderr] 265 | | break 'work [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____________- help: try this: `if self.master.send( Err(e) ).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/run/mod.rs:368:15 [INFO] [stderr] | [INFO] [stderr] 368 | let mut bar = ProgressBar::new( [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/run/mod.rs:367:9 [INFO] [stderr] | [INFO] [stderr] 367 | let bar = if conf.quiet() { None } else { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parse.rs:318:12 [INFO] [stderr] | [INFO] [stderr] 318 | || format!("non utf8 string during signed int parsing") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"non utf8 string during signed int parsing".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 55 [INFO] [stderr] --> src/parse.rs:337:1 [INFO] [stderr] | [INFO] [stderr] 337 | / fn validator_conf(bytes: & [u8]) -> IResult< & [u8], Res > { [INFO] [stderr] 338 | | let mut vald_conf = Ok( ValdConf::empty() ) ; [INFO] [stderr] 339 | | map!( [INFO] [stderr] 340 | | bytes, [INFO] [stderr] ... | [INFO] [stderr] 380 | | ) [INFO] [stderr] 381 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/run/mod.rs:579:11 [INFO] [stderr] | [INFO] [stderr] 579 | self.bar.as_mut().map( |b| b.tick() ) ; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(b) = self.bar.as_mut() { b.tick() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/run/mod.rs:584:11 [INFO] [stderr] | [INFO] [stderr] 584 | self.bar.as_mut().map( |b| b.tick() ) ; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(b) = self.bar.as_mut() { b.tick() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 63 [INFO] [stderr] --> src/parse.rs:385:1 [INFO] [stderr] | [INFO] [stderr] 385 | / fn tool_conf_field<'a, 'b>( [INFO] [stderr] 386 | | bytes: & 'a [u8], builder: & 'b mut ToolConfBuilder [INFO] [stderr] 387 | | ) -> IResult< & 'a [u8], Res<()> > { [INFO] [stderr] 388 | | alt_complete!( [INFO] [stderr] ... | [INFO] [stderr] 442 | | ) [INFO] [stderr] 443 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/plot/compare.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn work( [INFO] [stderr] 9 | | conf: & PlotConf, file_1: String, file_2: String [INFO] [stderr] 10 | | ) -> Res< Option > { [INFO] [stderr] 11 | | log!{ conf => " loading tool data..." } [INFO] [stderr] ... | [INFO] [stderr] 352 | | Ok( Some(output_file) ) [INFO] [stderr] 353 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/parse.rs:475:6 [INFO] [stderr] | [INFO] [stderr] 475 | ) -> IResult< [INFO] [stderr] | ______^ [INFO] [stderr] 476 | | & 'a [u8], ( Vec, Res, Vec> ) [INFO] [stderr] 477 | | > { [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/parse.rs:473:1 [INFO] [stderr] | [INFO] [stderr] 473 | / fn tool_confs<'a>( [INFO] [stderr] 474 | | bytes: & 'a [u8] [INFO] [stderr] 475 | | ) -> IResult< [INFO] [stderr] 476 | | & 'a [u8], ( Vec, Res, Vec> ) [INFO] [stderr] ... | [INFO] [stderr] 490 | | ) [INFO] [stderr] 491 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parse.rs:488:14 [INFO] [stderr] | [INFO] [stderr] 488 | ( opts.unwrap_or(vec![]), vald_conf, vec ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/plot/compare.rs:343:9 [INFO] [stderr] | [INFO] [stderr] 343 | ).unwrap_or( "notitle".into() ), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "notitle".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/plot/compare.rs:341:17 [INFO] [stderr] | [INFO] [stderr] 341 | desc, code_to_count.get(& code).map(|cnt| * cnt).unwrap_or(0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `code_to_count.get(& code).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parse.rs:542:7 [INFO] [stderr] | [INFO] [stderr] 542 | format!("conf file parse error: incomplete") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"conf file parse error: incomplete".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/main.rs:40:3 [INFO] [stderr] | [INFO] [stderr] 40 | / error_chain!{ [INFO] [stderr] 41 | | types { [INFO] [stderr] 42 | | Error, ErrorKind, ResExt, Res ; [INFO] [stderr] 43 | | } [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/main.rs:40:3 [INFO] [stderr] | [INFO] [stderr] 40 | / error_chain!{ [INFO] [stderr] 41 | | types { [INFO] [stderr] 42 | | Error, ErrorKind, ResExt, Res ; [INFO] [stderr] 43 | | } [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |___^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parse.rs:592:47 [INFO] [stderr] | [INFO] [stderr] 592 | map!( signed_int, |int: Res| int.map(|int| Some(int)) ) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/parse.rs:654:1 [INFO] [stderr] | [INFO] [stderr] 654 | / fn parse_dump<'a>( [INFO] [stderr] 655 | | bytes: & 'a [u8], file: String, run_res: & mut RunRes [INFO] [stderr] 656 | | ) -> IResult<& 'a [u8], Res> { [INFO] [stderr] 657 | | let mut benchs: HashMap = HashMap::new() ; [INFO] [stderr] ... | [INFO] [stderr] 713 | | ) [INFO] [stderr] 714 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | |file| BufReader::new(file) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BufReader::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:299:3 [INFO] [stderr] | [INFO] [stderr] 299 | / match Command::new("timeout").arg("1").arg("echo").arg("test").stdout( [INFO] [stderr] 300 | | ::std::process::Stdio::null() [INFO] [stderr] 301 | | ).stderr( [INFO] [stderr] 302 | | ::std::process::Stdio::null() [INFO] [stderr] ... | [INFO] [stderr] 312 | | _ => (), [INFO] [stderr] 313 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 299 | if let Err(_) = Command::new("timeout").arg("1").arg("echo").arg("test").stdout( [INFO] [stderr] 300 | ::std::process::Stdio::null() [INFO] [stderr] 301 | ).stderr( [INFO] [stderr] 302 | ::std::process::Stdio::null() [INFO] [stderr] 303 | ).stdin( [INFO] [stderr] 304 | ::std::process::Stdio::null() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:340:34 [INFO] [stderr] | [INFO] [stderr] 340 | "{}.{}", time.as_secs(), time.subsec_nanos() / 1_000_000u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `time.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parse.rs:738:7 [INFO] [stderr] | [INFO] [stderr] 738 | format!("dump parse error: incomplete") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"dump parse error: incomplete".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/run/utils.rs:41:35 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn bench_to_tool_channel() -> ( [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 42 | | Sender< (ToolIndex, BenchIndex) >, Receiver< (ToolIndex, BenchIndex) > [INFO] [stderr] 43 | | ) { [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/run/utils.rs:57:3 [INFO] [stderr] | [INFO] [stderr] 57 | BenchiError(Error), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 57 | BenchiError(Box), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/run/mod.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | if let Err(_) = self.bench_run.send(self.index) { [INFO] [stderr] | _______- ^^^^^^ [INFO] [stderr] 57 | | // Disconnected, can happen if we're done. (Maybe? Nothing we can [INFO] [stderr] 58 | | // do anyways.) [INFO] [stderr] 59 | | break 'work [INFO] [stderr] 60 | | } [INFO] [stderr] | |_______- help: try this: `if self.bench_run.send(self.index).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/run/mod.rs:80:18 [INFO] [stderr] | [INFO] [stderr] 80 | if let Err(_) = self.master.send( [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 80 | if self.master.send( [INFO] [stderr] 81 | RunRes { tool, bench, res } [INFO] [stderr] 82 | ).is_err() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/run/mod.rs:101:14 [INFO] [stderr] | [INFO] [stderr] 101 | assert!( kid_cmd.len() > 0 ) ; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!kid_cmd.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/run/mod.rs:251:14 [INFO] [stderr] | [INFO] [stderr] 251 | if let Err(_) = self.master.send( Ok(self.index) ) { [INFO] [stderr] | _______- ^^^^^^ [INFO] [stderr] 252 | | // Disconnected, can happen if we're done. (Maybe? Nothing we can [INFO] [stderr] 253 | | // do anyways.) [INFO] [stderr] 254 | | break 'work [INFO] [stderr] 255 | | } [INFO] [stderr] | |_______- help: try this: `if self.master.send( Ok(self.index) ).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/run/mod.rs:263:20 [INFO] [stderr] | [INFO] [stderr] 263 | if let Err(_) = self.master.send( Err(e) ) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 264 | | // Disconnected, should not happen. [INFO] [stderr] 265 | | break 'work [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____________- help: try this: `if self.master.send( Err(e) ).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/run/mod.rs:368:15 [INFO] [stderr] | [INFO] [stderr] 368 | let mut bar = ProgressBar::new( [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/run/mod.rs:367:9 [INFO] [stderr] | [INFO] [stderr] 367 | let bar = if conf.quiet() { None } else { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] error: Could not compile `benchi`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/run/mod.rs:579:11 [INFO] [stderr] | [INFO] [stderr] 579 | self.bar.as_mut().map( |b| b.tick() ) ; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(b) = self.bar.as_mut() { b.tick() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/run/mod.rs:584:11 [INFO] [stderr] | [INFO] [stderr] 584 | self.bar.as_mut().map( |b| b.tick() ) ; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(b) = self.bar.as_mut() { b.tick() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/plot/compare.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn work( [INFO] [stderr] 9 | | conf: & PlotConf, file_1: String, file_2: String [INFO] [stderr] 10 | | ) -> Res< Option > { [INFO] [stderr] 11 | | log!{ conf => " loading tool data..." } [INFO] [stderr] ... | [INFO] [stderr] 352 | | Ok( Some(output_file) ) [INFO] [stderr] 353 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/plot/compare.rs:343:9 [INFO] [stderr] | [INFO] [stderr] 343 | ).unwrap_or( "notitle".into() ), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "notitle".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/plot/compare.rs:341:17 [INFO] [stderr] | [INFO] [stderr] 341 | desc, code_to_count.get(& code).map(|cnt| * cnt).unwrap_or(0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `code_to_count.get(& code).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/main.rs:40:3 [INFO] [stderr] | [INFO] [stderr] 40 | / error_chain!{ [INFO] [stderr] 41 | | types { [INFO] [stderr] 42 | | Error, ErrorKind, ResExt, Res ; [INFO] [stderr] 43 | | } [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/main.rs:40:3 [INFO] [stderr] | [INFO] [stderr] 40 | / error_chain!{ [INFO] [stderr] 41 | | types { [INFO] [stderr] 42 | | Error, ErrorKind, ResExt, Res ; [INFO] [stderr] 43 | | } [INFO] [stderr] ... | [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |___^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | |file| BufReader::new(file) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BufReader::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:299:3 [INFO] [stderr] | [INFO] [stderr] 299 | / match Command::new("timeout").arg("1").arg("echo").arg("test").stdout( [INFO] [stderr] 300 | | ::std::process::Stdio::null() [INFO] [stderr] 301 | | ).stderr( [INFO] [stderr] 302 | | ::std::process::Stdio::null() [INFO] [stderr] ... | [INFO] [stderr] 312 | | _ => (), [INFO] [stderr] 313 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 299 | if let Err(_) = Command::new("timeout").arg("1").arg("echo").arg("test").stdout( [INFO] [stderr] 300 | ::std::process::Stdio::null() [INFO] [stderr] 301 | ).stderr( [INFO] [stderr] 302 | ::std::process::Stdio::null() [INFO] [stderr] 303 | ).stdin( [INFO] [stderr] 304 | ::std::process::Stdio::null() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/main.rs:340:34 [INFO] [stderr] | [INFO] [stderr] 340 | "{}.{}", time.as_secs(), time.subsec_nanos() / 1_000_000u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `time.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `benchi`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "757c1a9bce487b9f6dd2ab4eb28dea9201eecc4705c11473d5dbc1a62efd4071"` [INFO] running `"docker" "rm" "-f" "757c1a9bce487b9f6dd2ab4eb28dea9201eecc4705c11473d5dbc1a62efd4071"` [INFO] [stdout] 757c1a9bce487b9f6dd2ab4eb28dea9201eecc4705c11473d5dbc1a62efd4071