[INFO] updating cached repository AdrianDanis/rust-hanoi [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AdrianDanis/rust-hanoi [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AdrianDanis/rust-hanoi" "work/ex/clippy-test-run/sources/stable/gh/AdrianDanis/rust-hanoi"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AdrianDanis/rust-hanoi'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AdrianDanis/rust-hanoi" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AdrianDanis/rust-hanoi"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AdrianDanis/rust-hanoi'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c7d160d89e2d156ecbe670cc29ca16dcb5dfbbe1 [INFO] sha for GitHub repo AdrianDanis/rust-hanoi: c7d160d89e2d156ecbe670cc29ca16dcb5dfbbe1 [INFO] validating manifest of AdrianDanis/rust-hanoi on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AdrianDanis/rust-hanoi on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AdrianDanis/rust-hanoi [INFO] finished frobbing AdrianDanis/rust-hanoi [INFO] frobbed toml for AdrianDanis/rust-hanoi written to work/ex/clippy-test-run/sources/stable/gh/AdrianDanis/rust-hanoi/Cargo.toml [INFO] started frobbing AdrianDanis/rust-hanoi [INFO] finished frobbing AdrianDanis/rust-hanoi [INFO] frobbed toml for AdrianDanis/rust-hanoi written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AdrianDanis/rust-hanoi/Cargo.toml [INFO] crate AdrianDanis/rust-hanoi has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AdrianDanis/rust-hanoi against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AdrianDanis/rust-hanoi:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4309f399c824fcbcf771dcfefb7dd62eeaac1ac58c9a3df2b0900c3001b40e9a [INFO] running `"docker" "start" "-a" "4309f399c824fcbcf771dcfefb7dd62eeaac1ac58c9a3df2b0900c3001b40e9a"` [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Checking grid_2d v0.7.0 [INFO] [stderr] Checking ansi_colour v0.4.0 [INFO] [stderr] Checking prototty v0.17.1 [INFO] [stderr] Checking prototty_grid v0.17.1 [INFO] [stderr] Checking prototty_common v0.17.1 [INFO] [stderr] Checking prototty_unix v0.17.2 [INFO] [stderr] Checking hanoi v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hanoi.rs:79:44 [INFO] [stderr] | [INFO] [stderr] 79 | Ok(GameState { start_stack: start, num_pieces: num_pieces, pieces: pieces, num_stacks: num_stacks }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_pieces` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hanoi.rs:79:68 [INFO] [stderr] | [INFO] [stderr] 79 | Ok(GameState { start_stack: start, num_pieces: num_pieces, pieces: pieces, num_stacks: num_stacks }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pieces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hanoi.rs:79:84 [INFO] [stderr] | [INFO] [stderr] 79 | Ok(GameState { start_stack: start, num_pieces: num_pieces, pieces: pieces, num_stacks: num_stacks }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_stacks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hanoi.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:133:37 [INFO] [stderr] | [INFO] [stderr] 133 | context.render(&mut HanoiView { scale: scale}, &game).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:167:41 [INFO] [stderr] | [INFO] [stderr] 167 | context.render(&mut HanoiView { scale: scale}, &game).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hanoi.rs:79:44 [INFO] [stderr] | [INFO] [stderr] 79 | Ok(GameState { start_stack: start, num_pieces: num_pieces, pieces: pieces, num_stacks: num_stacks }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_pieces` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hanoi.rs:79:68 [INFO] [stderr] | [INFO] [stderr] 79 | Ok(GameState { start_stack: start, num_pieces: num_pieces, pieces: pieces, num_stacks: num_stacks }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pieces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hanoi.rs:79:84 [INFO] [stderr] | [INFO] [stderr] 79 | Ok(GameState { start_stack: start, num_pieces: num_pieces, pieces: pieces, num_stacks: num_stacks }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_stacks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hanoi.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | num: num, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:133:37 [INFO] [stderr] | [INFO] [stderr] 133 | context.render(&mut HanoiView { scale: scale}, &game).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:167:41 [INFO] [stderr] | [INFO] [stderr] 167 | context.render(&mut HanoiView { scale: scale}, &game).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | game.interact.hand_column = game.interact.hand_column - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game.interact.hand_column -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | game.interact.hand_column = game.interact.hand_column + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game.interact.hand_column += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | game.interact.hand_column = game.interact.hand_column - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game.interact.hand_column -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | game.interact.hand_column = game.interact.hand_column + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game.interact.hand_column += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.52s [INFO] running `"docker" "inspect" "4309f399c824fcbcf771dcfefb7dd62eeaac1ac58c9a3df2b0900c3001b40e9a"` [INFO] running `"docker" "rm" "-f" "4309f399c824fcbcf771dcfefb7dd62eeaac1ac58c9a3df2b0900c3001b40e9a"` [INFO] [stdout] 4309f399c824fcbcf771dcfefb7dd62eeaac1ac58c9a3df2b0900c3001b40e9a