[INFO] updating cached repository Adam-Gleave/multiboot2-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Adam-Gleave/multiboot2-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Adam-Gleave/multiboot2-rs" "work/ex/clippy-test-run/sources/stable/gh/Adam-Gleave/multiboot2-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Adam-Gleave/multiboot2-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Adam-Gleave/multiboot2-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Adam-Gleave/multiboot2-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Adam-Gleave/multiboot2-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 90dc46b36665f98112fc41e57d3b5133c61db869 [INFO] sha for GitHub repo Adam-Gleave/multiboot2-rs: 90dc46b36665f98112fc41e57d3b5133c61db869 [INFO] validating manifest of Adam-Gleave/multiboot2-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Adam-Gleave/multiboot2-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Adam-Gleave/multiboot2-rs [INFO] finished frobbing Adam-Gleave/multiboot2-rs [INFO] frobbed toml for Adam-Gleave/multiboot2-rs written to work/ex/clippy-test-run/sources/stable/gh/Adam-Gleave/multiboot2-rs/Cargo.toml [INFO] started frobbing Adam-Gleave/multiboot2-rs [INFO] finished frobbing Adam-Gleave/multiboot2-rs [INFO] frobbed toml for Adam-Gleave/multiboot2-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Adam-Gleave/multiboot2-rs/Cargo.toml [INFO] crate Adam-Gleave/multiboot2-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Adam-Gleave/multiboot2-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Adam-Gleave/multiboot2-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8e68e8e214d2d0a2f76932e40f97152995122fa07cc1cad856dcb181911eaa45 [INFO] running `"docker" "start" "-a" "8e68e8e214d2d0a2f76932e40f97152995122fa07cc1cad856dcb181911eaa45"` [INFO] [stderr] Checking multiboot2 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/elf_sections.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | ProcessorSpecific = 0x7000_000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0700_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/elf_sections.rs:75:2 [INFO] [stderr] | [INFO] [stderr] 75 | elf_tag [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/elf_sections.rs:71:16 [INFO] [stderr] | [INFO] [stderr] 71 | let elf_tag = ElfSectionsTag { [INFO] [stderr] | ___________________^ [INFO] [stderr] 72 | | ptr: unsafe { (tag as *const Tag).offset(1) } as *const ElfSectionsInfo, [INFO] [stderr] 73 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/basic_info.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | self.mem_lower, self.mem_upper)?; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(safe_packed_borrows)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/basic_info.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | self.mem_lower, self.mem_upper)?; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: field is never used: `tag_type` [INFO] [stderr] --> src/basic_info.rs:8:2 [INFO] [stderr] | [INFO] [stderr] 8 | tag_type: u32, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `size` [INFO] [stderr] --> src/basic_info.rs:9:2 [INFO] [stderr] | [INFO] [stderr] 9 | size: u32, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reserved` [INFO] [stderr] --> src/lib.rs:30:2 [INFO] [stderr] | [INFO] [stderr] 30 | reserved: u32, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf_sections.rs:230:3 [INFO] [stderr] | [INFO] [stderr] 230 | self.flags as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.flags)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf_sections.rs:234:3 [INFO] [stderr] | [INFO] [stderr] 234 | self.address as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf_sections.rs:238:3 [INFO] [stderr] | [INFO] [stderr] 238 | self.size as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/memory_map.rs:63:35 [INFO] [stderr] | [INFO] [stderr] 63 | last_area: (start_ptr as u64 + (self.size - self.entry_size) as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.size - self.entry_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/memory_map.rs:84:4 [INFO] [stderr] | [INFO] [stderr] 84 | self.current_area = self.current_area + (self.entry_size as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.current_area += (self.entry_size as u64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/memory_map.rs:84:44 [INFO] [stderr] | [INFO] [stderr] 84 | self.current_area = self.current_area + (self.entry_size as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.entry_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const tag::Tag` to a more-strictly-aligned pointer (`*const memory_map::MemoryMapTag`) [INFO] [stderr] --> src/lib.rs:53:26 [INFO] [stderr] | [INFO] [stderr] 53 | .map(|tag| unsafe { &*(tag as *const Tag as *const MemoryMapTag) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `multiboot2`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/elf_sections.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | ProcessorSpecific = 0x7000_000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0700_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/elf_sections.rs:75:2 [INFO] [stderr] | [INFO] [stderr] 75 | elf_tag [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/elf_sections.rs:71:16 [INFO] [stderr] | [INFO] [stderr] 71 | let elf_tag = ElfSectionsTag { [INFO] [stderr] | ___________________^ [INFO] [stderr] 72 | | ptr: unsafe { (tag as *const Tag).offset(1) } as *const ElfSectionsInfo, [INFO] [stderr] 73 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/basic_info.rs:27:4 [INFO] [stderr] | [INFO] [stderr] 27 | self.mem_lower, self.mem_upper)?; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(safe_packed_borrows)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: borrow of packed field is unsafe and requires unsafe function or block (error E0133) [INFO] [stderr] --> src/basic_info.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | self.mem_lower, self.mem_upper)?; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #46043 [INFO] [stderr] = note: fields of packed structs might be misaligned: dereferencing a misaligned pointer or even just creating a misaligned reference is undefined behavior [INFO] [stderr] [INFO] [stderr] warning: field is never used: `tag_type` [INFO] [stderr] --> src/basic_info.rs:8:2 [INFO] [stderr] | [INFO] [stderr] 8 | tag_type: u32, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `size` [INFO] [stderr] --> src/basic_info.rs:9:2 [INFO] [stderr] | [INFO] [stderr] 9 | size: u32, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `reserved` [INFO] [stderr] --> src/lib.rs:30:2 [INFO] [stderr] | [INFO] [stderr] 30 | reserved: u32, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf_sections.rs:230:3 [INFO] [stderr] | [INFO] [stderr] 230 | self.flags as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.flags)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf_sections.rs:234:3 [INFO] [stderr] | [INFO] [stderr] 234 | self.address as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.address)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf_sections.rs:238:3 [INFO] [stderr] | [INFO] [stderr] 238 | self.size as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(self.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/memory_map.rs:63:35 [INFO] [stderr] | [INFO] [stderr] 63 | last_area: (start_ptr as u64 + (self.size - self.entry_size) as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.size - self.entry_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/memory_map.rs:84:4 [INFO] [stderr] | [INFO] [stderr] 84 | self.current_area = self.current_area + (self.entry_size as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.current_area += (self.entry_size as u64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/memory_map.rs:84:44 [INFO] [stderr] | [INFO] [stderr] 84 | self.current_area = self.current_area + (self.entry_size as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.entry_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: casting from `*const tag::Tag` to a more-strictly-aligned pointer (`*const memory_map::MemoryMapTag`) [INFO] [stderr] --> src/lib.rs:53:26 [INFO] [stderr] | [INFO] [stderr] 53 | .map(|tag| unsafe { &*(tag as *const Tag as *const MemoryMapTag) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `multiboot2`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8e68e8e214d2d0a2f76932e40f97152995122fa07cc1cad856dcb181911eaa45"` [INFO] running `"docker" "rm" "-f" "8e68e8e214d2d0a2f76932e40f97152995122fa07cc1cad856dcb181911eaa45"` [INFO] [stdout] 8e68e8e214d2d0a2f76932e40f97152995122fa07cc1cad856dcb181911eaa45