[INFO] updating cached repository Aaronepower/hera [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Aaronepower/hera [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Aaronepower/hera" "work/ex/clippy-test-run/sources/stable/gh/Aaronepower/hera"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Aaronepower/hera'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Aaronepower/hera" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aaronepower/hera"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aaronepower/hera'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] afb56481268265ce43c6484d9b5748a6aaa73bac [INFO] sha for GitHub repo Aaronepower/hera: afb56481268265ce43c6484d9b5748a6aaa73bac [INFO] validating manifest of Aaronepower/hera on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Aaronepower/hera on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Aaronepower/hera [INFO] finished frobbing Aaronepower/hera [INFO] frobbed toml for Aaronepower/hera written to work/ex/clippy-test-run/sources/stable/gh/Aaronepower/hera/Cargo.toml [INFO] started frobbing Aaronepower/hera [INFO] finished frobbing Aaronepower/hera [INFO] frobbed toml for Aaronepower/hera written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aaronepower/hera/Cargo.toml [INFO] crate Aaronepower/hera has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Aaronepower/hera against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Aaronepower/hera:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a3fcd395667888f26e3fea29d2e1cfa810aa41469e53fc49e2ecee4428f6f7a4 [INFO] running `"docker" "start" "-a" "a3fcd395667888f26e3fea29d2e1cfa810aa41469e53fc49e2ecee4428f6f7a4"` [INFO] [stderr] Compiling crossbeam-utils v0.5.0 [INFO] [stderr] Compiling cmake v0.1.33 [INFO] [stderr] Compiling libz-sys v1.0.20 [INFO] [stderr] Compiling curl-sys v0.4.8 [INFO] [stderr] Compiling walkdir v2.2.5 [INFO] [stderr] Compiling aho-corasick v0.6.8 [INFO] [stderr] Compiling lock_api v0.1.3 [INFO] [stderr] Checking encoding_rs_io v0.1.2 [INFO] [stderr] Compiling crossbeam-epoch v0.5.2 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Compiling regex v1.0.5 [INFO] [stderr] Compiling serde v1.0.78 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking predicates v0.9.0 [INFO] [stderr] Compiling libssh2-sys v0.2.10 [INFO] [stderr] Compiling libgit2-sys v0.7.7 [INFO] [stderr] Checking ignore v0.4.4 [INFO] [stderr] Compiling parking_lot v0.6.4 [INFO] [stderr] Compiling crossbeam-channel v0.2.4 [INFO] [stderr] Compiling serde_json v1.0.27 [INFO] [stderr] Compiling handlebars v1.0.3 [INFO] [stderr] Checking escargot v0.3.1 [INFO] [stderr] Checking assert_cmd v0.9.1 [INFO] [stderr] Compiling tokei v8.0.1 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking hera v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/changes.rs:71:14 [INFO] [stderr] | [INFO] [stderr] 71 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/changes.rs:85:24 [INFO] [stderr] | [INFO] [stderr] 85 | let line = text.lines().skip(*line_num as usize - 1).next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | e.split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:54:36 [INFO] [stderr] | [INFO] [stderr] 54 | .unwrap_or(vec!["."]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec!["."])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/changes.rs:71:14 [INFO] [stderr] | [INFO] [stderr] 71 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/changes.rs:85:24 [INFO] [stderr] | [INFO] [stderr] 85 | let line = text.lines().skip(*line_num as usize - 1).next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | e.split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:54:36 [INFO] [stderr] | [INFO] [stderr] 54 | .unwrap_or(vec!["."]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec!["."])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 18s [INFO] running `"docker" "inspect" "a3fcd395667888f26e3fea29d2e1cfa810aa41469e53fc49e2ecee4428f6f7a4"` [INFO] running `"docker" "rm" "-f" "a3fcd395667888f26e3fea29d2e1cfa810aa41469e53fc49e2ecee4428f6f7a4"` [INFO] [stdout] a3fcd395667888f26e3fea29d2e1cfa810aa41469e53fc49e2ecee4428f6f7a4