[INFO] updating cached repository AaronLeon/eecs395-rust-hw3 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AaronLeon/eecs395-rust-hw3 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AaronLeon/eecs395-rust-hw3" "work/ex/clippy-test-run/sources/stable/gh/AaronLeon/eecs395-rust-hw3"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AaronLeon/eecs395-rust-hw3'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AaronLeon/eecs395-rust-hw3" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AaronLeon/eecs395-rust-hw3"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AaronLeon/eecs395-rust-hw3'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 21f0ed9bd269afc4a2bf568bffaff2a1dba80417 [INFO] sha for GitHub repo AaronLeon/eecs395-rust-hw3: 21f0ed9bd269afc4a2bf568bffaff2a1dba80417 [INFO] validating manifest of AaronLeon/eecs395-rust-hw3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AaronLeon/eecs395-rust-hw3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AaronLeon/eecs395-rust-hw3 [INFO] finished frobbing AaronLeon/eecs395-rust-hw3 [INFO] frobbed toml for AaronLeon/eecs395-rust-hw3 written to work/ex/clippy-test-run/sources/stable/gh/AaronLeon/eecs395-rust-hw3/Cargo.toml [INFO] started frobbing AaronLeon/eecs395-rust-hw3 [INFO] finished frobbing AaronLeon/eecs395-rust-hw3 [INFO] frobbed toml for AaronLeon/eecs395-rust-hw3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AaronLeon/eecs395-rust-hw3/Cargo.toml [INFO] crate AaronLeon/eecs395-rust-hw3 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AaronLeon/eecs395-rust-hw3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AaronLeon/eecs395-rust-hw3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eed7acef1b05c7ec4c167e5c950ed9e8caac1576d89998fc445d01d8120ff680 [INFO] running `"docker" "start" "-a" "eed7acef1b05c7ec4c167e5c950ed9e8caac1576d89998fc445d01d8120ff680"` [INFO] [stderr] Checking hw3 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | write!(writer, "{}\n", res).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | write!(writer, "{}\n", res).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/graph.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | graph [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/graph.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | let graph = Graph { [INFO] [stderr] | _____________________^ [INFO] [stderr] 11 | | nodes: HashMap::new() [INFO] [stderr] 12 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/graph.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/graph.rs:38:19 [INFO] [stderr] | [INFO] [stderr] 38 | let res = self.get_path_helper(a, b, &visited, &path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/graph.rs:47:12 [INFO] [stderr] | [INFO] [stderr] 47 | if *&a == *&b { [INFO] [stderr] | ^^^ help: try this: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/graph.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | if *&a == *&b { [INFO] [stderr] | ^^^ help: try this: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/graph.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | graph [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/graph.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | let graph = Graph { [INFO] [stderr] | _____________________^ [INFO] [stderr] 11 | | nodes: HashMap::new() [INFO] [stderr] 12 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/graph.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/graph.rs:38:19 [INFO] [stderr] | [INFO] [stderr] 38 | let res = self.get_path_helper(a, b, &visited, &path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/graph.rs:47:12 [INFO] [stderr] | [INFO] [stderr] 47 | if *&a == *&b { [INFO] [stderr] | ^^^ help: try this: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/graph.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | if *&a == *&b { [INFO] [stderr] | ^^^ help: try this: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:16:38 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn add_node(&mut self, value:&String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn add_edge(&mut self, a:&String, b:&String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn add_edge(&mut self, a:&String, b:&String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:31:39 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn get_neighbors(&self, value:&String) -> Option<&HashSet> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:35:30 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn get_path(&self, a:&String, b:&String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:35:41 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn get_path(&self, a:&String, b:&String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | fn get_path_helper(&self, a:&String, b:&String, visited:&HashSet, path:&Vec) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:42:44 [INFO] [stderr] | [INFO] [stderr] 42 | fn get_path_helper(&self, a:&String, b:&String, visited:&HashSet, path:&Vec) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graph.rs:42:84 [INFO] [stderr] | [INFO] [stderr] 42 | fn get_path_helper(&self, a:&String, b:&String, visited:&HashSet, path:&Vec) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 42 | fn get_path_helper(&self, a:&String, b:&String, visited:&HashSet, path:&[String]) -> Option> { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: change `path.clone()` to [INFO] [stderr] | [INFO] [stderr] 44 | let mut p = path.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:16:38 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn add_node(&mut self, value:&String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn add_edge(&mut self, a:&String, b:&String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:21:45 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn add_edge(&mut self, a:&String, b:&String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:31:39 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn get_neighbors(&self, value:&String) -> Option<&HashSet> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:35:30 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn get_path(&self, a:&String, b:&String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:35:41 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn get_path(&self, a:&String, b:&String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | fn get_path_helper(&self, a:&String, b:&String, visited:&HashSet, path:&Vec) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:42:44 [INFO] [stderr] | [INFO] [stderr] 42 | fn get_path_helper(&self, a:&String, b:&String, visited:&HashSet, path:&Vec) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graph.rs:42:84 [INFO] [stderr] | [INFO] [stderr] 42 | fn get_path_helper(&self, a:&String, b:&String, visited:&HashSet, path:&Vec) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 42 | fn get_path_helper(&self, a:&String, b:&String, visited:&HashSet, path:&[String]) -> Option> { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: change `path.clone()` to [INFO] [stderr] | [INFO] [stderr] 44 | let mut p = path.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/graph.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | assert!(g.nodes.get(&value).unwrap().is_empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&g.nodes[&value]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.19s [INFO] running `"docker" "inspect" "eed7acef1b05c7ec4c167e5c950ed9e8caac1576d89998fc445d01d8120ff680"` [INFO] running `"docker" "rm" "-f" "eed7acef1b05c7ec4c167e5c950ed9e8caac1576d89998fc445d01d8120ff680"` [INFO] [stdout] eed7acef1b05c7ec4c167e5c950ed9e8caac1576d89998fc445d01d8120ff680