[INFO] updating cached repository Aaron1011/github-notifier [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Aaron1011/github-notifier [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Aaron1011/github-notifier" "work/ex/clippy-test-run/sources/stable/gh/Aaron1011/github-notifier"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Aaron1011/github-notifier'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Aaron1011/github-notifier" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aaron1011/github-notifier"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aaron1011/github-notifier'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c443215a915a8590daaaf891aeefcbd67454563a [INFO] sha for GitHub repo Aaron1011/github-notifier: c443215a915a8590daaaf891aeefcbd67454563a [INFO] validating manifest of Aaron1011/github-notifier on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Aaron1011/github-notifier on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Aaron1011/github-notifier [INFO] finished frobbing Aaron1011/github-notifier [INFO] frobbed toml for Aaron1011/github-notifier written to work/ex/clippy-test-run/sources/stable/gh/Aaron1011/github-notifier/Cargo.toml [INFO] started frobbing Aaron1011/github-notifier [INFO] finished frobbing Aaron1011/github-notifier [INFO] frobbed toml for Aaron1011/github-notifier written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Aaron1011/github-notifier/Cargo.toml [INFO] crate Aaron1011/github-notifier has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Aaron1011/github-notifier against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Aaron1011/github-notifier:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cdd16a7a0f3b0c20316c23c5b2a162f63d8cab7f5e40570a499887246f27ad7f [INFO] running `"docker" "start" "-a" "cdd16a7a0f3b0c20316c23c5b2a162f63d8cab7f5e40570a499887246f27ad7f"` [INFO] [stderr] Checking idna v0.1.2 [INFO] [stderr] Checking dbus v0.4.1 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking url v1.4.1 [INFO] [stderr] warning: redundant linker flag specified for library `dbus-1` [INFO] [stderr] [INFO] [stderr] Checking notify-rust v3.4.0 [INFO] [stderr] Checking hyper v0.10.12 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking reqwest v0.6.2 [INFO] [stderr] Checking github-notifier v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | for note in map.get(repo).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[repo]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:52:59 [INFO] [stderr] | [INFO] [stderr] 52 | map.entry(note.repository.clone()).or_insert_with(|| Vec::new()).push(note); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | for note in map.get(repo).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[repo]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:52:59 [INFO] [stderr] | [INFO] [stderr] 52 | map.entry(note.repository.clone()).or_insert_with(|| Vec::new()).push(note); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.44s [INFO] running `"docker" "inspect" "cdd16a7a0f3b0c20316c23c5b2a162f63d8cab7f5e40570a499887246f27ad7f"` [INFO] running `"docker" "rm" "-f" "cdd16a7a0f3b0c20316c23c5b2a162f63d8cab7f5e40570a499887246f27ad7f"` [INFO] [stdout] cdd16a7a0f3b0c20316c23c5b2a162f63d8cab7f5e40570a499887246f27ad7f