[INFO] updating cached repository AWildDevAppears/n00t [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AWildDevAppears/n00t [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AWildDevAppears/n00t" "work/ex/clippy-test-run/sources/stable/gh/AWildDevAppears/n00t"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AWildDevAppears/n00t'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AWildDevAppears/n00t" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AWildDevAppears/n00t"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AWildDevAppears/n00t'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 391f75a2c4aac5ae4c56215f1cf44c86c72ee7cb [INFO] sha for GitHub repo AWildDevAppears/n00t: 391f75a2c4aac5ae4c56215f1cf44c86c72ee7cb [INFO] validating manifest of AWildDevAppears/n00t on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AWildDevAppears/n00t on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AWildDevAppears/n00t [INFO] finished frobbing AWildDevAppears/n00t [INFO] frobbed toml for AWildDevAppears/n00t written to work/ex/clippy-test-run/sources/stable/gh/AWildDevAppears/n00t/Cargo.toml [INFO] started frobbing AWildDevAppears/n00t [INFO] finished frobbing AWildDevAppears/n00t [INFO] frobbed toml for AWildDevAppears/n00t written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AWildDevAppears/n00t/Cargo.toml [INFO] crate AWildDevAppears/n00t has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AWildDevAppears/n00t against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AWildDevAppears/n00t:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 40650429a4292c273295221a52729cd27ee050cd445ba91fc51a79de3c10f9d7 [INFO] running `"docker" "start" "-a" "40650429a4292c273295221a52729cd27ee050cd445ba91fc51a79de3c10f9d7"` [INFO] [stderr] Checking xattr v0.2.2 [INFO] [stderr] Checking tar v0.4.20 [INFO] [stderr] Checking n00t v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/notebook.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | notes: notes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `notes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/notebook.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | notes: notes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `notes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/notebook.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return titles; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `titles` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/notebook.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return body; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/models/notebook.rs:20:27 [INFO] [stderr] | [INFO] [stderr] 20 | for (title, _) in &self.notes { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 20 | for title in self.notes.keys() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/notebook.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return titles; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `titles` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/models/notebook.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | return body; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's keys [INFO] [stderr] --> src/models/notebook.rs:20:27 [INFO] [stderr] | [INFO] [stderr] 20 | for (title, _) in &self.notes { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 20 | for title in self.notes.keys() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.34s [INFO] running `"docker" "inspect" "40650429a4292c273295221a52729cd27ee050cd445ba91fc51a79de3c10f9d7"` [INFO] running `"docker" "rm" "-f" "40650429a4292c273295221a52729cd27ee050cd445ba91fc51a79de3c10f9d7"` [INFO] [stdout] 40650429a4292c273295221a52729cd27ee050cd445ba91fc51a79de3c10f9d7