[INFO] updating cached repository ANtlord/system_ladder [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ANtlord/system_ladder [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ANtlord/system_ladder" "work/ex/clippy-test-run/sources/stable/gh/ANtlord/system_ladder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ANtlord/system_ladder'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ANtlord/system_ladder" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ANtlord/system_ladder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ANtlord/system_ladder'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a62d11a6103840582855bd5fdd765b5ec179a3e1 [INFO] sha for GitHub repo ANtlord/system_ladder: a62d11a6103840582855bd5fdd765b5ec179a3e1 [INFO] validating manifest of ANtlord/system_ladder on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ANtlord/system_ladder on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ANtlord/system_ladder [INFO] finished frobbing ANtlord/system_ladder [INFO] frobbed toml for ANtlord/system_ladder written to work/ex/clippy-test-run/sources/stable/gh/ANtlord/system_ladder/Cargo.toml [INFO] started frobbing ANtlord/system_ladder [INFO] finished frobbing ANtlord/system_ladder [INFO] frobbed toml for ANtlord/system_ladder written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ANtlord/system_ladder/Cargo.toml [INFO] crate ANtlord/system_ladder has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ANtlord/system_ladder against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ANtlord/system_ladder:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8e487f6e2a0731180c48ca2e68b801192a78e6285e8ca60c8a4f38ed0ba98fbd [INFO] running `"docker" "start" "-a" "8e487f6e2a0731180c48ca2e68b801192a78e6285e8ca60c8a4f38ed0ba98fbd"` [INFO] [stderr] Checking system_ladder v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::any::TypeId` [INFO] [stderr] --> src/main.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::any::TypeId; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/main.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | let res = (|| { [INFO] [stderr] | _______________________^ [INFO] [stderr] 31 | | $($fbody)* [INFO] [stderr] 32 | | })(); [INFO] [stderr] | |________________^ [INFO] [stderr] ... [INFO] [stderr] 53 | / call! { [INFO] [stderr] 54 | | fn callee3(a: i32, b: i32) -> i32 { [INFO] [stderr] 55 | | if a == 1 { [INFO] [stderr] 56 | | let c = a + b; [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] help: Try doing something like: [INFO] [stderr] | [INFO] [stderr] 30 | let res = { [INFO] [stderr] 31 | $($fbody)* [INFO] [stderr] 32 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | c [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:56:25 [INFO] [stderr] | [INFO] [stderr] 56 | let c = a + b; [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | d [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:59:25 [INFO] [stderr] | [INFO] [stderr] 59 | let d = a * b; [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/main.rs:42:20 [INFO] [stderr] | [INFO] [stderr] 42 | fn callee2(a: i32, b: i32) { [INFO] [stderr] | ^ help: consider using `_a` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/main.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | fn callee2(a: i32, b: i32) { [INFO] [stderr] | ^ help: consider using `_b` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/main.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | fn callee(self, a: i32, b: i32) { [INFO] [stderr] | ^ help: consider using `_a` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/main.rs:48:33 [INFO] [stderr] | [INFO] [stderr] 48 | fn callee(self, a: i32, b: i32) { [INFO] [stderr] | ^ help: consider using `_b` instead [INFO] [stderr] [INFO] [stderr] warning: type `point` should have a camel case name such as `Point` [INFO] [stderr] --> src/main.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | struct point(i32, i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::any::TypeId` [INFO] [stderr] --> src/main.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::any::TypeId; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/main.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | let res = (|| { [INFO] [stderr] | _______________________^ [INFO] [stderr] 31 | | $($fbody)* [INFO] [stderr] 32 | | })(); [INFO] [stderr] | |________________^ [INFO] [stderr] ... [INFO] [stderr] 53 | / call! { [INFO] [stderr] 54 | | fn callee3(a: i32, b: i32) -> i32 { [INFO] [stderr] 55 | | if a == 1 { [INFO] [stderr] 56 | | let c = a + b; [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] help: Try doing something like: [INFO] [stderr] | [INFO] [stderr] 30 | let res = { [INFO] [stderr] 31 | $($fbody)* [INFO] [stderr] 32 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | c [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:56:25 [INFO] [stderr] | [INFO] [stderr] 56 | let c = a + b; [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | d [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:59:25 [INFO] [stderr] | [INFO] [stderr] 59 | let d = a * b; [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/main.rs:42:20 [INFO] [stderr] | [INFO] [stderr] 42 | fn callee2(a: i32, b: i32) { [INFO] [stderr] | ^ help: consider using `_a` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/main.rs:42:28 [INFO] [stderr] | [INFO] [stderr] 42 | fn callee2(a: i32, b: i32) { [INFO] [stderr] | ^ help: consider using `_b` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/main.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | fn callee(self, a: i32, b: i32) { [INFO] [stderr] | ^ help: consider using `_a` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/main.rs:48:33 [INFO] [stderr] | [INFO] [stderr] 48 | fn callee(self, a: i32, b: i32) { [INFO] [stderr] | ^ help: consider using `_b` instead [INFO] [stderr] [INFO] [stderr] warning: type `point` should have a camel case name such as `Point` [INFO] [stderr] --> src/main.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | struct point(i32, i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.75s [INFO] running `"docker" "inspect" "8e487f6e2a0731180c48ca2e68b801192a78e6285e8ca60c8a4f38ed0ba98fbd"` [INFO] running `"docker" "rm" "-f" "8e487f6e2a0731180c48ca2e68b801192a78e6285e8ca60c8a4f38ed0ba98fbd"` [INFO] [stdout] 8e487f6e2a0731180c48ca2e68b801192a78e6285e8ca60c8a4f38ed0ba98fbd