[INFO] updating cached repository AIUS/aius-authd [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AIUS/aius-authd [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AIUS/aius-authd" "work/ex/clippy-test-run/sources/stable/gh/AIUS/aius-authd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AIUS/aius-authd'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AIUS/aius-authd" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AIUS/aius-authd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AIUS/aius-authd'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7670640222ff57c26ee573a2c8bb1bb419ff6315 [INFO] sha for GitHub repo AIUS/aius-authd: 7670640222ff57c26ee573a2c8bb1bb419ff6315 [INFO] validating manifest of AIUS/aius-authd on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AIUS/aius-authd on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AIUS/aius-authd [INFO] finished frobbing AIUS/aius-authd [INFO] frobbed toml for AIUS/aius-authd written to work/ex/clippy-test-run/sources/stable/gh/AIUS/aius-authd/Cargo.toml [INFO] started frobbing AIUS/aius-authd [INFO] finished frobbing AIUS/aius-authd [INFO] frobbed toml for AIUS/aius-authd written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AIUS/aius-authd/Cargo.toml [INFO] crate AIUS/aius-authd has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AIUS/aius-authd against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AIUS/aius-authd:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7fdb5564ef102f94f9ef0d0f2aea26d826b8f3654c656db71627b1efb43aee28 [INFO] running `"docker" "start" "-a" "7fdb5564ef102f94f9ef0d0f2aea26d826b8f3654c656db71627b1efb43aee28"` [INFO] [stderr] Checking num_cpus v0.2.13 [INFO] [stderr] Checking openldap v1.1.0 [INFO] [stderr] Compiling syn v0.10.6 [INFO] [stderr] Checking serde_json v0.8.4 [INFO] [stderr] Checking toml v0.2.1 [INFO] [stderr] Checking uuid v0.2.3 [INFO] [stderr] Checking redis v0.8.0 [INFO] [stderr] Checking simplelog v0.4.2 [INFO] [stderr] Checking hyper v0.9.14 [INFO] [stderr] Compiling serde_codegen_internals v0.11.3 [INFO] [stderr] Compiling serde_codegen v0.8.22 [INFO] [stderr] Checking iron v0.4.0 [INFO] [stderr] Compiling serde_derive v0.8.22 [INFO] [stderr] Checking persistent v0.2.1 [INFO] [stderr] Checking logger v0.2.0 [INFO] [stderr] Checking router v0.4.0 [INFO] [stderr] Checking bodyparser v0.4.1 [INFO] [stderr] Checking aius-authd v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/router.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/middlewares.rs:20:34 [INFO] [stderr] | [INFO] [stderr] 20 | ConfigBeforeMiddleware { config: config } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/router.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/middlewares.rs:20:34 [INFO] [stderr] | [INFO] [stderr] 20 | ConfigBeforeMiddleware { config: config } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/middlewares.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(Response::with((status::ServiceUnavailable, "Redis Error"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with((status::ServiceUnavailable, "Redis Error")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/middlewares.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | return Ok(Response::with((status::ServiceUnavailable, "LDAP Error"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with((status::ServiceUnavailable, "LDAP Error")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/middlewares.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(Response::with((status::ServiceUnavailable, "Redis Error"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with((status::ServiceUnavailable, "Redis Error")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/middlewares.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | return Ok(Response::with((status::ServiceUnavailable, "LDAP Error"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with((status::ServiceUnavailable, "LDAP Error")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/config.rs:122:22 [INFO] [stderr] | [INFO] [stderr] 122 | errs.into_iter().fold(write!(f, "Parse Errors:"), |result, ref error| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/config.rs:212:56 [INFO] [stderr] | [INFO] [stderr] 212 | Deserialize::deserialize(&mut decoder).map_err(|e| LoadError::DecodeError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `LoadError::DecodeError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server/router.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | let _: () = itry!(redis.set_ex(format!("token:{}", uuid.simple()), login.username.as_str(), 3600 * 24 * 7)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server/router.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | let _: () = itry!(redis.del(format!("token:{}", uuid.simple()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/ldap.rs:45:64 [INFO] [stderr] | [INFO] [stderr] 45 | let conn = try!(RustLDAP::new(config.uri.as_str()).map_err(|e| Error::LDAPError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::LDAPError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/ldap.rs:47:67 [INFO] [stderr] | [INFO] [stderr] 47 | match try!(conn.simple_bind(full_user.as_str(), pass).map_err(|e| Error::LDAPError(e))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::LDAPError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:88:10 [INFO] [stderr] | [INFO] [stderr] 88 | .or(env.get("AUTH_CONFIG").map(|s| s.as_str())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| env.get("AUTH_CONFIG").map(|s| s.as_str()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/config.rs:122:22 [INFO] [stderr] | [INFO] [stderr] 122 | errs.into_iter().fold(write!(f, "Parse Errors:"), |result, ref error| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/config.rs:212:56 [INFO] [stderr] | [INFO] [stderr] 212 | Deserialize::deserialize(&mut decoder).map_err(|e| LoadError::DecodeError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `LoadError::DecodeError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server/router.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | let _: () = itry!(redis.set_ex(format!("token:{}", uuid.simple()), login.username.as_str(), 3600 * 24 * 7)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/server/router.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | let _: () = itry!(redis.del(format!("token:{}", uuid.simple()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/ldap.rs:45:64 [INFO] [stderr] | [INFO] [stderr] 45 | let conn = try!(RustLDAP::new(config.uri.as_str()).map_err(|e| Error::LDAPError(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::LDAPError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/ldap.rs:47:67 [INFO] [stderr] | [INFO] [stderr] 47 | match try!(conn.simple_bind(full_user.as_str(), pass).map_err(|e| Error::LDAPError(e))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::LDAPError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:88:10 [INFO] [stderr] | [INFO] [stderr] 88 | .or(env.get("AUTH_CONFIG").map(|s| s.as_str())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| env.get("AUTH_CONFIG").map(|s| s.as_str()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.30s [INFO] running `"docker" "inspect" "7fdb5564ef102f94f9ef0d0f2aea26d826b8f3654c656db71627b1efb43aee28"` [INFO] running `"docker" "rm" "-f" "7fdb5564ef102f94f9ef0d0f2aea26d826b8f3654c656db71627b1efb43aee28"` [INFO] [stdout] 7fdb5564ef102f94f9ef0d0f2aea26d826b8f3654c656db71627b1efb43aee28