[INFO] updating cached repository ABorse/ProgLang18 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ABorse/ProgLang18 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ABorse/ProgLang18" "work/ex/clippy-test-run/sources/stable/gh/ABorse/ProgLang18"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ABorse/ProgLang18'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ABorse/ProgLang18" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ABorse/ProgLang18"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ABorse/ProgLang18'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9bdf1dc4a524a35dff652f36037009f45d6b388c [INFO] sha for GitHub repo ABorse/ProgLang18: 9bdf1dc4a524a35dff652f36037009f45d6b388c [INFO] validating manifest of ABorse/ProgLang18 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ABorse/ProgLang18 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ABorse/ProgLang18 [INFO] finished frobbing ABorse/ProgLang18 [INFO] frobbed toml for ABorse/ProgLang18 written to work/ex/clippy-test-run/sources/stable/gh/ABorse/ProgLang18/Cargo.toml [INFO] started frobbing ABorse/ProgLang18 [INFO] finished frobbing ABorse/ProgLang18 [INFO] frobbed toml for ABorse/ProgLang18 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ABorse/ProgLang18/Cargo.toml [INFO] crate ABorse/ProgLang18 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ABorse/ProgLang18 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ABorse/ProgLang18:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 580803f271a9f5b1cbd62619465e78d12f223b4de8a37677861627529d2144d6 [INFO] running `"docker" "start" "-a" "580803f271a9f5b1cbd62619465e78d12f223b4de8a37677861627529d2144d6"` [INFO] [stderr] Checking updated_scheme v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | operator: operator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | if_true: if_true, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `if_true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | if_false: if_false, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `if_false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | operator: operator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | if_true: if_true, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `if_true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | if_false: if_false, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `if_false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return Token::Constant(s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token::Constant(s)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | return tokens; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return Expression::Predicate(Box::new(predicate)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Expression::Predicate(Box::new(predicate))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | return Expression::Number(s.parse::().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Expression::Number(s.parse::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/predicate.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return self.if_false.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.if_false.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | fn parse_conditional(mut tokens: &mut Vec, environment: &Environment) -> Expression { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:45:19 [INFO] [stderr] | [INFO] [stderr] 45 | fn parse_compound(mut tokens: &mut Vec, environment: &Environment) -> Expression { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:86:14 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn parse(mut tokens: &mut Vec, environment: &Environment) -> Expression { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/environment_parser.rs:8:29 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn parse_to_environment(mut v: &mut Vec) -> Environment { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/environment_parser.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let mut hash: HashMap = HashMap::new(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lexer.rs:42:31 [INFO] [stderr] | [INFO] [stderr] 42 | fn get_constant_or_keyword(v: &Vec) -> Token { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lexer.rs:92:8 [INFO] [stderr] | [INFO] [stderr] 92 | if accumulation.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!accumulation.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/evaluator.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / match e { [INFO] [stderr] 14 | | &Expression::Number(a) => Ok(a), [INFO] [stderr] 15 | | &Expression::Plus(ref v) => Ok(v.iter().map(|y| evaluate(y).ok().unwrap()).fold(0.0, |acc, x| acc+x)), [INFO] [stderr] 16 | | &Expression::Mult(ref v) => Ok(v.iter().map(|y| evaluate(y).ok().unwrap()).fold(1.0, |acc, x| acc*x)), [INFO] [stderr] 17 | | &Expression::Predicate(ref p) => evaluate(&p.evaluate()), [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *e { [INFO] [stderr] 14 | Expression::Number(a) => Ok(a), [INFO] [stderr] 15 | Expression::Plus(ref v) => Ok(v.iter().map(|y| evaluate(y).ok().unwrap()).fold(0.0, |acc, x| acc+x)), [INFO] [stderr] 16 | Expression::Mult(ref v) => Ok(v.iter().map(|y| evaluate(y).ok().unwrap()).fold(1.0, |acc, x| acc*x)), [INFO] [stderr] 17 | Expression::Predicate(ref p) => evaluate(&p.evaluate()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / match tokens.get(0).unwrap() { [INFO] [stderr] 60 | | &Token::RParen => break, [INFO] [stderr] 61 | | _ => expressions.push(parse(tokens, environment)), [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | match *tokens.get(0).unwrap() { [INFO] [stderr] 60 | Token::RParen => break, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:59:15 [INFO] [stderr] | [INFO] [stderr] 59 | match tokens.get(0).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | let expr = environment.variables.get(key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&environment.variables[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return Token::Constant(s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token::Constant(s)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | return tokens; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return Expression::Predicate(Box::new(predicate)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Expression::Predicate(Box::new(predicate))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | return Expression::Number(s.parse::().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Expression::Number(s.parse::().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/interpreter.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/predicate.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return self.if_false.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.if_false.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/environment_parser.rs:15:8 [INFO] [stderr] | [INFO] [stderr] 15 | while v.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/predicate.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | '>' => if l > r { true } else { false }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `l > r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/predicate.rs:22:24 [INFO] [stderr] | [INFO] [stderr] 22 | '<' => if l < r { true } else { false }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `l < r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/predicate.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | '=' => if l == r { true } else { false }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `l == r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/predicate.rs:23:27 [INFO] [stderr] | [INFO] [stderr] 23 | '=' => if l == r { true } else { false }, [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(l - r).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/predicate.rs:23:27 [INFO] [stderr] | [INFO] [stderr] 23 | '=' => if l == r { true } else { false }, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `updated_scheme`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:8:22 [INFO] [stderr] | [INFO] [stderr] 8 | fn parse_conditional(mut tokens: &mut Vec, environment: &Environment) -> Expression { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:45:19 [INFO] [stderr] | [INFO] [stderr] 45 | fn parse_compound(mut tokens: &mut Vec, environment: &Environment) -> Expression { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:86:14 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn parse(mut tokens: &mut Vec, environment: &Environment) -> Expression { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/environment_parser.rs:8:29 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn parse_to_environment(mut v: &mut Vec) -> Environment { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/environment_parser.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let mut hash: HashMap = HashMap::new(); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lexer.rs:42:31 [INFO] [stderr] | [INFO] [stderr] 42 | fn get_constant_or_keyword(v: &Vec) -> Token { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lexer.rs:92:8 [INFO] [stderr] | [INFO] [stderr] 92 | if accumulation.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!accumulation.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/evaluator.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / match e { [INFO] [stderr] 14 | | &Expression::Number(a) => Ok(a), [INFO] [stderr] 15 | | &Expression::Plus(ref v) => Ok(v.iter().map(|y| evaluate(y).ok().unwrap()).fold(0.0, |acc, x| acc+x)), [INFO] [stderr] 16 | | &Expression::Mult(ref v) => Ok(v.iter().map(|y| evaluate(y).ok().unwrap()).fold(1.0, |acc, x| acc*x)), [INFO] [stderr] 17 | | &Expression::Predicate(ref p) => evaluate(&p.evaluate()), [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 13 | match *e { [INFO] [stderr] 14 | Expression::Number(a) => Ok(a), [INFO] [stderr] 15 | Expression::Plus(ref v) => Ok(v.iter().map(|y| evaluate(y).ok().unwrap()).fold(0.0, |acc, x| acc+x)), [INFO] [stderr] 16 | Expression::Mult(ref v) => Ok(v.iter().map(|y| evaluate(y).ok().unwrap()).fold(1.0, |acc, x| acc*x)), [INFO] [stderr] 17 | Expression::Predicate(ref p) => evaluate(&p.evaluate()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / match tokens.get(0).unwrap() { [INFO] [stderr] 60 | | &Token::RParen => break, [INFO] [stderr] 61 | | _ => expressions.push(parse(tokens, environment)), [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | match *tokens.get(0).unwrap() { [INFO] [stderr] 60 | Token::RParen => break, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:59:15 [INFO] [stderr] | [INFO] [stderr] 59 | match tokens.get(0).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:79:24 [INFO] [stderr] | [INFO] [stderr] 79 | let expr = environment.variables.get(key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&environment.variables[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/environment_parser.rs:15:8 [INFO] [stderr] | [INFO] [stderr] 15 | while v.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/predicate.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | '>' => if l > r { true } else { false }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `l > r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/predicate.rs:22:24 [INFO] [stderr] | [INFO] [stderr] 22 | '<' => if l < r { true } else { false }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `l < r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/predicate.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | '=' => if l == r { true } else { false }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `l == r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/predicate.rs:23:27 [INFO] [stderr] | [INFO] [stderr] 23 | '=' => if l == r { true } else { false }, [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(l - r).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/predicate.rs:23:27 [INFO] [stderr] | [INFO] [stderr] 23 | '=' => if l == r { true } else { false }, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `updated_scheme`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "580803f271a9f5b1cbd62619465e78d12f223b4de8a37677861627529d2144d6"` [INFO] running `"docker" "rm" "-f" "580803f271a9f5b1cbd62619465e78d12f223b4de8a37677861627529d2144d6"` [INFO] [stdout] 580803f271a9f5b1cbd62619465e78d12f223b4de8a37677861627529d2144d6