[INFO] updating cached repository 64/iris [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/64/iris [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/64/iris" "work/ex/clippy-test-run/sources/stable/gh/64/iris"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/64/iris'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/64/iris" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/64/iris"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/64/iris'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ebb83de44ddcd45ea4766cad416136e56dd319f2 [INFO] sha for GitHub repo 64/iris: ebb83de44ddcd45ea4766cad416136e56dd319f2 [INFO] validating manifest of 64/iris on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of 64/iris on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing 64/iris [INFO] finished frobbing 64/iris [INFO] frobbed toml for 64/iris written to work/ex/clippy-test-run/sources/stable/gh/64/iris/Cargo.toml [INFO] started frobbing 64/iris [INFO] finished frobbing 64/iris [INFO] frobbed toml for 64/iris written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/64/iris/Cargo.toml [INFO] crate 64/iris has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting 64/iris against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/64/iris:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a8c24bc92a0705ff3fc753514981c3a7433430c068bd531f36e29d142811c5ee [INFO] running `"docker" "start" "-a" "a8c24bc92a0705ff3fc753514981c3a7433430c068bd531f36e29d142811c5ee"` [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking alga v0.7.1 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking error-chain v0.5.0 [INFO] [stderr] Checking shred v0.7.0 [INFO] [stderr] Checking cpuprofiler v0.0.3 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking shrev v1.0.1 [INFO] [stderr] Checking specs v0.12.1 [INFO] [stderr] Checking nalgebra v0.16.0 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking iris v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: field is never used: `shadowmap_shader` [INFO] [stderr] --> src/renderer.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | shadowmap_shader: Shader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `render_geometry_only` [INFO] [stderr] --> src/renderer.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | / pub fn render_geometry_only(&self, target: &mut S, shader: &Shader, params: &glium::DrawParameters, get_uniforms: F) [INFO] [stderr] 165 | | where S: glium::Surface, [INFO] [stderr] 166 | | U: glium::uniforms::Uniforms, [INFO] [stderr] 167 | | F: Fn(Matrix4) -> U [INFO] [stderr] ... | [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MAX_POINT_LIGHTS` [INFO] [stderr] --> src/light.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub const MAX_POINT_LIGHTS: usize = 30; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MAP_WIDTH` [INFO] [stderr] --> src/lightset.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | const MAP_WIDTH: u32 = 1024; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MAP_HEIGHT` [INFO] [stderr] --> src/lightset.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | const MAP_HEIGHT: u32 = 1024; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `shadow_maps` [INFO] [stderr] --> src/lightset.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | shadow_maps: UnsafeCell>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `maps` [INFO] [stderr] --> src/lightset.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub unsafe fn maps(&self) -> &[glium::texture::DepthTexture2d] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `build_shadows` [INFO] [stderr] --> src/lightset.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn build_shadows(&self, shader: &Shader, renderer: &Renderer) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `shadowmap_shader` [INFO] [stderr] --> src/renderer.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | shadowmap_shader: Shader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `render_geometry_only` [INFO] [stderr] --> src/renderer.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | / pub fn render_geometry_only(&self, target: &mut S, shader: &Shader, params: &glium::DrawParameters, get_uniforms: F) [INFO] [stderr] 165 | | where S: glium::Surface, [INFO] [stderr] 166 | | U: glium::uniforms::Uniforms, [INFO] [stderr] 167 | | F: Fn(Matrix4) -> U [INFO] [stderr] ... | [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MAX_POINT_LIGHTS` [INFO] [stderr] --> src/light.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub const MAX_POINT_LIGHTS: usize = 30; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MAP_WIDTH` [INFO] [stderr] --> src/lightset.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | const MAP_WIDTH: u32 = 1024; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MAP_HEIGHT` [INFO] [stderr] --> src/lightset.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | const MAP_HEIGHT: u32 = 1024; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `shadow_maps` [INFO] [stderr] --> src/lightset.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | shadow_maps: UnsafeCell>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `maps` [INFO] [stderr] --> src/lightset.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub unsafe fn maps(&self) -> &[glium::texture::DepthTexture2d] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `build_shadows` [INFO] [stderr] --> src/lightset.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn build_shadows(&self, shader: &Shader, renderer: &Renderer) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/uniforms.rs:48:60 [INFO] [stderr] | [INFO] [stderr] 48 | f("u_point_light.position", UniformValue::Vec4(point.position.into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `point.position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/uniforms.rs:49:57 [INFO] [stderr] | [INFO] [stderr] 49 | f("u_point_light.color", UniformValue::Vec4(point.color.into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `point.color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/uniforms.rs:50:61 [INFO] [stderr] | [INFO] [stderr] 50 | f("u_point_light.strength", UniformValue::Float(point.strength.into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `point.strength` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:35 [INFO] [stderr] | [INFO] [stderr] 69 | t.as_secs() as f64 + (t.subsec_millis() as f64 / 1000.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | / match ev { [INFO] [stderr] 80 | | glutin::Event::WindowEvent { event, .. } => { [INFO] [stderr] 81 | | renderer.handle_event(delta, event.clone()); [INFO] [stderr] 82 | | match event { [INFO] [stderr] ... | [INFO] [stderr] 88 | | _ => (), [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 79 | if let glutin::Event::WindowEvent { event, .. } = ev { [INFO] [stderr] 80 | renderer.handle_event(delta, event.clone()); [INFO] [stderr] 81 | match event { [INFO] [stderr] 82 | glutin::WindowEvent::CloseRequested => closed = true, [INFO] [stderr] 83 | glutin::WindowEvent::KeyboardInput { input, .. } => closed = handle_key_input(input), [INFO] [stderr] 84 | _ => (), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | / match key { [INFO] [stderr] 102 | | VirtualKeyCode::Escape => done = true, [INFO] [stderr] 103 | | _ => (), [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ help: try this: `if let VirtualKeyCode::Escape = key { done = true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/uniforms.rs:48:60 [INFO] [stderr] | [INFO] [stderr] 48 | f("u_point_light.position", UniformValue::Vec4(point.position.into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `point.position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/uniforms.rs:49:57 [INFO] [stderr] | [INFO] [stderr] 49 | f("u_point_light.color", UniformValue::Vec4(point.color.into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `point.color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/uniforms.rs:50:61 [INFO] [stderr] | [INFO] [stderr] 50 | f("u_point_light.strength", UniformValue::Float(point.strength.into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `point.strength` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:35 [INFO] [stderr] | [INFO] [stderr] 69 | t.as_secs() as f64 + (t.subsec_millis() as f64 / 1000.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(t.subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | / match ev { [INFO] [stderr] 80 | | glutin::Event::WindowEvent { event, .. } => { [INFO] [stderr] 81 | | renderer.handle_event(delta, event.clone()); [INFO] [stderr] 82 | | match event { [INFO] [stderr] ... | [INFO] [stderr] 88 | | _ => (), [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 79 | if let glutin::Event::WindowEvent { event, .. } = ev { [INFO] [stderr] 80 | renderer.handle_event(delta, event.clone()); [INFO] [stderr] 81 | match event { [INFO] [stderr] 82 | glutin::WindowEvent::CloseRequested => closed = true, [INFO] [stderr] 83 | glutin::WindowEvent::KeyboardInput { input, .. } => closed = handle_key_input(input), [INFO] [stderr] 84 | _ => (), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | / match key { [INFO] [stderr] 102 | | VirtualKeyCode::Escape => done = true, [INFO] [stderr] 103 | | _ => (), [INFO] [stderr] 104 | | } [INFO] [stderr] | |_________^ help: try this: `if let VirtualKeyCode::Escape = key { done = true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 49.36s [INFO] running `"docker" "inspect" "a8c24bc92a0705ff3fc753514981c3a7433430c068bd531f36e29d142811c5ee"` [INFO] running `"docker" "rm" "-f" "a8c24bc92a0705ff3fc753514981c3a7433430c068bd531f36e29d142811c5ee"` [INFO] [stdout] a8c24bc92a0705ff3fc753514981c3a7433430c068bd531f36e29d142811c5ee