[INFO] updating cached repository 46bit/tilewater
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/46bit/tilewater
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/46bit/tilewater" "work/ex/clippy-test-run/sources/stable/gh/46bit/tilewater"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/46bit/tilewater'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/46bit/tilewater" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/46bit/tilewater"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/46bit/tilewater'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 52cb8b83717e2ae49bfd3a92a0da4c5a22e8ebe9
[INFO] sha for GitHub repo 46bit/tilewater: 52cb8b83717e2ae49bfd3a92a0da4c5a22e8ebe9
[INFO] validating manifest of 46bit/tilewater on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of 46bit/tilewater on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing 46bit/tilewater
[INFO] finished frobbing 46bit/tilewater
[INFO] frobbed toml for 46bit/tilewater written to work/ex/clippy-test-run/sources/stable/gh/46bit/tilewater/Cargo.toml
[INFO] started frobbing 46bit/tilewater
[INFO] finished frobbing 46bit/tilewater
[INFO] frobbed toml for 46bit/tilewater written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/46bit/tilewater/Cargo.toml
[INFO] crate 46bit/tilewater has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting 46bit/tilewater against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/46bit/tilewater:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 71fc29532c77a06d60212c9d93000bae3237bb6a4c37bf7903be87da61a7619f
[INFO] running `"docker" "start" "-a" "71fc29532c77a06d60212c9d93000bae3237bb6a4c37bf7903be87da61a7619f"`
[INFO] [stderr]    Compiling phf v0.7.22
[INFO] [stderr]    Compiling phf_generator v0.7.22
[INFO] [stderr]     Checking rusttype v0.2.3
[INFO] [stderr]    Compiling num-traits v0.1.43
[INFO] [stderr]    Compiling gl_generator v0.7.0
[INFO] [stderr]     Checking gfx_core v0.7.2
[INFO] [stderr]     Checking fs2 v0.2.5
[INFO] [stderr]    Compiling glutin v0.9.2
[INFO] [stderr]     Checking png v0.9.0
[INFO] [stderr]     Checking pistoncore-input v0.19.0
[INFO] [stderr]    Compiling serde_json v0.9.10
[INFO] [stderr]     Checking jpeg-decoder v0.1.14
[INFO] [stderr]    Compiling phf_codegen v0.7.22
[INFO] [stderr]     Checking memmap v0.4.0
[INFO] [stderr]    Compiling gfx_gl v0.4.0
[INFO] [stderr]     Checking image v0.15.0
[INFO] [stderr]    Compiling target_build_utils v0.3.1
[INFO] [stderr]     Checking pistoncore-window v0.28.0
[INFO] [stderr]     Checking pistoncore-event_loop v0.33.0
[INFO] [stderr]     Checking piston v0.33.0
[INFO] [stderr]    Compiling libloading v0.3.4
[INFO] [stderr]     Checking dlib v0.3.1
[INFO] [stderr]     Checking wayland-sys v0.9.10
[INFO] [stderr]     Checking wayland-client v0.9.10
[INFO] [stderr]     Checking wayland-protocols v0.9.10
[INFO] [stderr]     Checking wayland-kbd v0.9.1
[INFO] [stderr]     Checking wayland-window v0.7.0
[INFO] [stderr]     Checking gfx v0.16.3
[INFO] [stderr]     Checking gfx_device_gl v0.14.6
[INFO] [stderr]     Checking winit v0.7.6
[INFO] [stderr]     Checking pistoncore-glutin_window v0.39.1
[INFO] [stderr]     Checking piston-gfx_texture v0.26.0
[INFO] [stderr]     Checking piston2d-gfx_graphics v0.43.0
[INFO] [stderr]     Checking piston_window v0.70.0
[INFO] [stderr]     Checking tilewater v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/agents.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |             ticks_per_unit: ticks_per_unit,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ticks_per_unit`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/agents.rs:154:13
[INFO] [stderr]     |
[INFO] [stderr] 154 |             decider: decider,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `decider`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/agents.rs:149:17
[INFO] [stderr]     |
[INFO] [stderr] 149 |                 position: position,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `position`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/agents.rs:201:13
[INFO] [stderr]     |
[INFO] [stderr] 201 |             home: home,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `home`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/agents.rs:350:13
[INFO] [stderr]     |
[INFO] [stderr] 350 |             platform: platform,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `platform`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 |             building: building,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `building`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:58:13
[INFO] [stderr]    |
[INFO] [stderr] 58 |             entryway_pos: entryway_pos,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entryway_pos`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:68:13
[INFO] [stderr]    |
[INFO] [stderr] 68 |             road_pos: road_pos,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `road_pos`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:70:13
[INFO] [stderr]    |
[INFO] [stderr] 70 |             orientation: orientation,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `orientation`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/map.rs:317:13
[INFO] [stderr]     |
[INFO] [stderr] 317 |             write!(f, "\n")?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:169:17
[INFO] [stderr]     |
[INFO] [stderr] 169 |         let mut x = l.0 * ppuf - 1.0 - w;
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:170:13
[INFO] [stderr]     |
[INFO] [stderr] 170 |         let y = l.1 * ppuf;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:171:13
[INFO] [stderr]     |
[INFO] [stderr] 171 |         let h = ppuf + 1.0;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:238:13
[INFO] [stderr]     |
[INFO] [stderr] 238 |         let y = l.y * PPU;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:260:13
[INFO] [stderr]     |
[INFO] [stderr] 260 |         let y = l.y * PPU;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:271:13
[INFO] [stderr]     |
[INFO] [stderr] 271 |         let y = l.y * PPU;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:282:13
[INFO] [stderr]     |
[INFO] [stderr] 282 |         let y = l.y * PPU;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:293:13
[INFO] [stderr]     |
[INFO] [stderr] 293 |         let y = l.y * PPU;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:316:13
[INFO] [stderr]     |
[INFO] [stderr] 316 |         let y = l.y * PPU;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:327:13
[INFO] [stderr]     |
[INFO] [stderr] 327 |         let y = l.y * PPU;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:372:13
[INFO] [stderr]     |
[INFO] [stderr] 372 |         let y = l.y * PPU;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/agents.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |             ticks_per_unit: ticks_per_unit,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ticks_per_unit`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/agents.rs:154:13
[INFO] [stderr]     |
[INFO] [stderr] 154 |             decider: decider,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `decider`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/agents.rs:149:17
[INFO] [stderr]     |
[INFO] [stderr] 149 |                 position: position,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^ help: replace it with: `position`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/agents.rs:201:13
[INFO] [stderr]     |
[INFO] [stderr] 201 |             home: home,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `home`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/agents.rs:350:13
[INFO] [stderr]     |
[INFO] [stderr] 350 |             platform: platform,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `platform`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 |             building: building,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `building`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:58:13
[INFO] [stderr]    |
[INFO] [stderr] 58 |             entryway_pos: entryway_pos,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entryway_pos`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:68:13
[INFO] [stderr]    |
[INFO] [stderr] 68 |             road_pos: road_pos,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `road_pos`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/map.rs:70:13
[INFO] [stderr]    |
[INFO] [stderr] 70 |             orientation: orientation,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `orientation`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/map.rs:317:13
[INFO] [stderr]     |
[INFO] [stderr] 317 |             write!(f, "\n")?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:169:17
[INFO] [stderr]     |
[INFO] [stderr] 169 |         let mut x = l.0 * ppuf - 1.0 - w;
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:170:13
[INFO] [stderr]     |
[INFO] [stderr] 170 |         let y = l.1 * ppuf;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:171:13
[INFO] [stderr]     |
[INFO] [stderr] 171 |         let h = ppuf + 1.0;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:238:13
[INFO] [stderr]     |
[INFO] [stderr] 238 |         let y = l.y * PPU;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:260:13
[INFO] [stderr]     |
[INFO] [stderr] 260 |         let y = l.y * PPU;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:271:13
[INFO] [stderr]     |
[INFO] [stderr] 271 |         let y = l.y * PPU;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:282:13
[INFO] [stderr]     |
[INFO] [stderr] 282 |         let y = l.y * PPU;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:293:13
[INFO] [stderr]     |
[INFO] [stderr] 293 |         let y = l.y * PPU;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:316:13
[INFO] [stderr]     |
[INFO] [stderr] 316 |         let y = l.y * PPU;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:327:13
[INFO] [stderr]     |
[INFO] [stderr] 327 |         let y = l.y * PPU;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/render_to_piston.rs:372:13
[INFO] [stderr]     |
[INFO] [stderr] 372 |         let y = l.y * PPU;
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/agents.rs:34:29
[INFO] [stderr]    |
[INFO] [stderr] 34 |             .or_insert_with(|| HashMap::new())
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashMap::new`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/agents.rs:170:14
[INFO] [stderr]     |
[INFO] [stderr] 170 |         rng: &mut Box<RngCore>,
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^ help: try: `&mut RngCore`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/map.rs:63:29
[INFO] [stderr]    |
[INFO] [stderr] 63 |             .or_insert_with(|| Vec::new())
[INFO] [stderr]    |                             ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/render_to_piston.rs:226:68
[INFO] [stderr]     |
[INFO] [stderr] 226 |     fn draw_building(c: Context, g: &mut G2d, l: Coord2, building: &Building) {
[INFO] [stderr]     |                                                                    ^^^^^^^^^ help: consider passing by value instead: `Building`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: equal expressions as operands to `/`
[INFO] [stderr]    --> src/render_to_piston.rs:262:42
[INFO] [stderr]     |
[INFO] [stderr] 262 |             [0.0 / 255.0, 162.0 / 255.0, 255.0 / 255.0, 1.0],
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::eq_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/routing.rs:98:62
[INFO] [stderr]    |
[INFO] [stderr] 98 | pub fn route_to_any(map: &Map, start_pos: Coord2, goals_pos: &Vec<Coord2>) -> Route {
[INFO] [stderr]    |                                                              ^^^^^^^^^^^^ help: change this to: `&[Coord2]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/routing.rs:166:11
[INFO] [stderr]     |
[INFO] [stderr] 166 |     match tile.clone() {
[INFO] [stderr]     |           ^^^^^^^^^^^^ help: try removing the `clone` call: `tile`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:131:22
[INFO] [stderr]     |
[INFO] [stderr] 131 |     pub fn as_offset(&self) -> Coord2 {
[INFO] [stderr]     |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/lib.rs:150:12
[INFO] [stderr]     |
[INFO] [stderr] 150 |         if (a.x == b.x && a.y == b.y) || (a.x != b.x && a.y != b.y) {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.x == b.x && a.y == b.y || a.x != b.x && a.y != b.y`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:165:22
[INFO] [stderr]     |
[INFO] [stderr] 165 |     pub fn as_offset(&self) -> (i64, i64) {
[INFO] [stderr]     |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop.
[INFO] [stderr]    --> src/lib.rs:248:15
[INFO] [stderr]     |
[INFO] [stderr] 248 |         while self.length > 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::while_immutable_condition)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:292:17
[INFO] [stderr]     |
[INFO] [stderr] 292 |     pub fn code(&self) -> char {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `tilewater`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/agents.rs:34:29
[INFO] [stderr]    |
[INFO] [stderr] 34 |             .or_insert_with(|| HashMap::new())
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashMap::new`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/agents.rs:170:14
[INFO] [stderr]     |
[INFO] [stderr] 170 |         rng: &mut Box<RngCore>,
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^ help: try: `&mut RngCore`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/map.rs:63:29
[INFO] [stderr]    |
[INFO] [stderr] 63 |             .or_insert_with(|| Vec::new())
[INFO] [stderr]    |                             ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/render_to_piston.rs:226:68
[INFO] [stderr]     |
[INFO] [stderr] 226 |     fn draw_building(c: Context, g: &mut G2d, l: Coord2, building: &Building) {
[INFO] [stderr]     |                                                                    ^^^^^^^^^ help: consider passing by value instead: `Building`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: equal expressions as operands to `/`
[INFO] [stderr]    --> src/render_to_piston.rs:262:42
[INFO] [stderr]     |
[INFO] [stderr] 262 |             [0.0 / 255.0, 162.0 / 255.0, 255.0 / 255.0, 1.0],
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::eq_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/routing.rs:98:62
[INFO] [stderr]    |
[INFO] [stderr] 98 | pub fn route_to_any(map: &Map, start_pos: Coord2, goals_pos: &Vec<Coord2>) -> Route {
[INFO] [stderr]    |                                                              ^^^^^^^^^^^^ help: change this to: `&[Coord2]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/routing.rs:166:11
[INFO] [stderr]     |
[INFO] [stderr] 166 |     match tile.clone() {
[INFO] [stderr]     |           ^^^^^^^^^^^^ help: try removing the `clone` call: `tile`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:131:22
[INFO] [stderr]     |
[INFO] [stderr] 131 |     pub fn as_offset(&self) -> Coord2 {
[INFO] [stderr]     |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/lib.rs:150:12
[INFO] [stderr]     |
[INFO] [stderr] 150 |         if (a.x == b.x && a.y == b.y) || (a.x != b.x && a.y != b.y) {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.x == b.x && a.y == b.y || a.x != b.x && a.y != b.y`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:165:22
[INFO] [stderr]     |
[INFO] [stderr] 165 |     pub fn as_offset(&self) -> (i64, i64) {
[INFO] [stderr]     |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop.
[INFO] [stderr]    --> src/lib.rs:248:15
[INFO] [stderr]     |
[INFO] [stderr] 248 |         while self.length > 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::while_immutable_condition)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:292:17
[INFO] [stderr]     |
[INFO] [stderr] 292 |     pub fn code(&self) -> char {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `tilewater`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "71fc29532c77a06d60212c9d93000bae3237bb6a4c37bf7903be87da61a7619f"`
[INFO] running `"docker" "rm" "-f" "71fc29532c77a06d60212c9d93000bae3237bb6a4c37bf7903be87da61a7619f"`
[INFO] [stdout] 71fc29532c77a06d60212c9d93000bae3237bb6a4c37bf7903be87da61a7619f