[INFO] updating cached repository 46bit/comms
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/46bit/comms
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/46bit/comms" "work/ex/clippy-test-run/sources/stable/gh/46bit/comms"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/46bit/comms'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/46bit/comms" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/46bit/comms"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/46bit/comms'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6d96ab1c55c57c5ae6d84e9064756cabe32135c4
[INFO] sha for GitHub repo 46bit/comms: 6d96ab1c55c57c5ae6d84e9064756cabe32135c4
[INFO] validating manifest of 46bit/comms on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of 46bit/comms on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing 46bit/comms
[INFO] finished frobbing 46bit/comms
[INFO] frobbed toml for 46bit/comms written to work/ex/clippy-test-run/sources/stable/gh/46bit/comms/Cargo.toml
[INFO] started frobbing 46bit/comms
[INFO] finished frobbing 46bit/comms
[INFO] frobbed toml for 46bit/comms written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/46bit/comms/Cargo.toml
[INFO] crate 46bit/comms has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting 46bit/comms against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/46bit/comms:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 44d82544cd503269b30e29c7ab342bbe4da10aaa1d93ca51c114ba7ff2751873
[INFO] running `"docker" "start" "-a" "44d82544cd503269b30e29c7ab342bbe4da10aaa1d93ca51c114ba7ff2751873"`
[INFO] [stderr]     Checking comms v0.1.4 (/opt/crater/workdir)
[INFO] [stderr]     Checking quickcheck v0.2.27
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/client/mod.rs:47:35
[INFO] [stderr]    |
[INFO] [stderr] 47 |         Client::new(id, Unsplit { tx: tx, rx: rx })
[INFO] [stderr]    |                                   ^^^^^^ help: replace it with: `tx`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/client/mod.rs:47:43
[INFO] [stderr]    |
[INFO] [stderr] 47 |         Client::new(id, Unsplit { tx: tx, rx: rx })
[INFO] [stderr]    |                                           ^^^^^^ help: replace it with: `rx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/client/mod.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |             id: id,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/room/broadcast.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             msg: msg,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `msg`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/room/mod.rs:179:17
[INFO] [stderr]     |
[INFO] [stderr] 179 |                 return Err(self.err_for_disconnect(id));
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(self.err_for_disconnect(id))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/client/mod.rs:142:32
[INFO] [stderr]     |
[INFO] [stderr] 142 |     pub fn into_inner(self) -> (I, Result<C, Disconnect<C::SinkError, C::Error>>) {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/room/receive.rs:29:36
[INFO] [stderr]    |
[INFO] [stderr] 29 |     pub fn into_inner(mut self) -> (Room<I, C>, Vec<(I, C::Item)>) {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/client/mod.rs:47:35
[INFO] [stderr]    |
[INFO] [stderr] 47 |         Client::new(id, Unsplit { tx: tx, rx: rx })
[INFO] [stderr]    |                                   ^^^^^^ help: replace it with: `tx`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/client/mod.rs:47:43
[INFO] [stderr]    |
[INFO] [stderr] 47 |         Client::new(id, Unsplit { tx: tx, rx: rx })
[INFO] [stderr]    |                                           ^^^^^^ help: replace it with: `rx`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/client/mod.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |             id: id,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/room/broadcast.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             msg: msg,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `msg`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/room/mod.rs:179:17
[INFO] [stderr]     |
[INFO] [stderr] 179 |                 return Err(self.err_for_disconnect(id));
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(self.err_for_disconnect(id))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/client/receive.rs:290:72
[INFO] [stderr]     |
[INFO] [stderr] 290 |                     let client = Client::new_from_split(0, tx.clone(), rx.clone());
[INFO] [stderr]     |                                                                        ^^^^^^^^^^ help: try removing the `clone` call: `rx`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/client/receive.rs:324:72
[INFO] [stderr]     |
[INFO] [stderr] 324 |                     let client = Client::new_from_split(0, tx.clone(), rx.clone());
[INFO] [stderr]     |                                                                        ^^^^^^^^^^ help: try removing the `clone` call: `rx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/client/mod.rs:142:32
[INFO] [stderr]     |
[INFO] [stderr] 142 |     pub fn into_inner(self) -> (I, Result<C, Disconnect<C::SinkError, C::Error>>) {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/client/mod.rs:336:43
[INFO] [stderr]     |
[INFO] [stderr] 336 |         let (_, _, client0) = mock_client(client0_id.clone(), 1);
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 336 |         let (_, _, client0) = mock_client(&(*client0_id).clone(), 1);
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 336 |         let (_, _, client0) = mock_client(&str::clone(client0_id), 1);
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/client/mod.rs:338:43
[INFO] [stderr]     |
[INFO] [stderr] 338 |         let (_, _, client1) = mock_client(client1_id.clone(), 1);
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 338 |         let (_, _, client1) = mock_client(&(*client1_id).clone(), 1);
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 338 |         let (_, _, client1) = mock_client(&str::clone(client1_id), 1);
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/client/mod.rs:478:9
[INFO] [stderr]     |
[INFO] [stderr] 478 |         let _ = rx_from_client.close();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/room/receive.rs:29:36
[INFO] [stderr]    |
[INFO] [stderr] 29 |     pub fn into_inner(mut self) -> (Room<I, C>, Vec<(I, C::Item)>) {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/room/mod.rs:330:22
[INFO] [stderr]     |
[INFO] [stderr] 330 |             if id == "client0".to_string() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^ help: try: `"client0"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `comms`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "44d82544cd503269b30e29c7ab342bbe4da10aaa1d93ca51c114ba7ff2751873"`
[INFO] running `"docker" "rm" "-f" "44d82544cd503269b30e29c7ab342bbe4da10aaa1d93ca51c114ba7ff2751873"`
[INFO] [stdout] 44d82544cd503269b30e29c7ab342bbe4da10aaa1d93ca51c114ba7ff2751873