[INFO] updating cached repository 4102-rustaceans/rust-blackjack [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/4102-rustaceans/rust-blackjack [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/4102-rustaceans/rust-blackjack" "work/ex/clippy-test-run/sources/stable/gh/4102-rustaceans/rust-blackjack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/4102-rustaceans/rust-blackjack'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/4102-rustaceans/rust-blackjack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/4102-rustaceans/rust-blackjack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/4102-rustaceans/rust-blackjack'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 61fae1ade0ad3b1ddfecac623417cab0dd28169d [INFO] sha for GitHub repo 4102-rustaceans/rust-blackjack: 61fae1ade0ad3b1ddfecac623417cab0dd28169d [INFO] validating manifest of 4102-rustaceans/rust-blackjack on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of 4102-rustaceans/rust-blackjack on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing 4102-rustaceans/rust-blackjack [INFO] finished frobbing 4102-rustaceans/rust-blackjack [INFO] frobbed toml for 4102-rustaceans/rust-blackjack written to work/ex/clippy-test-run/sources/stable/gh/4102-rustaceans/rust-blackjack/Cargo.toml [INFO] started frobbing 4102-rustaceans/rust-blackjack [INFO] finished frobbing 4102-rustaceans/rust-blackjack [INFO] frobbed toml for 4102-rustaceans/rust-blackjack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/4102-rustaceans/rust-blackjack/Cargo.toml [INFO] crate 4102-rustaceans/rust-blackjack has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting 4102-rustaceans/rust-blackjack against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/4102-rustaceans/rust-blackjack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d39934bf846dc8b5d0775fe2c8ca1686a8b0013b02c62b3c4d0697e686dfa9e4 [INFO] running `"docker" "start" "-a" "d39934bf846dc8b5d0775fe2c8ca1686a8b0013b02c62b3c4d0697e686dfa9e4"` [INFO] [stderr] Checking rust-blackjack v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | let mut dealerScore = getHandValue(&dealer.hand); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | let mut playerScore = getHandValue(&player.hand); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | name: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `playerHold` should have a snake case name such as `player_hold` [INFO] [stderr] --> src/main.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | let mut playerHold = false; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `dealerHold` should have a snake case name such as `dealer_hold` [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | let mut dealerHold = false; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `playerBust` should have a snake case name such as `player_bust` [INFO] [stderr] --> src/main.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | let mut playerBust = false; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `dealerBust` should have a snake case name such as `dealer_bust` [INFO] [stderr] --> src/main.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | let mut dealerBust = false; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `dealerScore` should have a snake case name such as `dealer_score` [INFO] [stderr] --> src/main.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | let mut dealerScore = getHandValue(&dealer.hand); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `playerScore` should have a snake case name such as `player_score` [INFO] [stderr] --> src/main.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | let mut playerScore = getHandValue(&player.hand); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function `createDeck` should have a snake case name such as `create_deck` [INFO] [stderr] --> src/main.rs:187:1 [INFO] [stderr] | [INFO] [stderr] 187 | / fn createDeck() -> Vec { [INFO] [stderr] 188 | | let mut deck: Vec = Vec::new(); [INFO] [stderr] 189 | | let suits = vec!["Clubs", "Diamonds", "Hearts", "Spades"]; [INFO] [stderr] 190 | | let ranks = vec!["Ace", "Two", "Three", "Four", "Five", "Six", "Seven", "Eight", "Nine", "Ten", "Jack", "Queen", "King"]; [INFO] [stderr] ... | [INFO] [stderr] 198 | | deck [INFO] [stderr] 199 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:201:23 [INFO] [stderr] | [INFO] [stderr] 201 | fn getHandValue(hand: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Card]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function `getHandValue` should have a snake case name such as `get_hand_value` [INFO] [stderr] --> src/main.rs:201:1 [INFO] [stderr] | [INFO] [stderr] 201 | / fn getHandValue(hand: &Vec) -> u32 { [INFO] [stderr] 202 | | let mut aces = 0; [INFO] [stderr] 203 | | let mut value = 0; [INFO] [stderr] 204 | | [INFO] [stderr] ... | [INFO] [stderr] 233 | | value [INFO] [stderr] 234 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:236:20 [INFO] [stderr] | [INFO] [stderr] 236 | fn printHand(hand: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Card]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function `printHand` should have a snake case name such as `print_hand` [INFO] [stderr] --> src/main.rs:236:1 [INFO] [stderr] | [INFO] [stderr] 236 | / fn printHand(hand: &Vec) -> String { [INFO] [stderr] 237 | | let mut inHand: String = String::new(); [INFO] [stderr] 238 | | [INFO] [stderr] 239 | | for card in hand { [INFO] [stderr] ... | [INFO] [stderr] 244 | | inHand [INFO] [stderr] 245 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: variable `inHand` should have a snake case name such as `in_hand` [INFO] [stderr] --> src/main.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | let mut inHand: String = String::new(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `curCard` should have a snake case name such as `cur_card` [INFO] [stderr] --> src/main.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | let mut curCard: String = format!("{} of {}", card.rank, card.suit); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | let mut dealerScore = getHandValue(&dealer.hand); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | let mut playerScore = getHandValue(&player.hand); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | name: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `playerHold` should have a snake case name such as `player_hold` [INFO] [stderr] --> src/main.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | let mut playerHold = false; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `dealerHold` should have a snake case name such as `dealer_hold` [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | let mut dealerHold = false; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `playerBust` should have a snake case name such as `player_bust` [INFO] [stderr] --> src/main.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | let mut playerBust = false; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `dealerBust` should have a snake case name such as `dealer_bust` [INFO] [stderr] --> src/main.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | let mut dealerBust = false; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `dealerScore` should have a snake case name such as `dealer_score` [INFO] [stderr] --> src/main.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | let mut dealerScore = getHandValue(&dealer.hand); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `playerScore` should have a snake case name such as `player_score` [INFO] [stderr] --> src/main.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | let mut playerScore = getHandValue(&player.hand); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function `createDeck` should have a snake case name such as `create_deck` [INFO] [stderr] --> src/main.rs:187:1 [INFO] [stderr] | [INFO] [stderr] 187 | / fn createDeck() -> Vec { [INFO] [stderr] 188 | | let mut deck: Vec = Vec::new(); [INFO] [stderr] 189 | | let suits = vec!["Clubs", "Diamonds", "Hearts", "Spades"]; [INFO] [stderr] 190 | | let ranks = vec!["Ace", "Two", "Three", "Four", "Five", "Six", "Seven", "Eight", "Nine", "Ten", "Jack", "Queen", "King"]; [INFO] [stderr] ... | [INFO] [stderr] 198 | | deck [INFO] [stderr] 199 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:201:23 [INFO] [stderr] | [INFO] [stderr] 201 | fn getHandValue(hand: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Card]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function `getHandValue` should have a snake case name such as `get_hand_value` [INFO] [stderr] --> src/main.rs:201:1 [INFO] [stderr] | [INFO] [stderr] 201 | / fn getHandValue(hand: &Vec) -> u32 { [INFO] [stderr] 202 | | let mut aces = 0; [INFO] [stderr] 203 | | let mut value = 0; [INFO] [stderr] 204 | | [INFO] [stderr] ... | [INFO] [stderr] 233 | | value [INFO] [stderr] 234 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:236:20 [INFO] [stderr] | [INFO] [stderr] 236 | fn printHand(hand: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Card]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function `printHand` should have a snake case name such as `print_hand` [INFO] [stderr] --> src/main.rs:236:1 [INFO] [stderr] | [INFO] [stderr] 236 | / fn printHand(hand: &Vec) -> String { [INFO] [stderr] 237 | | let mut inHand: String = String::new(); [INFO] [stderr] 238 | | [INFO] [stderr] 239 | | for card in hand { [INFO] [stderr] ... | [INFO] [stderr] 244 | | inHand [INFO] [stderr] 245 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: variable `inHand` should have a snake case name such as `in_hand` [INFO] [stderr] --> src/main.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | let mut inHand: String = String::new(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `curCard` should have a snake case name such as `cur_card` [INFO] [stderr] --> src/main.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | let mut curCard: String = format!("{} of {}", card.rank, card.suit); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.32s [INFO] running `"docker" "inspect" "d39934bf846dc8b5d0775fe2c8ca1686a8b0013b02c62b3c4d0697e686dfa9e4"` [INFO] running `"docker" "rm" "-f" "d39934bf846dc8b5d0775fe2c8ca1686a8b0013b02c62b3c4d0697e686dfa9e4"` [INFO] [stdout] d39934bf846dc8b5d0775fe2c8ca1686a8b0013b02c62b3c4d0697e686dfa9e4