[INFO] updating cached repository 3a4oT/learning_rust_fibonacci [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/3a4oT/learning_rust_fibonacci [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/3a4oT/learning_rust_fibonacci" "work/ex/clippy-test-run/sources/stable/gh/3a4oT/learning_rust_fibonacci"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/3a4oT/learning_rust_fibonacci'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/3a4oT/learning_rust_fibonacci" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/3a4oT/learning_rust_fibonacci"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/3a4oT/learning_rust_fibonacci'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bdf60b098b5798fa7e6eb6f74ae35fb01a746b9d [INFO] sha for GitHub repo 3a4oT/learning_rust_fibonacci: bdf60b098b5798fa7e6eb6f74ae35fb01a746b9d [INFO] validating manifest of 3a4oT/learning_rust_fibonacci on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of 3a4oT/learning_rust_fibonacci on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing 3a4oT/learning_rust_fibonacci [INFO] finished frobbing 3a4oT/learning_rust_fibonacci [INFO] frobbed toml for 3a4oT/learning_rust_fibonacci written to work/ex/clippy-test-run/sources/stable/gh/3a4oT/learning_rust_fibonacci/Cargo.toml [INFO] started frobbing 3a4oT/learning_rust_fibonacci [INFO] finished frobbing 3a4oT/learning_rust_fibonacci [INFO] frobbed toml for 3a4oT/learning_rust_fibonacci written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/3a4oT/learning_rust_fibonacci/Cargo.toml [INFO] crate 3a4oT/learning_rust_fibonacci has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting 3a4oT/learning_rust_fibonacci against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/3a4oT/learning_rust_fibonacci:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 36bd2e836e64ae2ef4de7564cf451cc126ba32e5f58f3c59cdb4abab7635a8aa [INFO] running `"docker" "start" "-a" "36bd2e836e64ae2ef4de7564cf451cc126ba32e5f58f3c59cdb4abab7635a8aa"` [INFO] [stderr] Checking learning_rust_fibonacci v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return seq.last().cloned().unwrap_or(0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `seq.last().cloned().unwrap_or(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return seq.last().cloned().unwrap_or(0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `seq.last().cloned().unwrap_or(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | n = n + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | n = n + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.04s [INFO] running `"docker" "inspect" "36bd2e836e64ae2ef4de7564cf451cc126ba32e5f58f3c59cdb4abab7635a8aa"` [INFO] running `"docker" "rm" "-f" "36bd2e836e64ae2ef4de7564cf451cc126ba32e5f58f3c59cdb4abab7635a8aa"` [INFO] [stdout] 36bd2e836e64ae2ef4de7564cf451cc126ba32e5f58f3c59cdb4abab7635a8aa