[INFO] updating cached repository 3541/shell
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/3541/shell
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/3541/shell" "work/ex/clippy-test-run/sources/stable/gh/3541/shell"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/3541/shell'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/3541/shell" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/3541/shell"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/3541/shell'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 173aa3509cd1cccc8422ffee622efb2fb0661406
[INFO] sha for GitHub repo 3541/shell: 173aa3509cd1cccc8422ffee622efb2fb0661406
[INFO] validating manifest of 3541/shell on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of 3541/shell on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing 3541/shell
[INFO] finished frobbing 3541/shell
[INFO] frobbed toml for 3541/shell written to work/ex/clippy-test-run/sources/stable/gh/3541/shell/Cargo.toml
[INFO] started frobbing 3541/shell
[INFO] finished frobbing 3541/shell
[INFO] frobbed toml for 3541/shell written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/3541/shell/Cargo.toml
[INFO] crate 3541/shell has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting 3541/shell against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/3541/shell:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3dda12b2ad62208ae6819a1af67d3ba211ea12ea2af35d670378314428129846
[INFO] running `"docker" "start" "-a" "3dda12b2ad62208ae6819a1af67d3ba211ea12ea2af35d670378314428129846"`
[INFO] [stderr]     Checking shell v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/builtin.rs:8:24
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub const BUILTINS: [(&'static str, &'static str, fn(Vec<&str>, &nix::sys::termios::Termios)); 3] = [
[INFO] [stderr]   |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/builtin.rs:8:38
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub const BUILTINS: [(&'static str, &'static str, fn(Vec<&str>, &nix::sys::termios::Termios)); 3] = [
[INFO] [stderr]   |                                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/builtin.rs:8:24
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub const BUILTINS: [(&'static str, &'static str, fn(Vec<&str>, &nix::sys::termios::Termios)); 3] = [
[INFO] [stderr]   |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/builtin.rs:8:38
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub const BUILTINS: [(&'static str, &'static str, fn(Vec<&str>, &nix::sys::termios::Termios)); 3] = [
[INFO] [stderr]   |                                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `c_line` is never read
[INFO] [stderr]   --> src/main.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |     let mut c_line = String::new();
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]  --> src/builtin.rs:8:21
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub const BUILTINS: [(&'static str, &'static str, fn(Vec<&str>, &nix::sys::termios::Termios)); 3] = [
[INFO] [stderr]   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/builtin.rs:36:8
[INFO] [stderr]    |
[INFO] [stderr] 36 |     if args.len() < 1 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/builtin.rs:48:8
[INFO] [stderr]    |
[INFO] [stderr] 48 |     if args.len() < 1 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/builtin.rs:53:28
[INFO] [stderr]    |
[INFO] [stderr] 53 |         for bn in BUILTINS.into_iter() {
[INFO] [stderr]    |                            ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::into_iter_on_array)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/builtin.rs:57:28
[INFO] [stderr]    |
[INFO] [stderr] 57 |         for bn in BUILTINS.into_iter() {
[INFO] [stderr]    |                            ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `c_line` is never read
[INFO] [stderr]   --> src/main.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |     let mut c_line = String::new();
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/builtin.rs:68:8
[INFO] [stderr]    |
[INFO] [stderr] 68 |     if args.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/main.rs:29:14
[INFO] [stderr]    |
[INFO] [stderr] 29 | fn exec_loop<'a>(term_save: &nix::sys::termios::Termios) {
[INFO] [stderr]    |              ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:57:17
[INFO] [stderr]    |
[INFO] [stderr] 57 | fn repaint(ret: &String, pos: usize) {
[INFO] [stderr]    |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:110:34
[INFO] [stderr]     |
[INFO] [stderr] 110 |                 if escape_seq || quote_stack.len() > 0 {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!quote_stack.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/main.rs:186:8
[INFO] [stderr]     |
[INFO] [stderr] 186 |     if args.len() < 1 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]    --> src/main.rs:190:33
[INFO] [stderr]     |
[INFO] [stderr] 190 |     for bn in builtin::BUILTINS.into_iter() {
[INFO] [stderr]     |                                 ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]  --> src/builtin.rs:8:21
[INFO] [stderr]   |
[INFO] [stderr] 8 | pub const BUILTINS: [(&'static str, &'static str, fn(Vec<&str>, &nix::sys::termios::Termios)); 3] = [
[INFO] [stderr]   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `shell`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/builtin.rs:36:8
[INFO] [stderr]    |
[INFO] [stderr] 36 |     if args.len() < 1 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/builtin.rs:48:8
[INFO] [stderr]    |
[INFO] [stderr] 48 |     if args.len() < 1 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/builtin.rs:53:28
[INFO] [stderr]    |
[INFO] [stderr] 53 |         for bn in BUILTINS.into_iter() {
[INFO] [stderr]    |                            ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::into_iter_on_array)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]   --> src/builtin.rs:57:28
[INFO] [stderr]    |
[INFO] [stderr] 57 |         for bn in BUILTINS.into_iter() {
[INFO] [stderr]    |                            ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/builtin.rs:68:8
[INFO] [stderr]    |
[INFO] [stderr] 68 |     if args.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/main.rs:29:14
[INFO] [stderr]    |
[INFO] [stderr] 29 | fn exec_loop<'a>(term_save: &nix::sys::termios::Termios) {
[INFO] [stderr]    |              ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:57:17
[INFO] [stderr]    |
[INFO] [stderr] 57 | fn repaint(ret: &String, pos: usize) {
[INFO] [stderr]    |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:110:34
[INFO] [stderr]     |
[INFO] [stderr] 110 |                 if escape_seq || quote_stack.len() > 0 {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!quote_stack.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/main.rs:186:8
[INFO] [stderr]     |
[INFO] [stderr] 186 |     if args.len() < 1 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]    --> src/main.rs:190:33
[INFO] [stderr]     |
[INFO] [stderr] 190 |     for bn in builtin::BUILTINS.into_iter() {
[INFO] [stderr]     |                                 ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `shell`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "3dda12b2ad62208ae6819a1af67d3ba211ea12ea2af35d670378314428129846"`
[INFO] running `"docker" "rm" "-f" "3dda12b2ad62208ae6819a1af67d3ba211ea12ea2af35d670378314428129846"`
[INFO] [stdout] 3dda12b2ad62208ae6819a1af67d3ba211ea12ea2af35d670378314428129846