[INFO] updating cached repository 198d/cs_review [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/198d/cs_review [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/198d/cs_review" "work/ex/clippy-test-run/sources/stable/gh/198d/cs_review"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/198d/cs_review'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/198d/cs_review" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/198d/cs_review"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/198d/cs_review'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b5e366f48d630028cc85c8ac05f4a716fc711dd4 [INFO] sha for GitHub repo 198d/cs_review: b5e366f48d630028cc85c8ac05f4a716fc711dd4 [INFO] validating manifest of 198d/cs_review on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of 198d/cs_review on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing 198d/cs_review [INFO] finished frobbing 198d/cs_review [INFO] frobbed toml for 198d/cs_review written to work/ex/clippy-test-run/sources/stable/gh/198d/cs_review/Cargo.toml [INFO] started frobbing 198d/cs_review [INFO] finished frobbing 198d/cs_review [INFO] frobbed toml for 198d/cs_review written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/198d/cs_review/Cargo.toml [INFO] crate 198d/cs_review has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting 198d/cs_review against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/198d/cs_review:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 655e9c377c94feed5948756a881016b7ee694e0004b10e66f20d8aa1d25659f1 [INFO] running `"docker" "start" "-a" "655e9c377c94feed5948756a881016b7ee694e0004b10e66f20d8aa1d25659f1"` [INFO] [stderr] Compiling ndarray v0.7.2 [INFO] [stderr] Checking num-complex v0.1.35 [INFO] [stderr] Checking cs_review v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trees/binary.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | Node { data: data, left: None, right: None })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trees/binary.rs:142:18 [INFO] [stderr] | [INFO] [stderr] 142 | Node { data: data, left: None, right: None })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trees/binary.rs:232:54 [INFO] [stderr] | [INFO] [stderr] 232 | Some(Box::new(Node { data: Data { value: data }, left: left, right: right })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trees/binary.rs:232:66 [INFO] [stderr] | [INFO] [stderr] 232 | Some(Box::new(Node { data: Data { value: data }, left: left, right: right })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trees/binary.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | Node { data: data, left: None, right: None })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trees/binary.rs:142:18 [INFO] [stderr] | [INFO] [stderr] 142 | Node { data: data, left: None, right: None })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trees/binary.rs:232:54 [INFO] [stderr] | [INFO] [stderr] 232 | Some(Box::new(Node { data: Data { value: data }, left: left, right: right })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trees/binary.rs:232:66 [INFO] [stderr] | [INFO] [stderr] 232 | Some(Box::new(Node { data: Data { value: data }, left: left, right: right })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:3:13 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use(s)] [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trees/binary.rs:92:28 [INFO] [stderr] | [INFO] [stderr] 92 | &None => return Some(node), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(node)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trees/binary.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | return Some(node); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trees/binary.rs:102:19 [INFO] [stderr] | [INFO] [stderr] 102 | None => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:3:13 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use(s)] [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trees/binary.rs:92:28 [INFO] [stderr] | [INFO] [stderr] 92 | &None => return Some(node), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(node)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trees/binary.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | return Some(node); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trees/binary.rs:102:19 [INFO] [stderr] | [INFO] [stderr] 102 | None => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sorting.rs:2:26 [INFO] [stderr] | [INFO] [stderr] 2 | pub fn selection_sort(mut data: &mut [T]) [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sorting.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn insertion_sort(mut data: &mut [T]) [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sorting.rs:110:19 [INFO] [stderr] | [INFO] [stderr] 110 | fn sift_down(mut data: &mut [T], start: usize, end: usize) [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sorting.rs:2:26 [INFO] [stderr] | [INFO] [stderr] 2 | pub fn selection_sort(mut data: &mut [T]) [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sorting.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn insertion_sort(mut data: &mut [T]) [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sorting.rs:110:19 [INFO] [stderr] | [INFO] [stderr] 110 | fn sift_down(mut data: &mut [T], start: usize, end: usize) [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `insert` [INFO] [stderr] --> src/trees/binary.rs:128:3 [INFO] [stderr] | [INFO] [stderr] 128 | fn insert(&mut self, data: T) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `delete` [INFO] [stderr] --> src/trees/binary.rs:147:3 [INFO] [stderr] | [INFO] [stderr] 147 | fn delete(&mut self, data: &T) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `find` [INFO] [stderr] --> src/trees/binary.rs:187:3 [INFO] [stderr] | [INFO] [stderr] 187 | fn find<'a>(&'a self, data: &T) -> &Edge { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `find_mut` [INFO] [stderr] --> src/trees/binary.rs:199:3 [INFO] [stderr] | [INFO] [stderr] 199 | fn find_mut<'a>(&'a mut self, data: &T) -> &'a mut Edge { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sorting.rs:78:6 [INFO] [stderr] | [INFO] [stderr] 78 | if data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sorting.rs:78:6 [INFO] [stderr] | [INFO] [stderr] 78 | if data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/trees/binary.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | / match current { [INFO] [stderr] 24 | | &Some(ref node) => target.cmp(&node.data), [INFO] [stderr] 25 | | &None => Ordering::Equal [INFO] [stderr] 26 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *current { [INFO] [stderr] 24 | Some(ref node) => target.cmp(&node.data), [INFO] [stderr] 25 | None => Ordering::Equal [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/trees/binary.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | current = match current { [INFO] [stderr] | _________________^ [INFO] [stderr] 63 | | &Some(ref node) => { [INFO] [stderr] 64 | | path.push(current); [INFO] [stderr] 65 | | match *order { [INFO] [stderr] ... | [INFO] [stderr] 70 | | &None => break [INFO] [stderr] 71 | | }; [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | current = match *current { [INFO] [stderr] 63 | Some(ref node) => { [INFO] [stderr] 64 | path.push(current); [INFO] [stderr] 65 | match *order { [INFO] [stderr] 66 | TraversalOrder::Increasing => &node.left, [INFO] [stderr] 67 | TraversalOrder::Decreasing => &node.right [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/trees/binary.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | / match edge { [INFO] [stderr] 86 | | &Some(ref node) => { [INFO] [stderr] 87 | | let subtree = match *order { [INFO] [stderr] 88 | | TraversalOrder::Increasing => &node.right, [INFO] [stderr] ... | [INFO] [stderr] 99 | | &None => panic!("Edge in iterator path is None") [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | match *edge { [INFO] [stderr] 86 | Some(ref node) => { [INFO] [stderr] 87 | let subtree = match *order { [INFO] [stderr] 88 | TraversalOrder::Increasing => &node.right, [INFO] [stderr] 89 | TraversalOrder::Decreasing => &node.left [INFO] [stderr] 90 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/trees/binary.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | / match current { [INFO] [stderr] 24 | | &Some(ref node) => target.cmp(&node.data), [INFO] [stderr] 25 | | &None => Ordering::Equal [INFO] [stderr] 26 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *current { [INFO] [stderr] 24 | Some(ref node) => target.cmp(&node.data), [INFO] [stderr] 25 | None => Ordering::Equal [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/trees/binary.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | current = match current { [INFO] [stderr] | _________________^ [INFO] [stderr] 63 | | &Some(ref node) => { [INFO] [stderr] 64 | | path.push(current); [INFO] [stderr] 65 | | match *order { [INFO] [stderr] ... | [INFO] [stderr] 70 | | &None => break [INFO] [stderr] 71 | | }; [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | current = match *current { [INFO] [stderr] 63 | Some(ref node) => { [INFO] [stderr] 64 | path.push(current); [INFO] [stderr] 65 | match *order { [INFO] [stderr] 66 | TraversalOrder::Increasing => &node.left, [INFO] [stderr] 67 | TraversalOrder::Decreasing => &node.right [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/trees/binary.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | / match edge { [INFO] [stderr] 86 | | &Some(ref node) => { [INFO] [stderr] 87 | | let subtree = match *order { [INFO] [stderr] 88 | | TraversalOrder::Increasing => &node.right, [INFO] [stderr] ... | [INFO] [stderr] 99 | | &None => panic!("Edge in iterator path is None") [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | match *edge { [INFO] [stderr] 86 | Some(ref node) => { [INFO] [stderr] 87 | let subtree = match *order { [INFO] [stderr] 88 | TraversalOrder::Increasing => &node.right, [INFO] [stderr] 89 | TraversalOrder::Decreasing => &node.left [INFO] [stderr] 90 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/trees/binary.rs:222:56 [INFO] [stderr] | [INFO] [stderr] 222 | fn assert_edge<'a, T>(edge: &'a Edge, data: T) -> &'a Box> [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&'a Node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/trees/binary.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | / match edge { [INFO] [stderr] 225 | | &Some(ref node) if node.data == data => node, [INFO] [stderr] 226 | | &Some(_) => panic!("node data does not match"), [INFO] [stderr] 227 | | &None => panic!("edge is none") [INFO] [stderr] 228 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 224 | match *edge { [INFO] [stderr] 225 | Some(ref node) if node.data == data => node, [INFO] [stderr] 226 | Some(_) => panic!("node data does not match"), [INFO] [stderr] 227 | None => panic!("edge is none") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/trees/binary.rs:323:13 [INFO] [stderr] | [INFO] [stderr] 323 | assert!(values.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.85s [INFO] running `"docker" "inspect" "655e9c377c94feed5948756a881016b7ee694e0004b10e66f20d8aa1d25659f1"` [INFO] running `"docker" "rm" "-f" "655e9c377c94feed5948756a881016b7ee694e0004b10e66f20d8aa1d25659f1"` [INFO] [stdout] 655e9c377c94feed5948756a881016b7ee694e0004b10e66f20d8aa1d25659f1