[INFO] updating cached repository 13pgeiser/rpexec [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/13pgeiser/rpexec [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/13pgeiser/rpexec" "work/ex/clippy-test-run/sources/stable/gh/13pgeiser/rpexec"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/13pgeiser/rpexec'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/13pgeiser/rpexec" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/13pgeiser/rpexec"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/13pgeiser/rpexec'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5fb66bbb2d9c60123723a1d32fdb8ad41d993421 [INFO] sha for GitHub repo 13pgeiser/rpexec: 5fb66bbb2d9c60123723a1d32fdb8ad41d993421 [INFO] validating manifest of 13pgeiser/rpexec on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of 13pgeiser/rpexec on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing 13pgeiser/rpexec [INFO] finished frobbing 13pgeiser/rpexec [INFO] frobbed toml for 13pgeiser/rpexec written to work/ex/clippy-test-run/sources/stable/gh/13pgeiser/rpexec/Cargo.toml [INFO] started frobbing 13pgeiser/rpexec [INFO] finished frobbing 13pgeiser/rpexec [INFO] frobbed toml for 13pgeiser/rpexec written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/13pgeiser/rpexec/Cargo.toml [INFO] crate 13pgeiser/rpexec has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting 13pgeiser/rpexec against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/13pgeiser/rpexec:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 04c9d125df00e0bad2795fe63d0b291a22da1c59e4d1a71f459b11c26ec3864f [INFO] running `"docker" "start" "-a" "04c9d125df00e0bad2795fe63d0b291a22da1c59e4d1a71f459b11c26ec3864f"` [INFO] [stderr] Checking serde_json v1.0.11 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking docopt v0.8.3 [INFO] [stderr] Checking tera v0.10.10 [INFO] [stderr] Checking rpexec v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/main.rs:74:34 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn basename(value: Value, _: HashMap) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 74 | pub fn basename(value: Value, _: HashMap) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/main.rs:81:32 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn parent(value: Value, _: HashMap) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 81 | pub fn parent(value: Value, _: HashMap) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | / let output; [INFO] [stderr] 91 | | if cfg!(target_os = "windows") { [INFO] [stderr] 92 | | output = Command::new("cmd.exe").args(&["/C", &cmdline]).output().unwrap(); [INFO] [stderr] 93 | | } else { [INFO] [stderr] 94 | | output = Command::new("sh").args(&["-c", &cmdline]).output().unwrap(); [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let output = if cfg!(target_os = "windows") { Command::new("cmd.exe").args(&["/C", &cmdline]).output().unwrap() } else { Command::new("sh").args(&["-c", &cmdline]).output().unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:106:47 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn handle_path(p : &path::PathBuf, cmds : &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / match env_logger::init() { [INFO] [stderr] 144 | | Err(why) => panic!("{:?}", why), [INFO] [stderr] 145 | | Ok(_) => () [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = env_logger::init() { panic!("{:?}", why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/main.rs:74:34 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn basename(value: Value, _: HashMap) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 74 | pub fn basename(value: Value, _: HashMap) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/main.rs:81:32 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn parent(value: Value, _: HashMap) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 81 | pub fn parent(value: Value, _: HashMap) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | / let output; [INFO] [stderr] 91 | | if cfg!(target_os = "windows") { [INFO] [stderr] 92 | | output = Command::new("cmd.exe").args(&["/C", &cmdline]).output().unwrap(); [INFO] [stderr] 93 | | } else { [INFO] [stderr] 94 | | output = Command::new("sh").args(&["-c", &cmdline]).output().unwrap(); [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let output = if cfg!(target_os = "windows") { Command::new("cmd.exe").args(&["/C", &cmdline]).output().unwrap() } else { Command::new("sh").args(&["-c", &cmdline]).output().unwrap() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:106:47 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn handle_path(p : &path::PathBuf, cmds : &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / match env_logger::init() { [INFO] [stderr] 144 | | Err(why) => panic!("{:?}", why), [INFO] [stderr] 145 | | Ok(_) => () [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = env_logger::init() { panic!("{:?}", why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.00s [INFO] running `"docker" "inspect" "04c9d125df00e0bad2795fe63d0b291a22da1c59e4d1a71f459b11c26ec3864f"` [INFO] running `"docker" "rm" "-f" "04c9d125df00e0bad2795fe63d0b291a22da1c59e4d1a71f459b11c26ec3864f"` [INFO] [stdout] 04c9d125df00e0bad2795fe63d0b291a22da1c59e4d1a71f459b11c26ec3864f