[INFO] updating cached repository 11Takanori/rust-lisp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/11Takanori/rust-lisp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/11Takanori/rust-lisp" "work/ex/clippy-test-run/sources/stable/gh/11Takanori/rust-lisp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/11Takanori/rust-lisp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/11Takanori/rust-lisp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/11Takanori/rust-lisp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/11Takanori/rust-lisp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e733cdfbb3ada1261a229fc6bb7a278db825d68f [INFO] sha for GitHub repo 11Takanori/rust-lisp: e733cdfbb3ada1261a229fc6bb7a278db825d68f [INFO] validating manifest of 11Takanori/rust-lisp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of 11Takanori/rust-lisp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing 11Takanori/rust-lisp [INFO] finished frobbing 11Takanori/rust-lisp [INFO] frobbed toml for 11Takanori/rust-lisp written to work/ex/clippy-test-run/sources/stable/gh/11Takanori/rust-lisp/Cargo.toml [INFO] started frobbing 11Takanori/rust-lisp [INFO] finished frobbing 11Takanori/rust-lisp [INFO] frobbed toml for 11Takanori/rust-lisp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/11Takanori/rust-lisp/Cargo.toml [INFO] crate 11Takanori/rust-lisp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting 11Takanori/rust-lisp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/11Takanori/rust-lisp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1979ad41f8ca7ec53505ce14ae6e7054e037d495dabc88b39f6d7adf6f3f1f83 [INFO] running `"docker" "start" "-a" "1979ad41f8ca7ec53505ce14ae6e7054e037d495dabc88b39f6d7adf6f3f1f83"` [INFO] [stderr] Checking rust_lisp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:334:9 [INFO] [stderr] | [INFO] [stderr] 334 | / return match &obj { [INFO] [stderr] 335 | | &LObj::Nil | &LObj::Num(_) => Ok(obj.clone()), [INFO] [stderr] 336 | | &LObj::Sym(ref name) => { [INFO] [stderr] 337 | | let ret = match self.find_var(&obj, env) { [INFO] [stderr] ... | [INFO] [stderr] 344 | | _ => Ok(LObj::Nil), [INFO] [stderr] 345 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 334 | match &obj { [INFO] [stderr] 335 | &LObj::Nil | &LObj::Num(_) => Ok(obj.clone()), [INFO] [stderr] 336 | &LObj::Sym(ref name) => { [INFO] [stderr] 337 | let ret = match self.find_var(&obj, env) { [INFO] [stderr] 338 | Some(bind) => bind, [INFO] [stderr] 339 | _ => return Err(format!("{} has no value", name)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:418:9 [INFO] [stderr] | [INFO] [stderr] 418 | / return Ok(match f { [INFO] [stderr] 419 | | LObj::Subr(subr) => subr.call(&mut self.arena, &args), [INFO] [stderr] 420 | | LObj::Expr(body, env) => { [INFO] [stderr] 421 | | match self.arena.get(&body) { [INFO] [stderr] ... | [INFO] [stderr] 430 | | _ => return Err("not function".into()), [INFO] [stderr] 431 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 418 | Ok(match f { [INFO] [stderr] 419 | LObj::Subr(subr) => subr.call(&mut self.arena, &args), [INFO] [stderr] 420 | LObj::Expr(body, env) => { [INFO] [stderr] 421 | match self.arena.get(&body) { [INFO] [stderr] 422 | LObj::Cons(car, cdr) => { [INFO] [stderr] 423 | let args = self.arena.pairlis(car, args); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:334:9 [INFO] [stderr] | [INFO] [stderr] 334 | / return match &obj { [INFO] [stderr] 335 | | &LObj::Nil | &LObj::Num(_) => Ok(obj.clone()), [INFO] [stderr] 336 | | &LObj::Sym(ref name) => { [INFO] [stderr] 337 | | let ret = match self.find_var(&obj, env) { [INFO] [stderr] ... | [INFO] [stderr] 344 | | _ => Ok(LObj::Nil), [INFO] [stderr] 345 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 334 | match &obj { [INFO] [stderr] 335 | &LObj::Nil | &LObj::Num(_) => Ok(obj.clone()), [INFO] [stderr] 336 | &LObj::Sym(ref name) => { [INFO] [stderr] 337 | let ret = match self.find_var(&obj, env) { [INFO] [stderr] 338 | Some(bind) => bind, [INFO] [stderr] 339 | _ => return Err(format!("{} has no value", name)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:418:9 [INFO] [stderr] | [INFO] [stderr] 418 | / return Ok(match f { [INFO] [stderr] 419 | | LObj::Subr(subr) => subr.call(&mut self.arena, &args), [INFO] [stderr] 420 | | LObj::Expr(body, env) => { [INFO] [stderr] 421 | | match self.arena.get(&body) { [INFO] [stderr] ... | [INFO] [stderr] 430 | | _ => return Err("not function".into()), [INFO] [stderr] 431 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 418 | Ok(match f { [INFO] [stderr] 419 | LObj::Subr(subr) => subr.call(&mut self.arena, &args), [INFO] [stderr] 420 | LObj::Expr(body, env) => { [INFO] [stderr] 421 | match self.arena.get(&body) { [INFO] [stderr] 422 | LObj::Cons(car, cdr) => { [INFO] [stderr] 423 | let args = self.arena.pairlis(car, args); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / match self { [INFO] [stderr] 115 | | &LObj::Cons(ref x, _) => arena.get(x), [INFO] [stderr] 116 | | _ => LObj::Nil, [INFO] [stderr] 117 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 114 | match *self { [INFO] [stderr] 115 | LObj::Cons(ref x, _) => arena.get(x), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | / match self { [INFO] [stderr] 122 | | &LObj::Cons(_, ref x) => arena.get(x), [INFO] [stderr] 123 | | _ => LObj::Nil, [INFO] [stderr] 124 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 121 | match *self { [INFO] [stderr] 122 | LObj::Cons(_, ref x) => arena.get(x), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:155:21 [INFO] [stderr] | [INFO] [stderr] 155 | / match arena.get(car) == arena.get(&cdar) { [INFO] [stderr] 156 | | true => LObj::t(), [INFO] [stderr] 157 | | _ => LObj::Nil, [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if arena.get(car) == arena.get(&cdar) { LObj::t() } else { LObj::Nil }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:250:45 [INFO] [stderr] | [INFO] [stderr] 250 | } else if self.next.starts_with(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:265:41 [INFO] [stderr] | [INFO] [stderr] 265 | } else if self.next.starts_with(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:267:41 [INFO] [stderr] | [INFO] [stderr] 267 | } else if self.next.starts_with("(") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:270:41 [INFO] [stderr] | [INFO] [stderr] 270 | } else if self.next.starts_with("'") { [INFO] [stderr] | ^^^ help: try using a char instead: `'''` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:334:16 [INFO] [stderr] | [INFO] [stderr] 334 | return match &obj { [INFO] [stderr] | ________________^ [INFO] [stderr] 335 | | &LObj::Nil | &LObj::Num(_) => Ok(obj.clone()), [INFO] [stderr] 336 | | &LObj::Sym(ref name) => { [INFO] [stderr] 337 | | let ret = match self.find_var(&obj, env) { [INFO] [stderr] ... | [INFO] [stderr] 344 | | _ => Ok(LObj::Nil), [INFO] [stderr] 345 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 334 | return match obj { [INFO] [stderr] 335 | LObj::Nil | LObj::Num(_) => Ok(obj.clone()), [INFO] [stderr] 336 | LObj::Sym(ref name) => { [INFO] [stderr] 337 | let ret = match self.find_var(&obj, env) { [INFO] [stderr] 338 | Some(bind) => bind, [INFO] [stderr] 339 | _ => return Err(format!("{} has no value", name)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:379:35 [INFO] [stderr] | [INFO] [stderr] 379 | let ret = match try!(self.eval(car, env.clone())) != LObj::Nil { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 380 | | true => self.arena.get(&cdr).car(&self.arena), [INFO] [stderr] 381 | | _ => self.arena.get(&cdr).cdr(&self.arena).car(&self.arena), [INFO] [stderr] 382 | | }; [INFO] [stderr] | |_________________________^ help: consider using an if/else expression: `if try!(self.eval(car, env.clone())) != LObj::Nil { self.arena.get(&cdr).car(&self.arena) } else { self.arena.get(&cdr).cdr(&self.arena).car(&self.arena) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / match self { [INFO] [stderr] 115 | | &LObj::Cons(ref x, _) => arena.get(x), [INFO] [stderr] 116 | | _ => LObj::Nil, [INFO] [stderr] 117 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 114 | match *self { [INFO] [stderr] 115 | LObj::Cons(ref x, _) => arena.get(x), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | / match self { [INFO] [stderr] 122 | | &LObj::Cons(_, ref x) => arena.get(x), [INFO] [stderr] 123 | | _ => LObj::Nil, [INFO] [stderr] 124 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 121 | match *self { [INFO] [stderr] 122 | LObj::Cons(_, ref x) => arena.get(x), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:155:21 [INFO] [stderr] | [INFO] [stderr] 155 | / match arena.get(car) == arena.get(&cdar) { [INFO] [stderr] 156 | | true => LObj::t(), [INFO] [stderr] 157 | | _ => LObj::Nil, [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if arena.get(car) == arena.get(&cdar) { LObj::t() } else { LObj::Nil }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:250:45 [INFO] [stderr] | [INFO] [stderr] 250 | } else if self.next.starts_with(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:265:41 [INFO] [stderr] | [INFO] [stderr] 265 | } else if self.next.starts_with(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:267:41 [INFO] [stderr] | [INFO] [stderr] 267 | } else if self.next.starts_with("(") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:270:41 [INFO] [stderr] | [INFO] [stderr] 270 | } else if self.next.starts_with("'") { [INFO] [stderr] | ^^^ help: try using a char instead: `'''` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:334:16 [INFO] [stderr] | [INFO] [stderr] 334 | return match &obj { [INFO] [stderr] | ________________^ [INFO] [stderr] 335 | | &LObj::Nil | &LObj::Num(_) => Ok(obj.clone()), [INFO] [stderr] 336 | | &LObj::Sym(ref name) => { [INFO] [stderr] 337 | | let ret = match self.find_var(&obj, env) { [INFO] [stderr] ... | [INFO] [stderr] 344 | | _ => Ok(LObj::Nil), [INFO] [stderr] 345 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 334 | return match obj { [INFO] [stderr] 335 | LObj::Nil | LObj::Num(_) => Ok(obj.clone()), [INFO] [stderr] 336 | LObj::Sym(ref name) => { [INFO] [stderr] 337 | let ret = match self.find_var(&obj, env) { [INFO] [stderr] 338 | Some(bind) => bind, [INFO] [stderr] 339 | _ => return Err(format!("{} has no value", name)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:379:35 [INFO] [stderr] | [INFO] [stderr] 379 | let ret = match try!(self.eval(car, env.clone())) != LObj::Nil { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 380 | | true => self.arena.get(&cdr).car(&self.arena), [INFO] [stderr] 381 | | _ => self.arena.get(&cdr).cdr(&self.arena).car(&self.arena), [INFO] [stderr] 382 | | }; [INFO] [stderr] | |_________________________^ help: consider using an if/else expression: `if try!(self.eval(car, env.clone())) != LObj::Nil { self.arena.get(&cdr).car(&self.arena) } else { self.arena.get(&cdr).cdr(&self.arena).car(&self.arena) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `"docker" "inspect" "1979ad41f8ca7ec53505ce14ae6e7054e037d495dabc88b39f6d7adf6f3f1f83"` [INFO] running `"docker" "rm" "-f" "1979ad41f8ca7ec53505ce14ae6e7054e037d495dabc88b39f6d7adf6f3f1f83"` [INFO] [stdout] 1979ad41f8ca7ec53505ce14ae6e7054e037d495dabc88b39f6d7adf6f3f1f83