[INFO] updating cached repository 0xc0dec/shiny
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/0xc0dec/shiny
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/0xc0dec/shiny" "work/ex/clippy-test-run/sources/stable/gh/0xc0dec/shiny"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/0xc0dec/shiny'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/0xc0dec/shiny" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/0xc0dec/shiny"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/0xc0dec/shiny'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 9793c30664d0177227c4f3392f6f4c7c9e86fea9
[INFO] sha for GitHub repo 0xc0dec/shiny: 9793c30664d0177227c4f3392f6f4c7c9e86fea9
[INFO] validating manifest of 0xc0dec/shiny on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of 0xc0dec/shiny on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing 0xc0dec/shiny
[INFO] finished frobbing 0xc0dec/shiny
[INFO] frobbed toml for 0xc0dec/shiny written to work/ex/clippy-test-run/sources/stable/gh/0xc0dec/shiny/Cargo.toml
[INFO] started frobbing 0xc0dec/shiny
[INFO] finished frobbing 0xc0dec/shiny
[INFO] frobbed toml for 0xc0dec/shiny written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/0xc0dec/shiny/Cargo.toml
[INFO] crate 0xc0dec/shiny has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting 0xc0dec/shiny against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/0xc0dec/shiny:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 87c0e0519982b984ecd3329ed63e98a0b35c386c66d0733fb0afbb5878f4b645
[INFO] running `"docker" "start" "-a" "87c0e0519982b984ecd3329ed63e98a0b35c386c66d0733fb0afbb5878f4b645"`
[INFO] [stderr]    Compiling arrayref v0.3.5
[INFO] [stderr]    Compiling proc-macro2 v0.4.20
[INFO] [stderr]    Compiling vulkano v0.10.0
[INFO] [stderr]     Checking vk-sys v0.3.3
[INFO] [stderr]    Compiling tempfile v3.0.4
[INFO] [stderr]     Checking alga v0.7.2
[INFO] [stderr]     Checking crossbeam-deque v0.5.2
[INFO] [stderr]     Checking crossbeam-channel v0.2.6
[INFO] [stderr]    Compiling block-buffer v0.3.3
[INFO] [stderr]    Compiling sha2 v0.7.1
[INFO] [stderr]    Compiling glsl-to-spirv v0.1.7
[INFO] [stderr]     Checking crossbeam v0.4.1
[INFO] [stderr]    Compiling quote v0.6.9
[INFO] [stderr]     Checking nalgebra v0.16.8
[INFO] [stderr]    Compiling syn v0.14.9
[INFO] [stderr]     Checking vulkano-win v0.10.0
[INFO] [stderr]    Compiling vulkano-shaders v0.10.0
[INFO] [stderr]     Checking nalgebra-glm v0.1.3
[INFO] [stderr]    Compiling vulkano-shader-derive v0.10.0
[INFO] [stderr]     Checking shiny v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/spectator.rs:32:20
[INFO] [stderr]    |
[INFO] [stderr] 32 |               } else {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 33 | |                 if angle_to_top - delta >= 3.04 {
[INFO] [stderr] 34 | |                     delta = angle_to_top - 3.04;
[INFO] [stderr] 35 | |                 }
[INFO] [stderr] 36 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 32 |             } else if angle_to_top - delta >= 3.04 {
[INFO] [stderr] 33 |     delta = angle_to_top - 3.04;
[INFO] [stderr] 34 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Creating a reference that is immediately dereferenced.
[INFO] [stderr]   --> src/main.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 |         impl_vertex!(Vertex, position);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ref_in_deref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: Creating a reference that is immediately dereferenced.
[INFO] [stderr]   --> src/main.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 |         impl_vertex!(Vertex, position);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/spectator.rs:32:20
[INFO] [stderr]    |
[INFO] [stderr] 32 |               } else {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 33 | |                 if angle_to_top - delta >= 3.04 {
[INFO] [stderr] 34 | |                     delta = angle_to_top - 3.04;
[INFO] [stderr] 35 | |                 }
[INFO] [stderr] 36 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 32 |             } else if angle_to_top - delta >= 3.04 {
[INFO] [stderr] 33 |     delta = angle_to_top - 3.04;
[INFO] [stderr] 34 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Creating a reference that is immediately dereferenced.
[INFO] [stderr]   --> src/main.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 |         impl_vertex!(Vertex, position);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ref_in_deref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: Creating a reference that is immediately dereferenced.
[INFO] [stderr]   --> src/main.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 |         impl_vertex!(Vertex, position);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]  --> src/transform.rs:6:31
[INFO] [stderr]   |
[INFO] [stderr] 6 | const DIRTY_FLAG_LOCAL: u32 = 1 << 0;
[INFO] [stderr]   |                               ^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/transform.rs:101:17
[INFO] [stderr]     |
[INFO] [stderr] 101 |                 self.local_rot = self.local_rot * rot.normalized();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.local_rot *= rot.normalized()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:271:21
[INFO] [stderr]     |
[INFO] [stderr] 271 | /                     match virtual_keycode {
[INFO] [stderr] 272 | |                         Some(code) => {
[INFO] [stderr] 273 | |                             if code == winit::VirtualKeyCode::Escape {
[INFO] [stderr] 274 | |                                 run = false;
[INFO] [stderr] ...   |
[INFO] [stderr] 279 | |                         None => ()
[INFO] [stderr] 280 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 271 |                     if let Some(code) = virtual_keycode {
[INFO] [stderr] 272 |     if code == winit::VirtualKeyCode::Escape {
[INFO] [stderr] 273 |         run = false;
[INFO] [stderr] 274 |     }
[INFO] [stderr] 275 | 
[INFO] [stderr] 276 |     println!("Key {:?} {:?}", code, state);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]  --> src/transform.rs:6:31
[INFO] [stderr]   |
[INFO] [stderr] 6 | const DIRTY_FLAG_LOCAL: u32 = 1 << 0;
[INFO] [stderr]   |                               ^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/transform.rs:101:17
[INFO] [stderr]     |
[INFO] [stderr] 101 |                 self.local_rot = self.local_rot * rot.normalized();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.local_rot *= rot.normalized()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:271:21
[INFO] [stderr]     |
[INFO] [stderr] 271 | /                     match virtual_keycode {
[INFO] [stderr] 272 | |                         Some(code) => {
[INFO] [stderr] 273 | |                             if code == winit::VirtualKeyCode::Escape {
[INFO] [stderr] 274 | |                                 run = false;
[INFO] [stderr] ...   |
[INFO] [stderr] 279 | |                         None => ()
[INFO] [stderr] 280 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 271 |                     if let Some(code) = virtual_keycode {
[INFO] [stderr] 272 |     if code == winit::VirtualKeyCode::Escape {
[INFO] [stderr] 273 |         run = false;
[INFO] [stderr] 274 |     }
[INFO] [stderr] 275 | 
[INFO] [stderr] 276 |     println!("Key {:?} {:?}", code, state);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 25s
[INFO] running `"docker" "inspect" "87c0e0519982b984ecd3329ed63e98a0b35c386c66d0733fb0afbb5878f4b645"`
[INFO] running `"docker" "rm" "-f" "87c0e0519982b984ecd3329ed63e98a0b35c386c66d0733fb0afbb5878f4b645"`
[INFO] [stdout] 87c0e0519982b984ecd3329ed63e98a0b35c386c66d0733fb0afbb5878f4b645