[INFO] updating cached repository 0ncorhynchus/cafemake
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/0ncorhynchus/cafemake
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/0ncorhynchus/cafemake" "work/ex/clippy-test-run/sources/stable/gh/0ncorhynchus/cafemake"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/0ncorhynchus/cafemake'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/0ncorhynchus/cafemake" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/0ncorhynchus/cafemake"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/0ncorhynchus/cafemake'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5c5addf3e45534b915eb5b02bc1e5678d1fb2ab6
[INFO] sha for GitHub repo 0ncorhynchus/cafemake: 5c5addf3e45534b915eb5b02bc1e5678d1fb2ab6
[INFO] validating manifest of 0ncorhynchus/cafemake on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of 0ncorhynchus/cafemake on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing 0ncorhynchus/cafemake
[INFO] finished frobbing 0ncorhynchus/cafemake
[INFO] frobbed toml for 0ncorhynchus/cafemake written to work/ex/clippy-test-run/sources/stable/gh/0ncorhynchus/cafemake/Cargo.toml
[INFO] started frobbing 0ncorhynchus/cafemake
[INFO] finished frobbing 0ncorhynchus/cafemake
[INFO] frobbed toml for 0ncorhynchus/cafemake written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/0ncorhynchus/cafemake/Cargo.toml
[INFO] crate 0ncorhynchus/cafemake has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting 0ncorhynchus/cafemake against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/0ncorhynchus/cafemake:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 76f324988914fcabdfb93f9571fc6a89f2189bec33d6c091c8577dee7bef7427
[INFO] running `"docker" "start" "-a" "76f324988914fcabdfb93f9571fc6a89f2189bec33d6c091c8577dee7bef7427"`
[INFO] [stderr]     Checking memchr v2.1.0
[INFO] [stderr]     Checking aho-corasick v0.6.8
[INFO] [stderr]     Checking regex v1.0.5
[INFO] [stderr]     Checking cafemake v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/core.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             modules: modules,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `modules`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/core.rs:133:13
[INFO] [stderr]     |
[INFO] [stderr] 133 |             uses: uses,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `uses`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/core.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             modules: modules,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `modules`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/core.rs:133:13
[INFO] [stderr]     |
[INFO] [stderr] 133 |             uses: uses,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `uses`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/core.rs:45:18
[INFO] [stderr]    |
[INFO] [stderr] 45 |                 .unwrap_or(String::from("gfortran")),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("gfortran"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/core.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |             config.system.fflags.clone().unwrap_or(String::new()),
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `config.system.fflags.clone().unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/core.rs:60:55
[INFO] [stderr]    |
[INFO] [stderr] 60 |                     if ext.to_lowercase().starts_with("f") {
[INFO] [stderr]    |                                                       ^^^ help: try using a char instead: `'f'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/out/make.rs:53:8
[INFO] [stderr]    |
[INFO] [stderr] 53 |     if libs.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!libs.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/out/make.rs:81:8
[INFO] [stderr]    |
[INFO] [stderr] 81 |     if compile.uses.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!compile.uses.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/out/ninja.rs:84:8
[INFO] [stderr]    |
[INFO] [stderr] 84 |     if link.libs.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!link.libs.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/out/ninja.rs:112:8
[INFO] [stderr]     |
[INFO] [stderr] 112 |     if compile.uses.len() != 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!compile.uses.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/out.rs:40:24
[INFO] [stderr]    |
[INFO] [stderr] 40 | fn format_paths(paths: &Vec<PathBuf>) -> String {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^ help: change this to: `&[PathBuf]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/core.rs:45:18
[INFO] [stderr]    |
[INFO] [stderr] 45 |                 .unwrap_or(String::from("gfortran")),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("gfortran"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/core.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |             config.system.fflags.clone().unwrap_or(String::new()),
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `config.system.fflags.clone().unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/core.rs:60:55
[INFO] [stderr]    |
[INFO] [stderr] 60 |                     if ext.to_lowercase().starts_with("f") {
[INFO] [stderr]    |                                                       ^^^ help: try using a char instead: `'f'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/out/make.rs:53:8
[INFO] [stderr]    |
[INFO] [stderr] 53 |     if libs.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!libs.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/out/make.rs:81:8
[INFO] [stderr]    |
[INFO] [stderr] 81 |     if compile.uses.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!compile.uses.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/out/ninja.rs:84:8
[INFO] [stderr]    |
[INFO] [stderr] 84 |     if link.libs.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!link.libs.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/out/ninja.rs:112:8
[INFO] [stderr]     |
[INFO] [stderr] 112 |     if compile.uses.len() != 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!compile.uses.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/out.rs:40:24
[INFO] [stderr]    |
[INFO] [stderr] 40 | fn format_paths(paths: &Vec<PathBuf>) -> String {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^ help: change this to: `&[PathBuf]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.95s
[INFO] running `"docker" "inspect" "76f324988914fcabdfb93f9571fc6a89f2189bec33d6c091c8577dee7bef7427"`
[INFO] running `"docker" "rm" "-f" "76f324988914fcabdfb93f9571fc6a89f2189bec33d6c091c8577dee7bef7427"`
[INFO] [stdout] 76f324988914fcabdfb93f9571fc6a89f2189bec33d6c091c8577dee7bef7427